fix: NetworkVar implementations now uses Time of their owner NetworkM… #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
approved these changes
Apr 29, 2021
| @@ -403,7 +404,9 @@ public bool IsDirty() | |||
| get => m_Dictionary[key]; | |||
| set | |||
| { | |||
| if (NetworkManager.Singleton.IsServer) | |||
| EnsureInitialized(); | |||
There was a problem hiding this comment.
I suppose we only need these EnsureInitialized inside the IsServer block, yes?
There was a problem hiding this comment.
But in general I'm a little confused. This is an instance method, and we have m_NetworkBehaviour being initialized in the xtor (as private and readonly). Are we thinking somehow it could be nullified after the xtor? if it could be null at xtor time, then I would think we should throw an exception then. Concern is code clarity and the cost of doing these checks on every access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anager