test[NetworkVariable]: adjusting netvars manual tests #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyrainy
requested review from
0xFA11,
mattwalsh-unity and
NoelStephensUnity
JesseOlmer
changed the title
| if (m_Problems == "" && Math.Abs(m_MaxDelta - m_MinDelta) < 3) | ||
| // Let's be reasonable and allow a 5 tick difference | ||
| // that could be due to timing difference, lag, queueing | ||
| if (m_Problems == "" && Math.Abs(m_MaxDelta - m_MinDelta) < 5) |
There was a problem hiding this comment.
I would tend to replace the '5' as a constant to show meaning, like k_MaxAllowedTickDifference, and then say why '5', but I'm glad to have this comment for now
mattwalsh-unity
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.