feat: networkingmanager hud #510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeStampfli
changed the base branch from
develop
to
feature/transport-connect-address
LukeStampfli
commented
Mar 1, 2021
| /// <summary> | ||
| /// Stops the running server, client or host. | ||
| /// </summary> | ||
| public void Stop() |
There was a problem hiding this comment.
I'm not sure whether this is really a nice way to solve this. But I have run into this issue where I just wanted to have MLAPI stop the simulation and I didn't care whether I'm a server, client or host so I added this for convenience.
LukeStampfli
commented
Mar 1, 2021
| /// <summary> | ||
| /// Gets whether or not a server or client is running. | ||
| /// </summary> | ||
| public bool IsRunning => IsServer || IsClient; |
There was a problem hiding this comment.
Adding this for convenience to check whether the networking manager is running as a client, server or host.
LukeStampfli
commented
Mar 1, 2021
| { | ||
| [RequireComponent(typeof(NetworkingManager))] | ||
| [DisallowMultipleComponent] | ||
| public class NetworkingManagerHud : MonoBehaviour |
There was a problem hiding this comment.
Will update names to new standards once they are out 😃
LukeStampfli
changed the title
mattwalsh-unity
force-pushed
the
feature/transport-connect-address
branch
from
9594925 to
5f007d7
Compare
|
Closing this, it's part of the contrib repo, we can explore at a later time whether we want this in core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #512 to pass first!
Adds a drop in NetworkingManagerHud similar to Unet to MLAPI.
Connecting
While connected