fix: Error when using 'Use Encryption' with secure Relay #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
approved these changes
Nov 3, 2022
nlebedenco
approved these changes
Nov 3, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ologies#2289) * fix: Error when using 'Use Encryption' with secure Relay * Add PR number to CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you enabled encryption in
UnityTransportand then chose a Relay configuration that used a secure protocol, you'd get an error. Turns out our logic to display the error was simply using the wrong comparison.Changelog
UnityTransportwhere an error would be logged if the 'Use Encryption' flag was enabled with a Relay configuration that used a secure protocol.Testing and Documentation