feat: IPv6 support in UnityTransport [MTT-4801] #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmazom
approved these changes
Oct 3, 2022
johann-r-unity
approved these changes
Oct 3, 2022
0xFA11
approved these changes
Oct 4, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
felippeduran
pushed a commit
to felippeduran/com.unity.netcode.gameobjects
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTP fully supports IPv6, but this support was not available in the adapter because we only tried parsing user-provided IP addresses as IPv4. Supporting IPv6 was as simple as modifying the endpoint parsing code to also check for IPv6 addresses. The rest of the code changes is mostly adapting the tests to also test IPv6.
Note that when using Relay, only IPv4 is supported. AFAIK the Relay SDK only hands out IPv4 addresses so that's not really an issue for now. In any case, once I move the adapter to the new APIs provided by UTP 1.3 and 2.0 for Relay integration, IPv6 support will be taken care of transparently.
Changelog
UnityTransport.Testing and Documentation