fix: networkmanager starts when transport does not #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransport-does-not
…ransport-does-not
…ransport-does-not
0xFA11
reviewed
Mar 9, 2022
0xFA11
reviewed
Mar 9, 2022
| IsServer = true; | ||
| IsClient = false; | ||
| IsListening = true; | ||
| var result = NetworkConfig.NetworkTransport.StartServer(); |
There was a problem hiding this comment.
can we just kill result local variable entirely? (also below as well)
and turn if checks into if (NetworkConfig.NetworkTransport.StartServer() == false) etc.?
0xFA11
approved these changes
Mar 9, 2022
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
…ransport-does-not
NoelStephensUnity
deleted the
fix/mtt-2598-networkmanager-starts-when-transport-does-not
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NetworkTransport.StartServer returns false, we need to stop the startup process for both the StartHost or StartServer methods in NetworkManager. Otherwise there are failure to bind error messages and the server or host still thinks it is started.
MTT-2598
Changelog
com.unity.netcode.gameobjects
-Fixed: issue where NetworkManager would continue starting if the NetworkTransport selected failed.
Testing and Documentation