Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport multiple PRs as a single PR from experimental-develop branch #1665

Merged
merged 18 commits into from
Feb 11, 2022

Conversation

Rosme
Copy link
Contributor

@Rosme Rosme commented Feb 8, 2022

This PR is bringing into 1.1.0 the network metrics implementation inside the UTP Adapter to gather data from the transport:

  • Network Metrics Pipeline Stage to extract data from transport layer
  • Extraction of RTT metrics from transport
  • Extraction of Packet count from transport
  • Dispatching of said metrics into Netstats
  • Modification to test framework to support UTP Transport
  • Added Symbol Define based on tools version and presence of UTP Adapter

Original JIRA
MTT-1659
MTT-1854
MTT-1855
MTT-1655
MTT-1653

Original PRs
#1493
#1510
#1583
#1610
#1652

Testing and Documentation

  • Includes unit tests.
  • No documentation changes or additions were necessary.

Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment about the version define expression being pre,3 (should it be pre.4?), it looks good.

@@ -0,0 +1,69 @@
#if MULTIPLAYER_TOOLS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant with the check below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is yes. But it's also clear that you need TOOLS PRE 4 or higher. Eventually we will remove that check probably and I wouldn't want us to forget to put the TOOLS check. But if you rather have just the TOOLS_PRE_4, I can do that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any strong opinion on the matter, honestly. If the pre.4 check is meant to go away at some point, then I agree leaving the more generic tools check is safer.

@0xFA11 0xFA11 changed the title chore: Backporting of multiple PRs and changes as a single PR from develop branch chore: backport multiple PRs as a single PR from experimental-develop branch Feb 10, 2022
@NoelStephensUnity NoelStephensUnity merged commit 39bdb4a into develop Feb 11, 2022
@NoelStephensUnity NoelStephensUnity deleted the chore/transport-metrics-rtt-packet branch February 11, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants