-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport multiple PRs as a single PR from experimental-develop
branch
#1665
chore: backport multiple PRs as a single PR from experimental-develop
branch
#1665
Conversation
com.unity.netcode.adapter.utp/Runtime/com.unity.netcode.adapter.utp.asmdef
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one comment about the version define expression being pre,3 (should it be pre.4?), it looks good.
@@ -0,0 +1,69 @@ | |||
#if MULTIPLAYER_TOOLS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this redundant with the check below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is yes. But it's also clear that you need TOOLS PRE 4 or higher. Eventually we will remove that check probably and I wouldn't want us to forget to put the TOOLS check. But if you rather have just the TOOLS_PRE_4, I can do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any strong opinion on the matter, honestly. If the pre.4 check is meant to go away at some point, then I agree leaving the more generic tools check is safer.
experimental-develop
branch
…-Technologies/com.unity.netcode.gameobjects into chore/transport-metrics-rtt-packet
This PR is bringing into 1.1.0 the network metrics implementation inside the UTP Adapter to gather data from the transport:
Original JIRA
MTT-1659
MTT-1854
MTT-1855
MTT-1655
MTT-1653
Original PRs
#1493
#1510
#1583
#1610
#1652
Testing and Documentation