Skip to content

fix: Fix OwnedObjects not being added to when using ChangeOwnership #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2022
Merged

fix: Fix OwnedObjects not being added to when using ChangeOwnership #1572

merged 4 commits into from
Jan 11, 2022

Conversation

TwoTenPvP
Copy link
Contributor

@TwoTenPvP TwoTenPvP commented Jan 10, 2022 •
edited
Loading

Fixes: #1525

Previously, an object was not added to a clients OwnedObjects list when the ChangeOwnership API was used.
MTT-1975

PR Checklist

  • Have you added a backport label (if needed)? For example, the type:backport-release-* label. After you backport the PR, the label changes to stat:backported-release-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR or a link to the documenation repo PR if this is a manual update.

Changelog

com.unity.netcode.gameobjects

  • Fixed OwnedObjects not being properly modified when using ChangeOwnership.

Testing and Documentation

  • Includes unit tests.

@TwoTenPvP TwoTenPvP requested a review from 0xFA11 January 11, 2022 12:26
0xFA11
0xFA11 reviewed Jan 11, 2022
View reviewed changes
0xFA11
0xFA11 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TwoTenPvP @0xFA11
Update com.unity.netcode.gameobjects/CHANGELOG.md
48cde80 
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
@TwoTenPvP TwoTenPvP enabled auto-merge (squash) January 11, 2022 12:44
@TwoTenPvP TwoTenPvP merged commit ef6201d into develop Jan 11, 2022
@TwoTenPvP TwoTenPvP deleted the ownedobjects-add branch January 11, 2022 13:05
@0xFA11 0xFA11 mentioned this pull request Feb 19, 2022
Merged
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
@TwoTenPvP
fix: Fix OwnedObjects not being added to when using ChangeOwnership (U…
ea1000a 
…nity-Technologies#1572)

Fixes: Unity-Technologies#1525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OwnedObjects of clientId is not set correctly after ChangeOwnership(clientId)
2 participants
@TwoTenPvP @0xFA11