fix: Fix NetworkVariable<INetworkSerializable> so that it will proper… #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly call NetworkSerialize instead of using the default memcpy operation. (#1383) * fix: Fix NetworkVariable<INetworkSerializable> so that it will properly call NetworkSerialize instead of using the default memcpy operation. * Changelog entry * standards fix * Whoops, syntax error. * More standards fixes * Fixed typo * Moved changelog entry to Unreleased
0xFA11
approved these changes
Nov 24, 2021
…able_NetworkVariables
…able_NetworkVariables
andrews-unity
deleted the
backport/1.0.0-fix-INetworkSerializable_NetworkVariables
branch
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…ly call NetworkSerialize instead of using the default memcpy operation. (Unity-Technologies#1383) (Unity-Technologies#1463) * fix: Fix NetworkVariable<INetworkSerializable> so that it will properly call NetworkSerialize instead of using the default memcpy operation. * Changelog entry * standards fix * Whoops, syntax error. * More standards fixes * Fixed typo * Moved changelog entry to Unreleased Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com> Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1383