fix: RPC ILPP generating invalid IL code when using this instead of this ref for the FastBufferReader/FastBufferWriter parameter of an extension method.
#1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. Also updated the test so both `this` and `this ref` are exercised - the documentation says to use `this`, but `this ref` was what worked... so for backward compatibility both have to be supported.
andrews-unity
approved these changes
Nov 4, 2021
|
|
andrews-unity
pushed a commit
that referenced
this pull request
Nov 24, 2021
… `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. (#1393) * fix: RPC ILPP generating invalid IL code when using `this` instead of `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. Also updated the test so both `this` and `this ref` are exercised - the documentation says to use `this`, but `this ref` was what worked... so for backward compatibility both have to be supported. * Changelog * standards fix
andrews-unity
added a commit
that referenced
this pull request
Nov 24, 2021
… `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. (#1393) (#1459) * fix: RPC ILPP generating invalid IL code when using `this` instead of `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. Also updated the test so both `this` and `this ref` are exercised - the documentation says to use `this`, but `this ref` was what worked... so for backward compatibility both have to be supported. * Changelog * standards fix Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com> Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
andrews-unity
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
… `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. (Unity-Technologies#1393) * fix: RPC ILPP generating invalid IL code when using `this` instead of `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. Also updated the test so both `this` and `this ref` are exercised - the documentation says to use `this`, but `this ref` was what worked... so for backward compatibility both have to be supported. * Changelog * standards fix
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
… `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. (Unity-Technologies#1393) (Unity-Technologies#1459) * fix: RPC ILPP generating invalid IL code when using `this` instead of `this ref` for the FastBufferReader/FastBufferWriter parameter of an extension method. Also updated the test so both `this` and `this ref` are exercised - the documentation says to use `this`, but `this ref` was what worked... so for backward compatibility both have to be supported. * Changelog * standards fix Co-authored-by: Jaedyn Draper <284434+ShadauxCat@users.noreply.github.com> Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the test so both
thisandthis refare exercised - the documentation says to usethis, butthis refwas what worked... so for backward compatibility both have to be supported.MTT-1566
fixes #1355
Changelog
com.unity.netcode.gameobjects
thisinstead ofthis reffor the FastBufferReader/FastBufferWriter parameter of an extension method.Testing and Documentation