Skip to content

fix: NetworkList.Contains inverted #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix: NetworkList.Contains inverted #1363

merged 1 commit into from
Oct 27, 2021

Conversation

mattwalsh-unity
Copy link
Contributor

This fixes issue #1352 (NetworkList.contains value is inverted). The logic was flipped AND there was a typo in the test.

type:backport-release-1.0

PR Checklist

Changelog

com.unity.netcode.gameobjects

Testing and Documentation

  • Includes fix to integration tests.

0xFA11
0xFA11 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattwalsh-unity mattwalsh-unity enabled auto-merge (squash) October 27, 2021 15:58
@mattwalsh-unity mattwalsh-unity merged commit cf0c9b4 into develop Oct 27, 2021
@mattwalsh-unity mattwalsh-unity deleted the fix/network-list-contains branch October 27, 2021 15:59
@LukeStampfli LukeStampfli mentioned this pull request Jan 26, 2022
Merged
3 tasks
LukeStampfli pushed a commit that referenced this pull request Jan 26, 2022
@mattwalsh-unity @LukeStampfli
fix: NetworkList.Contains inverted (#1363)
8b7e841 
(cherry picked from commit cf0c9b4)
@LukeStampfli LukeStampfli mentioned this pull request Jan 26, 2022
Merged
mattwalsh-unity added a commit that referenced this pull request Jan 26, 2022
@LukeStampfli @mattwalsh-unity
fix: network list contains backport 1.0.0 (#1622)
565f99e 
* changelog

(cherry picked from commit 2b16478)

* changelog

* Update CHANGELOG.md

(cherry picked from commit db8126d)

* fix: NetworkList.Contains inverted (#1363)

(cherry picked from commit cf0c9b4)

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
@ashwinimurt
Copy link
Contributor

Backport merged, removing label.

mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
@mattwalsh-unity
fix: NetworkList.Contains inverted (Unity-Technologies#1363)
85dc4f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattwalsh-unity @ashwinimurt @0xFA11 @LukeStampfli