fix: network time arguments #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyrainy
approved these changes
Sep 16, 2021
0xFA11
approved these changes
Sep 16, 2021
mattwalsh-unity
approved these changes
Sep 16, 2021
…-Technologies/com.unity.netcode.gameobjects into fix/network-time-arguments
SamuelBellomo
added a commit
that referenced
this pull request
Sep 17, 2021
* develop: feat: INetworkMessage (#1187) fix: Increase timeout for UTP adapter tests (#1199) docs: Update repo and both package readme files (#1180) chore: updating UTP package to pull in DTLS fixes (#1197) fix: network time arguments (#1194) feat: network physics (#1175) # Conflicts: # com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs # com.unity.netcode.gameobjects/Components/NetworkTransform.cs # testproject/Assets/Prefabs/PlayerCube.prefab
SamuelBellomo
added a commit
that referenced
this pull request
Sep 17, 2021
…transform-teleport * sam/feature/client-network-transform: adding proper delta sending feat: INetworkMessage (#1187) fix: Increase timeout for UTP adapter tests (#1199) docs: Update repo and both package readme files (#1180) chore: updating UTP package to pull in DTLS fixes (#1197) fix: network time arguments (#1194) feat: network physics (#1175) # Conflicts: # testproject/Assets/Scenes/ZooSam.unity
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
* fix: use uint for tickrate and more rigorous argument checking for 0 tickrate * tickrate to uint in buffered interpolator * time editor tests use uint and use testcase attribute to cleanup tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small improvement to networktime to ensure that tickrate is a positive value
Makes sure no negative tick values can be used as mentioned in #1185 (but not directly related)