Skip to content

chore: support standalone mode for netcode runtimetests #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2021
Merged

chore: support standalone mode for netcode runtimetests #1115

merged 4 commits into from
Aug 31, 2021

Conversation

JesseOlmer
Copy link
Contributor

  • Move GlobalObjectIdHash tests out of package tests and into testproject
  • Move ObjectParenting tests out of package tests and into testproject
  • Fix InternalsVisibleTo to work outside of editor for RuntimeTests assembly
  • if UNITY_EDITOR guards on editor attributes in SIPTransport

chore: Make runtimetests work in standalone player
933d96e 
- Move GlobalObjectIdHash tests out of package tests and into testproject
- Move ObjectParenting tests out of package tests and into testproject
- Fix InternalsVisibleTo to work outside of editor for RuntimeTests assembly
- if UNITY_EDITOR guards on editor attributes in SIPTransport
@JesseOlmer
Copy link
Contributor Author

@zain-mecklai this should add a significant amount of test coverage to the standalone tests - 1405 tests by my count.

0xFA11
0xFA11 reviewed Aug 31, 2021
View reviewed changes
testproject/Assets/Tests/Runtime/GlobalObjectIdHash/NetworkObjectGlobalObjectIdHashTests.cs
var execAssembly = Assembly.GetExecutingAssembly();
var packagePath = PackageInfo.FindForAssembly(execAssembly).assetPath;
var scenePath = Path.Combine(packagePath, $"Tests/Runtime/GlobalObjectIdHash/{nameof(NetworkObjectGlobalObjectIdHashTests)}.unity");
const string scenePath = "Assets/Tests/Runtime/GlobalObjectIdHash/" + nameof(NetworkObjectGlobalObjectIdHashTests) + ".unity";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less programmatic but also less dependent — path looks clear and obvious to me, so I think this is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these paths work on mobile platforms?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, they should. IIRC, Assets/xxx is a project relative path and not directly OS-dependent.

0xFA11
0xFA11 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JesseOlmer JesseOlmer enabled auto-merge (squash) August 31, 2021 17:10
@JesseOlmer JesseOlmer merged commit af1ce68 into develop Aug 31, 2021
@JesseOlmer JesseOlmer deleted the chore/standalone-runtimetests branch August 31, 2021 17:26
SamuelBellomo added a commit that referenced this pull request Sep 2, 2021
@SamuelBellomo
Merge branch 'develop' into sam/feature/interpolation-for-network-tra…
669b878 
…nsform

* develop: (26 commits)
  fix: client connected InvokeOnClientConnectedCallback with scene management disabled (#1123)
  fix: removed `public` class `NetcodeObserver` (MTT-1157) (#1122)
  feat: add NetworkMessageSent/Received metrics (#1112)
  feat: snapshot. MTU sizing option for Snapshot. MTT-1087 (#1111)
  Add metrics for transport bytes sent and received (#1104)
  fix: Missing end profiling sample (#1118)
  chore: support standalone mode for netcode runtimetests (#1115)
  feat: Change MetricNames for a more complex value type (#1109)
  feat: Track scene event metrics (#1089)
  style: whitespace fixes (#1117)
  feat: replace scene registration with scenes in build list (#1080)
  fix: mtt-857 GitHub issue 915 (#1099)
  fix: NetworkSceneManager exception when DontDestroyOnLoad NetworkObjects are being synchronized (#1090)
  feat: NetworkTransform Custom Editor Inspector UI (#1101)
  refactor: remove TempGlobalObjectIdHashOverride (#1105)
  fix: MTT-1124 Counters are now reported in sync with other metrics (#1096)
  refactor: convert using var statements to using var declarations (#1100)
  chore: updated all of the namespaces to match the tools package change (#1095)
  refactor!: remove network variable settings, network behaviour cleanup (#1097)
  fix: mtt-1088 review. Safer handling of out-of-order or old messages (#1091)
  ...

# Conflicts:
#	com.unity.netcode.gameobjects/Prototyping/NetworkTransform.cs
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
chore: support standalone mode for netcode runtimetests (Unity-Techno…
6910d87 
…logies#1115)

- Move GlobalObjectIdHash tests out of package tests and into testproject
- Move ObjectParenting tests out of package tests and into testproject
- Fix InternalsVisibleTo to work outside of editor for RuntimeTests assembly
- if UNITY_EDITOR guards on editor attributes in SIPTransport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 approved these changes

@mattwalsh-unity mattwalsh-unity mattwalsh-unity approved these changes

@zain-mecklai zain-mecklai Awaiting requested review from zain-mecklai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JesseOlmer @0xFA11 @zain-mecklai @mattwalsh-unity