Skip to content

feat: replace scene registration with scenes in build list #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Aug 30, 2021
Merged

feat: replace scene registration with scenes in build list #1080

merged 30 commits into from
Aug 30, 2021

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Aug 23, 2021 •
edited
Loading

(Replacement for PR-967)
MTT-887
This feat implements the use of only the Build Settings Scenes in Build list as opposed to having to register scenes in the NetworkManager. This includes the PR-955 changes and should be easier to review once PR-955 is squashed and merged.

Acceptance Criteria:

  • Pass all of the existing unit tests that use NetworkSceneManager
  • Provide a means for the user to control what scenes are valid or not via NetworkSceneManager.VerifySceneBeforeLoading

Acceptance Tests:

  • The existing NetworkSceneManagerTests.SceneLoadingAndNotifications (already existed)
  • This PR includes a new NetworkSceneManagerTests.SceneVerifyBeforeLoadTest that verifies user defined scene verification works both on the server and client side.

@NoelStephensUnity
Squashed commit of the following:
e0e9ca9 
commit 1e733823da0772d185f21bc11bd2d9c027cddab0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 19:54:59 2021 -0500

    test fix

    Make sure we deregister when unloading/scene transitioning but not when quitting.

commit 02f18928eb296437287c91fdfbce7352ce3268ab
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 19:48:51 2021 -0500

    refactor and fix

    Refactoring some of the test project scripts, fixing an issue in the editor where ScenesInBuild count could become 0 but not populated, slight geometry level tweaks to help prevent corner edge cases, and merging the prefab handler with the prefab pool to reduce code complexity.  (really need to merge the prefab pools together)
    Also some minor tweaks to the random movement when not the owner for temporary adjustment (this needs to become velocity based).

commit 1c4eb3013261b3ea3c79145dfc50d6fcb9bba3fe
Merge: 018ff78e bf5ddd4b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 18:11:39 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit bf5ddd4b057a5e6189ef749de757d138c8aba49b
Merge: 961ad0a9 b5afae7b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 18:10:01 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit b5afae7b1fa600eff56640d3a3445a1167e2828b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 17:57:48 2021 -0500

    refactor

    Removes returning bool to determine if NetworkPrefabHandler should destroy an object with Fatih's awesome fixes from PR-1068
    https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1068

commit cf4d249a86ef10921eb8afd386fce8241251a293
Merge: f80e853e 00a0e051
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 17:44:35 2021 -0500

    Merge remote-tracking branch 'origin/fix/bad-netobj-dest-fixes' into feat/MTT-820-AdditiveSceneLoading

commit f80e853efb297036d7feed5855aafab6c613b3cf
Merge: cf06cf02 0db6789a
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 23:00:01 2021 +0100

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 00a0e051165b96d6e19c5aa530a1d72811d9350b
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 22:58:56 2021 +0100

    remove obsolete comment

commit d2dc3212bf8c4321b2f76b38cc21456718859299
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 22:53:19 2021 +0100

    fix: eliminate bad use-after-free(destroy) pattern

commit cf06cf02b2ce89ff3311c12586ce8a14ea3850f1
Merge: 3f76dc18 8e9900b5
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 21:27:09 2021 +0100

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 3f76dc187744744a519e82174400efbf4e493b17
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:27:24 2021 -0500

    fix unit test

    Fixing the change in exception thrown when trying to call NetworkSceneManager.Load or NetworkSceneManager.Unload without having set NetworkConfig.EnableSceneManagement.

commit 6aaaa5499ef3e5662f612637fb733c1bcdcebdba
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:21:30 2021 -0500

    fix

    Fixing committed suggested change bug.

commit a1f5ae3c532cc94ef1ba628bb13d8cd1b403ce3f
Merge: 4f71b1c2 db097ee1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:15:59 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into feat/MTT-820-AdditiveSceneLoading

commit 4f71b1c2ec24c033ec909a130911b8ea750c95af
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:15:34 2021 -0500

    test fix

    Fixing an issue that can occur in a testproject helper script where the wrong scene could be applied to the wrong "toggler" when loaded.

commit db097ee10db1029ffd17dadac0bfa28f4de060d6
Author: Noel Stephens <noel.stephens@unity3d.com>
Date:   Wed Aug 18 13:57:35 2021 -0500

    Update

    Applying Fatih's super-nit.

    Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>

commit 018ff78ecf9b59e9392df159a7cda0f0f89d3144
Merge: 709b2154 961ad0a9
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 13:00:41 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 961ad0a9ca77d4979d0f24541018131bf6a39065
Merge: 93051e3a 8acb31cc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 12:58:42 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 8acb31cc8f9d7ef45d168d14321d024345661f5f
Merge: 75817ed5 43d4494c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 12:55:58 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 75817ed5c1168596b4989436e7a338b605eceed8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 12:55:48 2021 -0500

    refactor and style

    Removing a check that is no longer needed.
    Improved an exception message.
    Improved some comments.
    Removed a CR

commit 39005dd31bc0f7ad98d423655e75509ea11096d8
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 14:06:54 2021 +0100

    `./standards.py --fix`

commit 27d8f50699718261856f87b874762bc217fdc171
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 14:00:47 2021 +0100

    minor editor UI polish

commit 709b215407405fc29eed202997f3866f0fcd2076
Merge: d7f1f67d a5f0a795
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 07:06:23 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 93051e3af782802bf9ac23f59d1a9d943103e969
Merge: 3a490018 a5f0a795
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 07:05:12 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit a5f0a795076155718b0fde587e38785207a505c1
Merge: cc83d1cc 19e6d3ca
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 07:02:37 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit cc83d1ccfb47082a0c385442ba9297b95022b3d3
Merge: 536a8e5c d30f6170
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 12:48:11 2021 +0100

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit d7f1f67dbbccd6a632179e2e8ad9ca5c902806b4
Merge: 610c2ec4 536a8e5c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:10:05 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 3a4900184e84e05fd800de8edf83f6989b25357d
Merge: e7813baf 536a8e5c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:09:48 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 536a8e5c4b19a69037f88f046434e789a8ebe135
Merge: ecc1083d e89f05db
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:09:23 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 610c2ec447c8d23e6018a274813642ec34dfca09
Merge: fe51176e ecc1083d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:07:00 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit e7813baf7709be9b005ece115dbe7aa0cc68ec59
Merge: b2d5a0f6 ecc1083d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:06:41 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit ecc1083d7ff00de3bcd565776eb11be708509e1b
Merge: 831c3a3b 85f84fbc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:05:50 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 831c3a3b2480a3391b4acff76b39d5805c46cc6a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 17:52:47 2021 -0500

    style

    Adding additional comment to further clarify usage of a multidimensional dictionary

commit 747f1f73711d2cd07bf172f6da2b7fd80cbe3180
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 17:49:43 2021 -0500

    refactor

    removing unused m_ObservedObjects.

commit fe51176ecc5a0257f666f9170e04a95b23212ce7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 16:05:40 2021 -0500

    fix

    This fixes the scenario where you open a scene in the editor that does not have a NetworkManager instance (i.e. MainMenu in testproject) and then while still in play mode navigate to a scene that does have a NetworkManager instance, then (editor only) the ScenesInBuild asset will be created (if one doesn't exist), refreshed/repopulated, and assigned to the NetworkManager instance.

commit 8bef1fc92e6e5af6f6c1b91db73f6dcc4accfd2f
Merge: a644105c 7f559f5a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 14:31:34 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit b2d5a0f60e9b46060a11ec931c6fa5800fb3658b
Merge: 19ba7ae5 7f559f5a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 14:31:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 7f559f5afa6cd0868fb602cd6e1f21261c61dc7e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 14:29:52 2021 -0500

    stle

    Renamed NotifyPlayerConnected to ApprovedPlayerSpawn

commit a644105c6d9e073d3b839bcb5c783a1864a3132c
Merge: 8afc9f3e 1b421007
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:19:15 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 19ba7ae5eaa47c4dbd16e7dea6162cf6ead43450
Merge: 715b73bc 1b421007
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:15:30 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 1b42100741c8a1aba6ef5d45b51a0359b50ccd71
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:14:52 2021 -0500

    fix

    Minor stats display issue with another sneaky resources meta file that somehow made it into a previous commit.

commit 670166b4da352ef054f0e9c44d93ac9722417add
Merge: 581adfa0 24cebfb2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:09:28 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 8afc9f3e2c44953f0d4c518ecdbb7309ab70cd53
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 11:56:20 2021 -0500

    fix

    Reverting tail end of MultiInstance test NetworkObject destruction to Destroy and not DestroyImmediate (some might be in the process of being destroyed which can cause an exception after unit test is done).

commit c3c482ac0511d28a85f99c9f43351f192181a330
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 11:48:45 2021 -0500

    refactor

    removing Resources.meta file that was accidently added in previous commit.

commit cb180d4e0505aeac876a35cb53fe54cd7807f504
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 11:43:35 2021 -0500

    fix

    Applying some fixes from the PR-955 merged changes.
    Adding some additional fixes that avoid loading scenes on the client side during multiInstance unit tests.

commit 581adfa0401b87c80969a62eb49fe6c21436a8cc
Author: Noel Stephens <noel.stephens@unity3d.com>
Date:   Tue Aug 17 08:41:47 2021 -0500

    Update com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

    Co-authored-by: Luke Stampfli <43687322+LukeStampfli@users.noreply.github.com>

commit 237dd02d4baf29a23570ce4fcb8d891296c37570
Merge: b7fa2386 715b73bc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 13:56:53 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 715b73bc933e71d65b68eb15dc04a5669c885012
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 13:36:44 2021 -0500

    refactor

    Refactoring unit test for most recent NetworkSeneManager updates.

commit 497670bc012550a01c185bee719c6b125bf4733c
Merge: d3b9a202 d1902c8c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 12:50:39 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit d1902c8c46fd2f6cdef0ef697af30b97a6c74fb0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 09:21:00 2021 -0500

    test

    updating test projects build settings scenes in build list with new scene to work with additive scene manual testing levels

commit 51198d547f980caaac12cf3692f5ee6c1d943cf4
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 20:41:30 2021 -0500

    style

    updated comments and added some xml doc see refs.

commit 1130fe1e804cc1cd3a18ea6c7c1430ca19d5f576
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 19:14:34 2021 -0500

    Test

    For real, this is my last fix test and then I will ask Tools team about the issues involved in trying to debug their tests locally.

commit 1618a13afaca2c6e00b3337f697855c03fa7fdae
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 18:31:13 2021 -0500

    fix test

    Last try of the day... just delete every NetworkObject that exists when we start a mutli-instance test.

commit 84c513a7732ed11e3a1219940362a4e89488e163
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 17:19:33 2021 -0500

    fix

    Removing my tools fix as that was the wrong place to fix that issues.  The error causing issue actually came before those two tests where something was being instantiated but never destroyed.  If this fails then I might need to do the same thing with the Setup side of things as well.

commit 2e1ce677f60b79ba018f29a654a2d372f340a4f7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 16:54:29 2021 -0500

    fix

    Fixing some tools unit test related issues.

commit 2485c89ca0d7a5b521c6015dad8ee1149aa99ae7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 16:19:10 2021 -0500

    fix and style

    removed the unused namespace from NetworkPrefabHandlerTests

commit 20874b406ba000e052c09ec5065482ef71a002a8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 16:16:11 2021 -0500

    fix

    Fixing minor issue with the standard NetworkPrefabPool (really need to merge these two classes) where it wasn't removing the registration from NetworkPrefabHandler when a scene was unloaded (only in the traditional SceneTransitioningTest without additive scene loading).

commit 7fd53e62462b86a5badb7f524d1f11835a6cbe8e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 15:25:15 2021 -0500

    Fix

    Lots of fixes with the new requirements.
    We will need to come up with a better way to instantiate NetworkObjects for unit tests, but this includes all of the fixes required to get all current unit tests working again.

commit 1c12d7c11d6e4f66588a441494777e23e81007be
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 14:02:08 2021 -0500

    refactor and feat

    This includes several updates:
    We now load all scenes first and then we synchronize all NetworkObjects after all scenes have loaded (during the client synchronization process).  This means users no longer have to register any form of dependency with NetworkObjects.

    This includes the additional modifications to support loading the same additive scene (within scene placed NetworkObjects) multiple times.  This did require a bit of refactoring and some improvements in how we organize our InScenePlacedObjects.

    The SceneTransitioningAdditive manual tests (SceneTransitioningBase1 is root scene) include demonstration of loading/unloading the same additive scene repeatedly.

commit b7fa2386f41602b161e1e6a7f2fe91f684a24b75
Merge: 8ba63115 0d074688
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 11:37:02 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit d3b9a20239d5cff6d4cf33cf0367810c5b8ccc1e
Merge: fdb9caa4 0d074688
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 11:36:02 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 0d07468841474fae1bc99b6fab4d7268b6dd8cdd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 11:35:44 2021 -0500

    style

    removing MLAPI from sceneIndex

commit 8ba63115f48d954601bc34210aa9770cc81ee377
Merge: 0af58abb 2a8ea862
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 09:26:27 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit fdb9caa4245e01fa841074909ca3482f1eb23197
Merge: b438aa31 2a8ea862
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 09:26:15 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 2a8ea86295bd13d56196855ff49baac3922d378c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 09:25:52 2021 -0500

    refactor

    Assigning the TargetClientId for NetworkVariable writing.
    This could change with the snapshot stuff and the up-and-coming change in read/write permissions, but for the time being making sure this is set only for S2C_Sync events.

commit 0af58abb20012b257b2993fad4c4128a72ba8c66
Merge: 9cdb5d66 36e89c25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:25:24 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit b438aa31d33f45f6111b37c69d5245e4e00e063f
Merge: 7e7c1735 36e89c25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:25:06 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 36e89c25228067ee87dd93a8d9e5ff821251baf8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:24:52 2021 -0500

    style

    Added or updated some comments for better clarity.

commit 9cdb5d6650093fd57904ab5f109cc3ab5764209f
Merge: a30592ab def25430
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:06:26 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 7e7c1735b0b67c3f9025636755f00f0944bc1206
Merge: bc9598b3 def25430
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:06:08 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit def254305d196105df8ce997a9aff1a007cc51e7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:05:46 2021 -0500

    style

    removing the TODO and my initials from MTT-860 comments and providing a bit more of an explanation

commit a30592ab1ae3edc8df7d0b7e761ceb4bb2c1bdc6
Merge: 44590cde e5a98164
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:55:24 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit bc9598b3d6ca69075de11fd1916423953fd381c5
Merge: 49a4d492 e5a98164
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:54:59 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit e5a9816443042c90b22ef39c42d613c0964975e9
Merge: 68789d99 5deae108
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:54:42 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 44590cde9d9e6fd44a54a69f676d4297191f39da
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:05:46 2021 -0500

    fix

    Manual Test Fix:
    AdditiveSceneToggleHandler needed to check for SceneFailedVerification status, otherwise it would fail to exit the coroutine but never finish its change in state.

commit a803802368e8d60ca2c0995a2a18bb6b7fddacfc
Merge: 1fc19dbe 68789d99
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 10:21:03 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 49a4d49234cc8a12484db7a6856f375c4726d16e
Merge: 4df10130 68789d99
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 10:16:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 68789d99042c8cb144510efa807c8aac451867e0
Merge: 3a7a0e4e 6b58eeb0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 10:07:12 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 1fc19dbeacbcd86c3ccd51ef7e2a946d0f04cbf3
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:26:01 2021 -0500

    update

    Forgot to move the number of clients back up to 9.

commit 0500c3ff7aa8174aed20e3f86f24e1bbd39faf38
Merge: 9a7208d6 3a7a0e4e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:03:26 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 4df10130abaed35af44890bc2fecf76aed40531d
Merge: 2a279af5 3a7a0e4e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:02:44 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 3a7a0e4ec6c9d470d45c442d43f84ea4372ba87a
Merge: f4778085 87f9ec96
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:02:25 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 9a7208d6c6327d213ae2edaa90d7b713c3b85cfb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 16:51:54 2021 -0500

    refactor fix and test

    Removed the client event notification as it wasn't needed.
    Fixed a minor bug in scene validation that was discovered via the unit test.
    Added another unit test to the NetworkSceneManagerTests that verifies the NetworkSceneManager scene validation process works and that users can control which scenes are loaded (test covers both client and server).
    Updated and added XML document comments for methods and properties.

commit 24b782d3898ac415912342c71c7f8b92e6cac4c9
Merge: 499a6073 f4778085
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 09:27:37 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 2a279af51c8ffd7b4fdd25db0cef0964f1849b2f
Merge: af243af5 f4778085
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 09:27:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit f4778085f474fdcd57966ad475fe3b8901f32dbb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 19:53:20 2021 -0500

    style

    added comment

commit d3ff2e4c64ad648b9eb8f45afe273567ff321fe3
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:57:27 2021 -0500

    fix

    Seconds vs frame count
    Mac failed.

commit 499a6073b71b3a34fdb37f893d70689570c663d2
Merge: af604487 1387b1fa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:20:34 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit af243af56ddc68dbfd26d5cefb320d1aa72c857b
Merge: 80e50fff 1387b1fa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:20:08 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 1387b1fa7f046cecaf20ead6c88480602a959095
Merge: d38145ba 589882c0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:19:45 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit af6044871e9f83328a3ddb867f646f56333d947c
Merge: f96bcd28 d38145ba
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:18:03 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 80e50fffb3ff940aa9701d2f6ea65b2fe5e2329e
Merge: bb941b6d d38145ba
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:17:22 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit d38145bae0ede16a081c63c912b2af0366346336
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:16:43 2021 -0500

    refactor

    Removing check for NetworkObject being null in NetworkBehaviourUpdater, this is no longer needed.

    Removing artifact debug output (testing purposes) that was missed.

commit f96bcd28fb63279a96d5a13857dec7c1229c18bb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 16:18:08 2021 -0500

    feat and style

    Added a client side notification for scene verification failure.
    Added some xml documentation in pertinent places.

commit 60fd08318d7245497a5b8d04f5c1a88582a98c76
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 15:05:09 2021 -0500

    style

    One last namespace not being used.

commit 99e42f91bb6abc1da95cfe9d16f06c6bd704250c
Merge: 1404ca2f 9f1e05fd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:47:26 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit bb941b6deb3bb28912bfdf42e51a19ed63e059fb
Merge: cca47688 9f1e05fd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:47:06 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 9f1e05fde6b477df6b2919140921d9b05739e22e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:46:53 2021 -0500

    refactor

    Removing the target frame rate check in the SetUp.

commit 1404ca2f0eb447527f14d2c6652dca6752177a9d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:41:49 2021 -0500

    style

    Removed unused namespaces for compliance/standards purposes.

commit bed3c30a73e880a27de729c1bdd1fd9d2fe89fb8
Merge: 6559ec97 b9be4739
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:10:14 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit cca476882e569faafd9d6691640fc7f1a2f102a4
Merge: 33b1bd8a b9be4739
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:08:15 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit b9be47391f9068d770abf7f159df38fe46beb493
Merge: 925e02e0 01ad0c21
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:07:46 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit 6559ec97153e8fadf8a9fda001cf94f883428cd8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:05:35 2021 -0500

    refactor

    Updated to most recent PR-955 and develop namespace changes.

commit 99b6e2b30b94ed2e684914e556caba37a6cfaa8f
Merge: 9d8c0b79 33b1bd8a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 12:15:44 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 33b1bd8a6c99654c868a03f9cdb4688c1e9a3700
Merge: 93a31da3 925e02e0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 11:20:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 925e02e0ac388afc6cc9b2a413027f8fa104aec8
Merge: 79fd5b25 dce2e54d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 11:11:56 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 93a31da3abbfd4c75b0ddc7d44172accc597de26
Merge: 34a6db48 79fd5b25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 17:09:10 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 79fd5b2519b003c7c2126c2984ef75a5f1e48cc0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 17:08:36 2021 -0500

    refactor

    reverting timeouts to 5 seconds each.

commit 34a6db48cd8a5fd78be866a86fdf253197f7b3d5
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 17:07:07 2021 -0500

    refactor

    Removing the target frame rate, reducing the wait times

commit 77f15b54a36fe5e5c1379d1b8b4a58a737a717b6
Merge: 2e7f9b40 0db23c32
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 15:51:30 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 0db23c324ef43d5044555f38b85557258abc7e64
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 15:37:40 2021 -0500

    fix

    Message ordering seemed to have issues with application target frame rate.
    Checking this and setting it prior to running a test seems to fix the issue with failing on the FixedUpdate side of things.

commit 84b4d04d85864d9b4dc9a0d29414b9121f337cfb
Merge: 6b9b4c05 40a6aec0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 15:09:57 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 2e7f9b4096a1846182fbfd92563a050508e3f76e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:46:28 2021 -0500

    fix

    Aligning the exception messages for client trying to start Load or Unload scene events.

commit b12c168eae6991bba8eb616b4839b642cb1efe3f
Merge: b08f5b57 6b9b4c05
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:38:11 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 6b9b4c05a74362a4976806d3ff409a02008bc4bd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:36:42 2021 -0500

    fix and style

    replacing exception message reference to scene switch with scene event.
    Fixing check for scene not being loaded check in UnloadScene.

commit b08f5b5722d2219527d7d4195d412ecac8a31c83
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:33:31 2021 -0500

    test

    Added the following checks:
    Loading during an existing scene event in progress returns SceneEventProgressStatus.SceneEventInProgress.
    Client trying to start a Load scene event throws an exception
    Client trying to start an Unload scene event throws an exception
    Unloading a scene that is not loaded returns SceneEventProgressStatus.SceneNotLoaded.
    Loading a scene that does not exist returns SceneEventProgressStatus.InvalidSceneName.

commit a0f6b39e09846c013fa6d218fe537ac44c377725
Merge: 1fe70247 bac7f416
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Aug 7 09:42:02 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit bac7f416ae29624277984c6d2d1eee07bf4afb77
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Aug 7 09:41:24 2021 -0500

    style and refactor

    Minor clean up on some comments.
    Minor refactoring of property and method accessibility.

commit 1fe70247b384fefb36a7488a3f9f7966528161aa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Aug 7 09:22:03 2021 -0500

    style

    updated comment

commit 82d356c485e76b51a70010db921d6d168a448978
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:43:01 2021 -0500

    refactor

    Removing the no longer used SceneLoadingTest

commit 34ec78646a2e50327dd28ed761405336c2215d4c
Merge: 06e96f2d adc58d89
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:41:25 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit adc58d8944458b0ffdd60439f9d115570474aebb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:11:08 2021 -0500

    refactor

    Removed debug information from SceneEventData.

commit 06e96f2d1ebef652c5b5b575cd075548e37db7df
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:05:59 2021 -0500

    refactor

    Moved code from legacy NetworkSceneManagerTest for assert when trying to load a scene with EnableSceneManagement set to false into the new NetworkSceneManagerTest.
    Removed the legacy NetworkSceneManagerTests script.

commit f1c0b21096468587002162573269b56d363a0995
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 17:45:42 2021 -0500

    test

    This is a multi-instance unit test with 1 host and 9 clients.  This tests the entire scene event notification sequence for loading and unloading additive scenes.
    This includes some changes to the new NetworkSceneManager required to do multi-instance unit tests.

commit c1d299aac76811154880826b2d366e5b7c483d15
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 15:39:29 2021 -0500

    refactor

    Added the ability to disable the re-synchronization for future snapshot development purposes.

commit 98354515fe7f0ff83fc9eb70afe757ce99cd0f66
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 08:21:03 2021 -0500

    refactor

    Removing two exceptions that will not be needed.

commit cfa48e63e63298dfef8aeb7a5139ec471536c35f
Merge: 831fd1da d89e2f2f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 19:55:02 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 831fd1da8a9d88cc082abd2ef11ef5de598c4032
Merge: 37be5bc4 8919c1ed
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 15:35:46 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 37be5bc455300f633a3fd622e30cded02fa0e8d2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 15:35:31 2021 -0500

    style

    Did one last XML Documentation pass.

commit fa2aaaa9396d03421df81423d8297f513febab1f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 14:29:21 2021 -0500

    feat

    Finalized replacing all notification related events with scene events.
    SceneEvent now includes two additional types:
    S2C_LoadComplete: Server to client(s) all clients loaded scene
    S2C_UnLoadComplete: Server to client(s) all clients unloaded scene
    These replace the event notifications that specified all clients have loaded a specific scene, with the additional functionality that this notification is sent for both loading and unloading for all loading modes.

    Removed the legacy internal messages and related methods for all clients done loading a scene.

    This should mark the final overhaul for notifications

commit 139edff30404111537efddf47426a36b591e6dfa
Merge: 06e8a58a 1da76b29
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 10:16:31 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 06e8a58a70441c8548cd40b7f57381dad62c767c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 23:57:43 2021 -0500

    feat

    SwitchSceneProgress changed to SceneEventProgress and is no longer a returned value when starting a scene event (load or unload).  This is still used internally to track when all clients have loaded the scene in question, but that is primarily used for SceneLoadingMode.Single.

    Removed the coroutine callback from NetworkManager and placed it within the SceneEventProgress class.

commit a608797972a5f5c09221610b53af9e84b5f940d8
Merge: 8495d1f8 d71dd1b8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 22:50:53 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 8495d1f85538fff40895fdd6e478c89fb7a2dd61
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 20:03:08 2021 -0500

    fix, refactor, and style

    re-fixing an issue with sending spawn calls to every client (n) times based on the number of clients connected (until it is re-fixed by the offender)

    Started the removal of certain NetworkSceneManager event notifications that are no longer required due to the more recent SceneEvent notifications.

    Removed the set active scene scene event for MS-1 (just not enough time to implement and be sure that it works perfectly)

    Removed a manual test for SceneManager callbacks that won't be used any longer.

    Updated XML documentation in various areas.

commit af56bdd2c4eb348cd19a8a1c04ce65a40bfcf0ad
Merge: 6d4d52fa f881d338
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 18:46:54 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 6d4d52fac651e6c1b4824f7d427e514c131d1d37
Merge: 277292e6 95886c59
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 18:28:55 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 277292e690dc8750e54d8be4f7a4faafc82ba6fa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 18:08:13 2021 -0500

    feat

    Improved notifications and detection of notifications for manual verification that they are triggering properly.
    Added a SceneEventNotificationQueue test project script that is to be used with the NetworkManager to detect edge case notifications (i.e. in the middle of a scene transition).
    Fixed an edge case scenario with NetworkObject.Despawn that could occur during exiting the application and the SpawnManager no longer exists.

commit 978e8de133dd39692bead7ca23f24b9370e3aaf1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 16:14:41 2021 -0500

    style

    slightly increased the player prefab size

commit c30251b1579182171a25e70051bbc54c2c36d367
Merge: 5cffe56f 5b9f953b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 16:07:47 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 5cffe56f7873507b9674d78bc3c05a55b81b32cb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 16:06:20 2021 -0500

    feat

    Implemented the full scene event notification system that provides detailed information for both client(s) and server.  Made some modifications to the StatsDisplay that provides visual queues for when each scene event occurs.

commit 69a4751a1590dfe6f5c4d98c2f5f7a7a94153d18
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:56:22 2021 -0500

    refactor

    Updates to account for the namespace change...again.

commit 6a41cb8ce49f86099bc8fb49bd09ab7ccd333c61
Merge: c31c119c 838c6e5b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:51:28 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit c31c119c4e18f1dbdc6f9828648600bfc0011dc7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:33:06 2021 -0500

    refactor

    Removing completely irrelevant code...

commit 3f98c0ab0a32c7e27d128babcfefa9cb9c64f218
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:23:49 2021 -0500

    refactor and style

    Refactored the prefab pool examples for the changed  INetworkPrefabInstanceHandler interface.
    Made some adjustments to the code based on suggestions.
    In particular added a prefix to the SceneEventData.SceneEventTypes to help identify which is server to client and client to server.

commit ea747d3b887a621fde343725d4a61cb7e5deac7d
Merge: 5c4de91f f5c51f25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 20:54:17 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 5c4de91ff5878b18a941dc2b500e3802f95d0f90
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 17:21:25 2021 -0500

    style

    Fixing non-required using statements.

commit 3274c561ebfbb12e22c58de4bd7c426d073a6603
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 17:08:13 2021 -0500

    refactor and fix

    Refactoring the Stats Display a bit.
    Added check for NetworkBehaviour Updater to not try to access the NetworkObject if it is null.  This can happen under scenarios where too many objects are being spawned and destroyed at the same time.

commit fd90a507320960aadcd094168ccd5c9502d67cc7
Merge: d7822d6c f8a7ef01
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 16:22:50 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit d7822d6cd7d874c029abe07da0f329ffaf77f8a6
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 16:20:50 2021 -0500

    fix

    merge fix.

commit d708f5e9a858ce84b1077b8f63340983b107e041
Merge: 22112987 6b78f322
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 16:14:21 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 221129870538e7987348e00052de0268ec19e960
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 15:52:32 2021 -0500

    refactor

    Updating additive pooling with additive scene unloading.
    Added the ability to specify whether  NetworkObjects should be destroyed on scene unload or not.  If the SpawnInSourceScene is set to true and the DestroyOnUnload is not set, then the already spawned NetworkObjects are moved to the currently active scene to allow them to persist until they naturally are destroyed.

    Fixed issues with most objects already destroyed messages.  Still have a few that pop up from time to time.

    Fixed issue with client not sending responses back to server.

    Refactored NetworkPrefabHandler and INetworkPrefabInstanceHandler so that the destroy method returns a bool value which determines if the NetworkObject should actually be destroyed or not (there are edge case scenarios this fixes).  Updated several tests to reflect these changes.

commit 77e9e07e9014e8a3816bd9d8d0e37d06c78b35b6
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 10:12:38 2021 -0500

    fix

    temporary fix for scene loading test.

commit c9fb565ce54e2fff3b9d9772c249e1bd1bf102a1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 09:19:42 2021 -0500

    fix

    Standards check for no longer needed using statments

commit 49a0b3d3528792bf9a2e904f49d1bba1ac9ae0d8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 2 22:12:07 2021 -0500

    fix

    This includes fixes for the namespace changes.

commit 4aa60b2fc8b6c12f285e5d29c9e247036f938ebc
Merge: ccd659e3 c8eb5fca
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 2 22:04:05 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit ccd659e3363f4d40e39adeaa0530ffcdb3046a4c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 2 11:36:47 2021 -0500

    fix

    Checking for NetworkManager to exist before disabling.

commit c67dc73de9ac0dbf425ff1b94331fbd4708f08b4
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 1 20:26:00 2021 -0500

    refactor

    Work in progress for local notifications, how network prefab handler pools destroy objects, and how NetworkObjects marked for or not marked for do not destroy on load are handled.

commit c0da88954bc06e3b9455958061ba134787789d2f
Merge: f092e45a cbe74c2e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 1 19:06:59 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit f092e45a056851d2a459b69c01031469368020a2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 29 17:54:37 2021 -0500

    refactor

    Cleaning up merge from develop.
    Starting to work on the local notification side of things.

commit 67057603f230748166aed262a9f928ddf5009cc2
Merge: d369c1c8 d6b2a486
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 29 14:33:25 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit d369c1c80baba35dd7dee11a5a1078e44db08a91
Merge: 26e94bb2 4b900723
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 29 14:08:13 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 26e94bb23918b0c39eb6cf2ab7343024fb65ab7f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 28 11:39:43 2021 -0500

    test

    Forgot to remove the applied frame rate.

commit 3bb2dc6ff5caf3cc5862a35aae16dfff6012d206
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 28 11:34:25 2021 -0500

    test

    Updating this adjustment to see if this makes it through the mac tests.

commit 44365744aae26d95057df01d9db9c43ccfdb85ff
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 19:00:06 2021 -0500

    refactor

    Removing temporary fix for issue with NetworkBuffer.
    Adding a test to the NetworkTransformTests to see if frame rate has anything to do with the seemingly random failures only on MAC.

commit b2157b97fcd723d246a44581417802738cdefd6e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 18:17:27 2021 -0500

    refactor

    Reverted minor modifications to transform test.

commit 0aacdfe8ae871ad60788901a8c8c6d514e2e9483
Merge: 039ca2c8 c25821d2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 18:14:36 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 039ca2c84cf6ff55cacb5f84a04076153066930f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:53:00 2021 -0500

    refactor

    Increasing timeout for one at a time.

commit 28eb59ed6c0898db2ce05bb44c6476031f7ea147
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:25:36 2021 -0500

    refactor

    removed and re-added scenes in build list

commit b65203e04b9d36b04dbb7ae826636150e40de82b
Merge: 217748a1 82e1c33e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:24:54 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 217748a1b78281798d2fda6f04609f46dbfd802d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:10:53 2021 -0500

    fix

    Removing some adjustments I did not intend on checking in.

commit 28545c3e7aaa6fbe19aea5701455cdecc4e8ae75
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 08:07:12 2021 -0500

    refactor and fix

    Refactoring things based on more recent changes.
    Predominantly the Message Ordering changes and the time synchronization.

commit 7b5fb895c4d74dc6c0d1c820c4dd30f8417f3ee2
Merge: a1fdf5bb b9ffc1f1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Jul 23 18:26:57 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 9d8c0b7992dd0227e526584259dbf55db56f0c97
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 22 15:58:34 2021 -0500

    style

    this comment was left out of last commit.

commit 510226d12f1bb06e27a71587f4c7f57904e1b9b9
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 22 15:57:33 2021 -0500

    feat and refactor

    Added ValidateSceneBeforeLoading delegate and method to provide users with a way to validate a scene before it is loaded for security and/or validation purposes.

    Removed AllowRuntimeSceneChanges

    Updated some comments

commit 444263ebca3ba51bebe0a1f2006e4b273c60baeb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 18:49:23 2021 -0500

    fix

    There were two issues:
    Assets outside of the primary project domain, which I had to put some checks to prevent from populating under specific scenarios (i.e. first time loading test project with no ScenesInBuildList asset).  Then with testing I had to bypass these checks so dynamically created NetworkManagers would be assigned the ScenesInBuildList asset automatically.
    This should fix the later issue and fix previous yamato failed builds.

commit 8ccc6d343f51afb44b571aff2c0b9c2e3ceb2654
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 16:30:08 2021 -0500

    Fix

    Found a potential issue with having references in a different assembly and/or first time loading the testproject.

commit 29c5360fe29651047a936532f56728fe563d9386
Merge: d8eb7e55 a1fdf5bb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 16:01:42 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit a1fdf5bb4df736192a9e0e31c9cc684285f6543b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 15:59:09 2021 -0500

    FIx and Style

    Fix for client side where during resync the GameObject was being destroyed but the spawn manager's lists tracking spawned NetworkObjects was not being updated.  The symptom was when a NetworkObjectId was recycled for a new NetoworkObject the client would still have that NetworkObjectId registered.

    This also includes some style updates.

commit d8eb7e55f06b396eee9f7940d01b2e7c6dcb0ad3
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 15:51:52 2021 -0500

    Fix

    Removing re-syncd NetworkObject from spawn manager, this was causing delayed NetworkObjectId assignment issues on the client side.

    Also, added check to not populate the scenes in build when transitioning into or out of play mode.

commit 39313ebd3c3d10f70841afcdc8e961143a2092de
Merge: 707c3273 c890f06c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 14:38:43 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit c890f06ce8cc266b9eb742391ef4bb3045a95c32
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 14:38:01 2021 -0500

    Refactor and Fix

    Fixed issue with rogue dynamically spawned NetowrkObjects that were spawned during a client scene synchronization sequence where it required a Custom NetworkPrefab hanler to spawn properly but the scene containing that custom network prefab handler had yet to be loaded so it was never associated with the pool.

    Migrated the additive scene loading scene transitioning tests into the manual tests region of TestProject

commit 707c32738a0f0e088d7d7a7e86874f45b60370d9
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 17:45:50 2021 -0500

    feat

    This creates a ScenesInBuild asset if one does not exist as well as populates it with the names of the scenes in the build to keep the same types of checks done within the NetworkSceneManager (i.e. does the scene index exist etc).
    The ScenesInBuild asset can detect if it is moved around, however it is created in the root assets folder initially.  It also updates itself to the scenes in build list via the serialization process.
    All NetworkManager instances reference this asset.  In turn, the NetworkSceneManager access the ScenesInBuild.Scenes list now.
    Adjusted all unit tests and helpers for this update as well (except multiprocessor).
    TestRunner passes all tests in editor and play modes.

commit e798cc27ee9227c39d5e231c2c2cfdd81d2708ac
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 12:29:15 2021 -0500

    WIP

    Work in progress

commit 28d9df4c1a0818ce1d7e6529780024c1ed604c6c
Merge: 55ffbd3b fa2be6f1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 08:59:06 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit 55ffbd3b48cccba178e2a72e1a3d9f3bbf21a188
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 08:58:41 2021 -0500

    style

    comments and naming

commit 9ac6a86ed982de93044347c116e45db94f7ebc58
Merge: e16628cf bdd7d714
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 15 17:21:03 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit e16628cf7886f1810d0d2e887b49cb05bfd25846
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 15 17:18:20 2021 -0500

    refactor and feat

    Did some minor refactoring to make Load and Unload the only two methods that need to be called.  Removed the switch event related enum types since they are no longer used.

    Added a re-synchronization step to handle edge case scenarios where a late joining client might miss destroy messages during the initial synchronization process.  This includes adding an additional DependentSceneName property to NetworkObject.  This lets the NetworkSceneManager know that a scene other than the NetworkObject's current scene is dependent upon this NetworkObject and to not instantiate it until that dependent scene is loaded.

    Removed a bunch of user-side code (i.e. test project) from GenericNetworkObject that was required to handle the above edge case scenarios regarding scene dependencies.  Adjusted the NetworkPrefabPool and NetworkPrefabPoolAdditive to account for this addition, and removed a chunk of user-side code that would be required to handle this scenario.

    Refactored SceneEventData to not implement INetworkSerializable which removes additional allocation for the NetworkSerializer during read and write operations.  Also adjusted the constructor to accept a NetworkManager instance to make it multi-instance compatible.

    Set the SceneTransitioningBase1 NetworkManager config to not recycle NetworkObjectIds due to an issue in how they are recycled.  (topic for discussion)

commit c686eee1e9bc207d4f5b251406a59da34cb16b2f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 14 16:41:19 2021 -0500

    fix

    Removing Scene Loading Test:
    This test needs to be completely refactored and no longer is valid.
    WIP

commit 4bcd93154defca41b6f7d77900aa47957b3a8b61
Merge: d1670b79 13e2b7f1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 14 15:57:48 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit d1670b79f9bb4b27c561d84452369ff96a9445cc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 14 15:45:20 2021 -0500

    refactor and fix

    Minor test project fixes and additional tests for the AdditiveSceneToggleHandler to test back to back scene loading during a scene transition.
    Removed the distinguishing difference between switchscene and loadscene, left the switchscene as a wrapper around loadscene.
    Updated existing profiling code base to remove legacy scene manager profiler checks.

commit 3a7a0e9ccd1de3d74f1616a042dc6533000adade
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 17:02:02 2021 -0500

    style

    PascalCased my enums and added event in front to avoid any NDA complications for the time being.

commit d7846f82def8d9bfe2d1757fdd025569fbc6d017
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 16:33:06 2021 -0500

    fix

    Adding missing scene assets for the multiprocess test.
    Making sure the SceneLoading test destroys the network manager instance.

commit d8828190dd12983d0282bda55d7b7d5bdc158db9
Merge: a5c3bf84 089c2065
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 15:42:50 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit a5c3bf845c4be027869c870361a9b03b672f7c91
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 15:41:11 2021 -0500

    fix

    Two issues were discovered while getting the parenting test working:
    1.) t was doing a move objects to scene during the client side synchronization process (which doesn't need to happen) and as such was setting all parents to null which was throwing an exception.
    2.) The server side wasn't filtering out any pre-loaded scenes during the synchronization process.

commit 35a46b746ce85aea925148717ec2681eb6283ed6
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 13:15:59 2021 -0500

    fix

    Fixing other unit test issues.
    Removing the temporary block for clients to receive messages (it was an artifact from testing).
    Still have a few tests that are failing.

commit 729a2ce09aef653fdc5371f9437333b796d62a72
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 12:02:53 2021 -0500

    fix

    Fixes the basic scene transitioning test failure.

commit ef7736903aad357db46ec7133f148e16754f04a4
Merge: 5d10e276 833f1faf
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 09:55:26 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 5d10e276e8e6ef54e87876d6df9494d09c968fa2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 09:21:19 2021 -0500

    refactor

    Minor checks for an object still being around during clean up.

commit df9bc79286977e56c04890d80bf0c8bec913e72b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Jul 11 21:24:49 2021 -0500

    feat and refactor

    Some temporary fixes for message ordering and buffering during late-join until this gets merged with the message ordering updates and we add the ability to buffer messages while a player is late-joining. Primarily in the GenericNetworkObjectBehaviour class.

    Added a proposed solution to handle order of operations if user decides to allow all NetworkObjects from a prefab pool to be spawned in the active scene.  This requires the ability to separate NetworkObjects (server side) by associated scene so that they will be synchronized properly with their spawn generator's pool.

    Now tracking which additive scenes have been loaded to be assured they are unloaded when doing a full scene switch (i.e. singlemode loading), otherwise there can be issues that arise with currently loaded additive scenes.

commit 88617d2e56586e63917936fc8216ce45e1862f8a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Jul 11 15:06:37 2021 -0500

    feat

    Improved the NetworkPrefabPool and NetworkPrefabPoolAdditive implementations to properly handle the various potential use case scenarios.  These changes assure that both the client and the server leverage from the pool.  This also takes into account NetworkManager defined NetworkPrefab overrides.

    Added temporary LoadSceneEvent callback that notifies if an additive scene is being loaded or unloaded.

    Updated the NetworkPrefabPoolAdditive sample to demonstrate how a user can assure their NetworkObjects are "spawned" in the same additive scene as their spawn generator.  This pattern will always destroy all NetworkObjects if the additive scene is unloaded.

    Added sorting of NetworkObjects just prior to the server side serializing them in order to assure INetworkPrefabInstanceHandler implementations are registered first,  this is required in order to assure that the handler is registered before any NetworkObjects associated with it are spawned.

commit d41b8d37d88949a111428616c9b189578b0bcada
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Jul 10 17:19:28 2021 -0500

    refactor

    Removed static properties in NetworkSceneManager that were no longer being used.
    Fixed issue with host not having the proper network prefab override (i.e. running as host vs running as server).
    Moved SceneEventData into its own .cs file.
    Excluding the local notification events, this is very close to being finalized, with the exception of custom prefab overrides and additive scene loading.  This still has issues with late joining (most likely thi…
@NoelStephensUnity
refactor
3e1c307 
This is a merge refactoring due to an issue with one of the dependent branches (test/additivesceneloading) that was broken while Fatih was showing me an alternate way to handle daisy chaining branches.

Went ahead and followed the same path Fatih took with fixing the additive scene testing.

It still has an issue with the unit test, but it is close to being back to the way it was with the additional updates from PR-955.
@NoelStephensUnity
fix
473ab82 
missed an exception message update.
@NoelStephensUnity
refactor and fix
38a6092 
This includes scene verification in the synchronization process [refactor].

This also includes unit test modifications for the NetworkObjectParentingTests to assure we don't try to reload the unit test temporary scene and moves the client connected and disconnected event handler subscription removal into the OnNetworkDespawn.
@NoelStephensUnity
style
9bba5e2 
fixing some standards related issues.
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
5707ea3 
…es-in-build-list
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
9a940f4 
…es-in-build-list
@NoelStephensUnity
refactor
0948ff6 
Refactoring scenes in build and unit testing.
@NoelStephensUnity
refactor
908b547 
moving the unit test check
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
0948eb5 
…es-in-build-list
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review August 24, 2021 21:56
@NoelStephensUnity
refactor
d766225 
This crept back into this branch. Removing this check as it isn't needed any longer.
@NoelStephensUnity
style
302806a 
removing minor LF changes which removes these 3 files from the PR.
ShadauxCat
ShadauxCat reviewed Aug 24, 2021
View reviewed changes
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
f9eb801 
…es-in-build-list
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
cccd5fa 
…es-in-build-list
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
797c796 
…es-in-build-list
@NoelStephensUnity
fix
7825b55 
missed a parenthesis removal.
@NoelStephensUnity
refactor
734d362 
Removed ScenesInBuild populate from NetworkManager.
Refactored how we initialize the ScenesInBuild list during unit tests for editor and stand alone.
Adjusted all unit and integration tests to the above modifications.
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
b6cd121 
…es-in-build-list
ShadauxCat
ShadauxCat approved these changes Aug 27, 2021
View reviewed changes
@NoelStephensUnity
refactor
556a42a 
Using UNITY_INCLUDE_TESTS as opposed to UNIT_EDITOR || DEVELOPMENT_BUILD
@NoelStephensUnity
refactor
b3ae163 
Reverting and condensing
Got rid of DefaultScenesInBuildAssetNameAndPath
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
9dd19bb 
…es-in-build-list
@NoelStephensUnity
Merge branch 'develop' into feat/replace-scene-registration-with-scen…
0941082 
…es-in-build-list
@NoelStephensUnity
refactor
acfab6e 
Removes the circular reference by creating a 3rd helper class to handle the initial creation and synchronization process.
@NoelStephensUnity
refactor
82cf538 
Found a much better way to generate the scenes in build list while running in the editor or as a stand alone development or release build.  This completely removes the ScenesInBuild asset and all dependencies.
@NoelStephensUnity
refactor
a974752 
minor adjustment to a unit test where server and client NetworkManagers are being initialized in one pass as opposed to two.
NoelStephensUnity and others added 2 commits August 30, 2021 14:28
@NoelStephensUnity @mattwalsh-unity
Update com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkS…
0b203fd 
…ceneManager.cs

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
@NoelStephensUnity @mattwalsh-unity
Update com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkS…
c81d05d 
…ceneManager.cs

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
mattwalsh-unity
mattwalsh-unity reviewed Aug 30, 2021
View reviewed changes
com.unity.netcode.gameobjects/Tests/Runtime/MultiInstanceHelpers.cs
@@ -131,15 +126,16 @@ public static void Destroy()
// Destroy the network manager instances
foreach (var networkManager in NetworkManagerInstances)
{
Object.Destroy(networkManager.gameObject);
Object.DestroyImmediate(networkManager.gameObject);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we mean to make this change to DestroyImmediate here and below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

mattwalsh-unity
mattwalsh-unity approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@mattwalsh-unity mattwalsh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few minor points still in my PR that I'm interested in your take on but I don't want those to be showstoppers for the PR. Very nice.

@NoelStephensUnity
refactor
f24c16e 
Refactoring based on a few of Matt's suggestions:
Completely removed the GetSceneNameFromBuildIndex as it really wasn't needed.

Removed passing the scene name into the ValidateSceneBeforeLoading method as that really didn't need to be passed in as a parameter either.
@NoelStephensUnity
Merge branch 'feat/replace-scene-registration-with-scenes-in-build-li…
07d722a 
…st' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into feat/replace-scene-registration-with-scenes-in-build-list
@NoelStephensUnity
refactor
8c18e4b 
Minor adjustment for SceneEventProgress.  Set the SceneIndex as opposed to name.
@NoelStephensUnity NoelStephensUnity merged commit c1ee3b6 into develop Aug 30, 2021
@NoelStephensUnity NoelStephensUnity deleted the feat/replace-scene-registration-with-scenes-in-build-list branch August 30, 2021 21:29
0xFA11
0xFA11 reviewed Aug 30, 2021
View reviewed changes
com.unity.netcode.gameobjects/Runtime/SceneManagement/SceneEventProgress.cs
@@ -84,7 +88,7 @@ internal class SceneEventProgress
/// </summary>
internal bool AreAllClientsDoneLoading { get; private set; }

internal string SceneName { get; set; }
internal uint SceneIndex { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scene[What]Index ?

Copy link
Collaborator Author

@NoelStephensUnity NoelStephensUnity Sep 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is short for "SceneBuildIndex". I will change that in another PR I have open.
You can confirm the changes in PR-1123

0xFA11
0xFA11 reviewed Aug 31, 2021
View reviewed changes
com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs
/// <param name="sceneName">Name of the scene</param>
/// <param name="loadSceneMode">LoadSceneMode the scene is going to be loaded</param>
/// <returns>true (valid) or false (not valid)</returns>
public delegate bool VerifySceneBeforeLoadingDelegateHandler(int sceneIndex, string sceneName, LoadSceneMode loadSceneMode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal bool ValidateSceneBeforeLoading(...) is internal but these types are public, why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC Explains what this is used for. I go into more details later in comments.

0xFA11
0xFA11 reviewed Aug 31, 2021
View reviewed changes
com.unity.netcode.gameobjects/Tests/Runtime/ObjectParenting/NetworkObjectParentingTests.cs
Comment on lines +57 to +58
// We need NetworkManager to be instantiated first before you load scenes externally in order to be able to determine if
// we are running a unit test or not. (it is this or manually setting a property)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I follow here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an artifact comment.

0xFA11
0xFA11 reviewed Aug 31, 2021
View reviewed changes
com.unity.netcode.gameobjects/Tests/Runtime/ObjectParenting/NetworkObjectParentingTests.cs
Comment on lines +110 to +111
// Register our scene verification delegate handler so we don't load the unit test scene
entry.SceneManager.VerifySceneBeforeLoading = VerifySceneBeforeLoading;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if VerifySceneBeforeLoading implementation is really needed and should be exposed/rolled-out to public like this.

What we are saying fundamentally is that "in tests, do not care about scenes that have InitTestScene prefix".
This could be wrapped into a super small, focused block (with some macros and maybe with some runtime checks in like 10 LOC) and wouldn't require yetanother brand-new "VerifySceneBeforeLoading" mini feature.

Just my 2c though, if you're happy with this direction, I'm fine with it too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the feature for removing the scene registration.
The RFC Explains what this is used for.
However, the cliff notes version is that this is a way for users to "secure" which scenes are loaded since there is no longer scene registration (which its original intention was to make sure you only allowed specific scenes to load).

I am using this in the unit test to exclude the loading of the unit test scene during the MultiInstance test for clients only.

Does this make sense? It is a feature that I decided to use in the unit test to handle not re-loading the unit test scene as opposed to checking for that in NetworkSceneManager.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! okay, I see. I didn't realize we actually care about "scene loading security" but sure, this is fine :)

SamuelBellomo added a commit that referenced this pull request Sep 2, 2021
@SamuelBellomo
Merge branch 'develop' into sam/feature/interpolation-for-network-tra…
669b878 
…nsform

* develop: (26 commits)
  fix: client connected InvokeOnClientConnectedCallback with scene management disabled (#1123)
  fix: removed `public` class `NetcodeObserver` (MTT-1157) (#1122)
  feat: add NetworkMessageSent/Received metrics (#1112)
  feat: snapshot. MTU sizing option for Snapshot. MTT-1087 (#1111)
  Add metrics for transport bytes sent and received (#1104)
  fix: Missing end profiling sample (#1118)
  chore: support standalone mode for netcode runtimetests (#1115)
  feat: Change MetricNames for a more complex value type (#1109)
  feat: Track scene event metrics (#1089)
  style: whitespace fixes (#1117)
  feat: replace scene registration with scenes in build list (#1080)
  fix: mtt-857 GitHub issue 915 (#1099)
  fix: NetworkSceneManager exception when DontDestroyOnLoad NetworkObjects are being synchronized (#1090)
  feat: NetworkTransform Custom Editor Inspector UI (#1101)
  refactor: remove TempGlobalObjectIdHashOverride (#1105)
  fix: MTT-1124 Counters are now reported in sync with other metrics (#1096)
  refactor: convert using var statements to using var declarations (#1100)
  chore: updated all of the namespaces to match the tools package change (#1095)
  refactor!: remove network variable settings, network behaviour cleanup (#1097)
  fix: mtt-1088 review. Safer handling of out-of-order or old messages (#1091)
  ...

# Conflicts:
#	com.unity.netcode.gameobjects/Prototyping/NetworkTransform.cs
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
@NoelStephensUnity @mattwalsh-unity
feat: replace scene registration with scenes in build list (Unity-Tec…
ea1edec 
…hnologies#1080)

* Squashed commit of the following:

commit 1e733823da0772d185f21bc11bd2d9c027cddab0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 19:54:59 2021 -0500

    test fix

    Make sure we deregister when unloading/scene transitioning but not when quitting.

commit 02f18928eb296437287c91fdfbce7352ce3268ab
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 19:48:51 2021 -0500

    refactor and fix

    Refactoring some of the test project scripts, fixing an issue in the editor where ScenesInBuild count could become 0 but not populated, slight geometry level tweaks to help prevent corner edge cases, and merging the prefab handler with the prefab pool to reduce code complexity.  (really need to merge the prefab pools together)
    Also some minor tweaks to the random movement when not the owner for temporary adjustment (this needs to become velocity based).

commit 1c4eb3013261b3ea3c79145dfc50d6fcb9bba3fe
Merge: 018ff78e bf5ddd4b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 18:11:39 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit bf5ddd4b057a5e6189ef749de757d138c8aba49b
Merge: 961ad0a9 b5afae7b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 18:10:01 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit b5afae7b1fa600eff56640d3a3445a1167e2828b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 17:57:48 2021 -0500

    refactor

    Removes returning bool to determine if NetworkPrefabHandler should destroy an object with Fatih's awesome fixes from PR-1068
    https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1068

commit cf4d249a86ef10921eb8afd386fce8241251a293
Merge: f80e853e 00a0e051
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 17:44:35 2021 -0500

    Merge remote-tracking branch 'origin/fix/bad-netobj-dest-fixes' into feat/MTT-820-AdditiveSceneLoading

commit f80e853efb297036d7feed5855aafab6c613b3cf
Merge: cf06cf02 0db6789a
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 23:00:01 2021 +0100

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 00a0e051165b96d6e19c5aa530a1d72811d9350b
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 22:58:56 2021 +0100

    remove obsolete comment

commit d2dc3212bf8c4321b2f76b38cc21456718859299
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 22:53:19 2021 +0100

    fix: eliminate bad use-after-free(destroy) pattern

commit cf06cf02b2ce89ff3311c12586ce8a14ea3850f1
Merge: 3f76dc18 8e9900b5
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 21:27:09 2021 +0100

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 3f76dc187744744a519e82174400efbf4e493b17
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:27:24 2021 -0500

    fix unit test

    Fixing the change in exception thrown when trying to call NetworkSceneManager.Load or NetworkSceneManager.Unload without having set NetworkConfig.EnableSceneManagement.

commit 6aaaa5499ef3e5662f612637fb733c1bcdcebdba
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:21:30 2021 -0500

    fix

    Fixing committed suggested change bug.

commit a1f5ae3c532cc94ef1ba628bb13d8cd1b403ce3f
Merge: 4f71b1c2 db097ee1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:15:59 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into feat/MTT-820-AdditiveSceneLoading

commit 4f71b1c2ec24c033ec909a130911b8ea750c95af
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 14:15:34 2021 -0500

    test fix

    Fixing an issue that can occur in a testproject helper script where the wrong scene could be applied to the wrong "toggler" when loaded.

commit db097ee10db1029ffd17dadac0bfa28f4de060d6
Author: Noel Stephens <noel.stephens@unity3d.com>
Date:   Wed Aug 18 13:57:35 2021 -0500

    Update

    Applying Fatih's super-nit.

    Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com>

commit 018ff78ecf9b59e9392df159a7cda0f0f89d3144
Merge: 709b2154 961ad0a9
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 13:00:41 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 961ad0a9ca77d4979d0f24541018131bf6a39065
Merge: 93051e3a 8acb31cc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 12:58:42 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 8acb31cc8f9d7ef45d168d14321d024345661f5f
Merge: 75817ed5 43d4494c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 12:55:58 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 75817ed5c1168596b4989436e7a338b605eceed8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 12:55:48 2021 -0500

    refactor and style

    Removing a check that is no longer needed.
    Improved an exception message.
    Improved some comments.
    Removed a CR

commit 39005dd31bc0f7ad98d423655e75509ea11096d8
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 14:06:54 2021 +0100

    `./standards.py --fix`

commit 27d8f50699718261856f87b874762bc217fdc171
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 14:00:47 2021 +0100

    minor editor UI polish

commit 709b215407405fc29eed202997f3866f0fcd2076
Merge: d7f1f67d a5f0a795
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 07:06:23 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 93051e3af782802bf9ac23f59d1a9d943103e969
Merge: 3a490018 a5f0a795
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 07:05:12 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit a5f0a795076155718b0fde587e38785207a505c1
Merge: cc83d1cc 19e6d3ca
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 18 07:02:37 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit cc83d1ccfb47082a0c385442ba9297b95022b3d3
Merge: 536a8e5c d30f6170
Author: M. Fatih MAR <mfatihmar@gmail.com>
Date:   Wed Aug 18 12:48:11 2021 +0100

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit d7f1f67dbbccd6a632179e2e8ad9ca5c902806b4
Merge: 610c2ec4 536a8e5c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:10:05 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 3a4900184e84e05fd800de8edf83f6989b25357d
Merge: e7813baf 536a8e5c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:09:48 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 536a8e5c4b19a69037f88f046434e789a8ebe135
Merge: ecc1083d e89f05db
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:09:23 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 610c2ec447c8d23e6018a274813642ec34dfca09
Merge: fe51176e ecc1083d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:07:00 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit e7813baf7709be9b005ece115dbe7aa0cc68ec59
Merge: b2d5a0f6 ecc1083d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:06:41 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit ecc1083d7ff00de3bcd565776eb11be708509e1b
Merge: 831c3a3b 85f84fbc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 18:05:50 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 831c3a3b2480a3391b4acff76b39d5805c46cc6a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 17:52:47 2021 -0500

    style

    Adding additional comment to further clarify usage of a multidimensional dictionary

commit 747f1f73711d2cd07bf172f6da2b7fd80cbe3180
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 17:49:43 2021 -0500

    refactor

    removing unused m_ObservedObjects.

commit fe51176ecc5a0257f666f9170e04a95b23212ce7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 16:05:40 2021 -0500

    fix

    This fixes the scenario where you open a scene in the editor that does not have a NetworkManager instance (i.e. MainMenu in testproject) and then while still in play mode navigate to a scene that does have a NetworkManager instance, then (editor only) the ScenesInBuild asset will be created (if one doesn't exist), refreshed/repopulated, and assigned to the NetworkManager instance.

commit 8bef1fc92e6e5af6f6c1b91db73f6dcc4accfd2f
Merge: a644105c 7f559f5a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 14:31:34 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit b2d5a0f60e9b46060a11ec931c6fa5800fb3658b
Merge: 19ba7ae5 7f559f5a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 14:31:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 7f559f5afa6cd0868fb602cd6e1f21261c61dc7e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 14:29:52 2021 -0500

    stle

    Renamed NotifyPlayerConnected to ApprovedPlayerSpawn

commit a644105c6d9e073d3b839bcb5c783a1864a3132c
Merge: 8afc9f3e 1b421007
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:19:15 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 19ba7ae5eaa47c4dbd16e7dea6162cf6ead43450
Merge: 715b73bc 1b421007
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:15:30 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 1b42100741c8a1aba6ef5d45b51a0359b50ccd71
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:14:52 2021 -0500

    fix

    Minor stats display issue with another sneaky resources meta file that somehow made it into a previous commit.

commit 670166b4da352ef054f0e9c44d93ac9722417add
Merge: 581adfa0 24cebfb2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 12:09:28 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 8afc9f3e2c44953f0d4c518ecdbb7309ab70cd53
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 11:56:20 2021 -0500

    fix

    Reverting tail end of MultiInstance test NetworkObject destruction to Destroy and not DestroyImmediate (some might be in the process of being destroyed which can cause an exception after unit test is done).

commit c3c482ac0511d28a85f99c9f43351f192181a330
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 11:48:45 2021 -0500

    refactor

    removing Resources.meta file that was accidently added in previous commit.

commit cb180d4e0505aeac876a35cb53fe54cd7807f504
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 17 11:43:35 2021 -0500

    fix

    Applying some fixes from the PR-955 merged changes.
    Adding some additional fixes that avoid loading scenes on the client side during multiInstance unit tests.

commit 581adfa0401b87c80969a62eb49fe6c21436a8cc
Author: Noel Stephens <noel.stephens@unity3d.com>
Date:   Tue Aug 17 08:41:47 2021 -0500

    Update com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

    Co-authored-by: Luke Stampfli <43687322+LukeStampfli@users.noreply.github.com>

commit 237dd02d4baf29a23570ce4fcb8d891296c37570
Merge: b7fa2386 715b73bc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 13:56:53 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 715b73bc933e71d65b68eb15dc04a5669c885012
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 13:36:44 2021 -0500

    refactor

    Refactoring unit test for most recent NetworkSeneManager updates.

commit 497670bc012550a01c185bee719c6b125bf4733c
Merge: d3b9a202 d1902c8c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 12:50:39 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit d1902c8c46fd2f6cdef0ef697af30b97a6c74fb0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 16 09:21:00 2021 -0500

    test

    updating test projects build settings scenes in build list with new scene to work with additive scene manual testing levels

commit 51198d547f980caaac12cf3692f5ee6c1d943cf4
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 20:41:30 2021 -0500

    style

    updated comments and added some xml doc see refs.

commit 1130fe1e804cc1cd3a18ea6c7c1430ca19d5f576
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 19:14:34 2021 -0500

    Test

    For real, this is my last fix test and then I will ask Tools team about the issues involved in trying to debug their tests locally.

commit 1618a13afaca2c6e00b3337f697855c03fa7fdae
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 18:31:13 2021 -0500

    fix test

    Last try of the day... just delete every NetworkObject that exists when we start a mutli-instance test.

commit 84c513a7732ed11e3a1219940362a4e89488e163
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 17:19:33 2021 -0500

    fix

    Removing my tools fix as that was the wrong place to fix that issues.  The error causing issue actually came before those two tests where something was being instantiated but never destroyed.  If this fails then I might need to do the same thing with the Setup side of things as well.

commit 2e1ce677f60b79ba018f29a654a2d372f340a4f7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 16:54:29 2021 -0500

    fix

    Fixing some tools unit test related issues.

commit 2485c89ca0d7a5b521c6015dad8ee1149aa99ae7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 16:19:10 2021 -0500

    fix and style

    removed the unused namespace from NetworkPrefabHandlerTests

commit 20874b406ba000e052c09ec5065482ef71a002a8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 16:16:11 2021 -0500

    fix

    Fixing minor issue with the standard NetworkPrefabPool (really need to merge these two classes) where it wasn't removing the registration from NetworkPrefabHandler when a scene was unloaded (only in the traditional SceneTransitioningTest without additive scene loading).

commit 7fd53e62462b86a5badb7f524d1f11835a6cbe8e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 15:25:15 2021 -0500

    Fix

    Lots of fixes with the new requirements.
    We will need to come up with a better way to instantiate NetworkObjects for unit tests, but this includes all of the fixes required to get all current unit tests working again.

commit 1c12d7c11d6e4f66588a441494777e23e81007be
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 15 14:02:08 2021 -0500

    refactor and feat

    This includes several updates:
    We now load all scenes first and then we synchronize all NetworkObjects after all scenes have loaded (during the client synchronization process).  This means users no longer have to register any form of dependency with NetworkObjects.

    This includes the additional modifications to support loading the same additive scene (within scene placed NetworkObjects) multiple times.  This did require a bit of refactoring and some improvements in how we organize our InScenePlacedObjects.

    The SceneTransitioningAdditive manual tests (SceneTransitioningBase1 is root scene) include demonstration of loading/unloading the same additive scene repeatedly.

commit b7fa2386f41602b161e1e6a7f2fe91f684a24b75
Merge: 8ba63115 0d074688
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 11:37:02 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit d3b9a20239d5cff6d4cf33cf0367810c5b8ccc1e
Merge: fdb9caa4 0d074688
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 11:36:02 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 0d07468841474fae1bc99b6fab4d7268b6dd8cdd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 11:35:44 2021 -0500

    style

    removing MLAPI from sceneIndex

commit 8ba63115f48d954601bc34210aa9770cc81ee377
Merge: 0af58abb 2a8ea862
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 09:26:27 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit fdb9caa4245e01fa841074909ca3482f1eb23197
Merge: b438aa31 2a8ea862
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 09:26:15 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 2a8ea86295bd13d56196855ff49baac3922d378c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 13 09:25:52 2021 -0500

    refactor

    Assigning the TargetClientId for NetworkVariable writing.
    This could change with the snapshot stuff and the up-and-coming change in read/write permissions, but for the time being making sure this is set only for S2C_Sync events.

commit 0af58abb20012b257b2993fad4c4128a72ba8c66
Merge: 9cdb5d66 36e89c25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:25:24 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit b438aa31d33f45f6111b37c69d5245e4e00e063f
Merge: 7e7c1735 36e89c25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:25:06 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 36e89c25228067ee87dd93a8d9e5ff821251baf8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:24:52 2021 -0500

    style

    Added or updated some comments for better clarity.

commit 9cdb5d6650093fd57904ab5f109cc3ab5764209f
Merge: a30592ab def25430
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:06:26 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 7e7c1735b0b67c3f9025636755f00f0944bc1206
Merge: bc9598b3 def25430
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:06:08 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit def254305d196105df8ce997a9aff1a007cc51e7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 17:05:46 2021 -0500

    style

    removing the TODO and my initials from MTT-860 comments and providing a bit more of an explanation

commit a30592ab1ae3edc8df7d0b7e761ceb4bb2c1bdc6
Merge: 44590cde e5a98164
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:55:24 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit bc9598b3d6ca69075de11fd1916423953fd381c5
Merge: 49a4d492 e5a98164
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:54:59 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit e5a9816443042c90b22ef39c42d613c0964975e9
Merge: 68789d99 5deae108
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:54:42 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 44590cde9d9e6fd44a54a69f676d4297191f39da
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 15:05:46 2021 -0500

    fix

    Manual Test Fix:
    AdditiveSceneToggleHandler needed to check for SceneFailedVerification status, otherwise it would fail to exit the coroutine but never finish its change in state.

commit a803802368e8d60ca2c0995a2a18bb6b7fddacfc
Merge: 1fc19dbe 68789d99
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 10:21:03 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 49a4d49234cc8a12484db7a6856f375c4726d16e
Merge: 4df10130 68789d99
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 10:16:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 68789d99042c8cb144510efa807c8aac451867e0
Merge: 3a7a0e4e 6b58eeb0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 12 10:07:12 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 1fc19dbeacbcd86c3ccd51ef7e2a946d0f04cbf3
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:26:01 2021 -0500

    update

    Forgot to move the number of clients back up to 9.

commit 0500c3ff7aa8174aed20e3f86f24e1bbd39faf38
Merge: 9a7208d6 3a7a0e4e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:03:26 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 4df10130abaed35af44890bc2fecf76aed40531d
Merge: 2a279af5 3a7a0e4e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:02:44 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 3a7a0e4ec6c9d470d45c442d43f84ea4372ba87a
Merge: f4778085 87f9ec96
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 17:02:25 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 9a7208d6c6327d213ae2edaa90d7b713c3b85cfb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 16:51:54 2021 -0500

    refactor fix and test

    Removed the client event notification as it wasn't needed.
    Fixed a minor bug in scene validation that was discovered via the unit test.
    Added another unit test to the NetworkSceneManagerTests that verifies the NetworkSceneManager scene validation process works and that users can control which scenes are loaded (test covers both client and server).
    Updated and added XML document comments for methods and properties.

commit 24b782d3898ac415912342c71c7f8b92e6cac4c9
Merge: 499a6073 f4778085
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 09:27:37 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 2a279af51c8ffd7b4fdd25db0cef0964f1849b2f
Merge: af243af5 f4778085
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 11 09:27:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit f4778085f474fdcd57966ad475fe3b8901f32dbb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 19:53:20 2021 -0500

    style

    added comment

commit d3ff2e4c64ad648b9eb8f45afe273567ff321fe3
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:57:27 2021 -0500

    fix

    Seconds vs frame count
    Mac failed.

commit 499a6073b71b3a34fdb37f893d70689570c663d2
Merge: af604487 1387b1fa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:20:34 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit af243af56ddc68dbfd26d5cefb320d1aa72c857b
Merge: 80e50fff 1387b1fa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:20:08 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 1387b1fa7f046cecaf20ead6c88480602a959095
Merge: d38145ba 589882c0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:19:45 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit af6044871e9f83328a3ddb867f646f56333d947c
Merge: f96bcd28 d38145ba
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:18:03 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 80e50fffb3ff940aa9701d2f6ea65b2fe5e2329e
Merge: bb941b6d d38145ba
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:17:22 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit d38145bae0ede16a081c63c912b2af0366346336
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 17:16:43 2021 -0500

    refactor

    Removing check for NetworkObject being null in NetworkBehaviourUpdater, this is no longer needed.

    Removing artifact debug output (testing purposes) that was missed.

commit f96bcd28fb63279a96d5a13857dec7c1229c18bb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 16:18:08 2021 -0500

    feat and style

    Added a client side notification for scene verification failure.
    Added some xml documentation in pertinent places.

commit 60fd08318d7245497a5b8d04f5c1a88582a98c76
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 15:05:09 2021 -0500

    style

    One last namespace not being used.

commit 99e42f91bb6abc1da95cfe9d16f06c6bd704250c
Merge: 1404ca2f 9f1e05fd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:47:26 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit bb941b6deb3bb28912bfdf42e51a19ed63e059fb
Merge: cca47688 9f1e05fd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:47:06 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 9f1e05fde6b477df6b2919140921d9b05739e22e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:46:53 2021 -0500

    refactor

    Removing the target frame rate check in the SetUp.

commit 1404ca2f0eb447527f14d2c6652dca6752177a9d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:41:49 2021 -0500

    style

    Removed unused namespaces for compliance/standards purposes.

commit bed3c30a73e880a27de729c1bdd1fd9d2fe89fb8
Merge: 6559ec97 b9be4739
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:10:14 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit cca476882e569faafd9d6691640fc7f1a2f102a4
Merge: 33b1bd8a b9be4739
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:08:15 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit b9be47391f9068d770abf7f159df38fe46beb493
Merge: 925e02e0 01ad0c21
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:07:46 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit 6559ec97153e8fadf8a9fda001cf94f883428cd8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 14:05:35 2021 -0500

    refactor

    Updated to most recent PR-955 and develop namespace changes.

commit 99b6e2b30b94ed2e684914e556caba37a6cfaa8f
Merge: 9d8c0b79 33b1bd8a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 12:15:44 2021 -0500

    Merge branch 'test/AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit 33b1bd8a6c99654c868a03f9cdb4688c1e9a3700
Merge: 93a31da3 925e02e0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 11:20:13 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 925e02e0ac388afc6cc9b2a413027f8fa104aec8
Merge: 79fd5b25 dce2e54d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 10 11:11:56 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 93a31da3abbfd4c75b0ddc7d44172accc597de26
Merge: 34a6db48 79fd5b25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 17:09:10 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 79fd5b2519b003c7c2126c2984ef75a5f1e48cc0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 17:08:36 2021 -0500

    refactor

    reverting timeouts to 5 seconds each.

commit 34a6db48cd8a5fd78be866a86fdf253197f7b3d5
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 17:07:07 2021 -0500

    refactor

    Removing the target frame rate, reducing the wait times

commit 77f15b54a36fe5e5c1379d1b8b4a58a737a717b6
Merge: 2e7f9b40 0db23c32
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 15:51:30 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 0db23c324ef43d5044555f38b85557258abc7e64
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 15:37:40 2021 -0500

    fix

    Message ordering seemed to have issues with application target frame rate.
    Checking this and setting it prior to running a test seems to fix the issue with failing on the FixedUpdate side of things.

commit 84b4d04d85864d9b4dc9a0d29414b9121f337cfb
Merge: 6b9b4c05 40a6aec0
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 15:09:57 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 2e7f9b4096a1846182fbfd92563a050508e3f76e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:46:28 2021 -0500

    fix

    Aligning the exception messages for client trying to start Load or Unload scene events.

commit b12c168eae6991bba8eb616b4839b642cb1efe3f
Merge: b08f5b57 6b9b4c05
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:38:11 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit 6b9b4c05a74362a4976806d3ff409a02008bc4bd
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:36:42 2021 -0500

    fix and style

    replacing exception message reference to scene switch with scene event.
    Fixing check for scene not being loaded check in UnloadScene.

commit b08f5b5722d2219527d7d4195d412ecac8a31c83
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 9 13:33:31 2021 -0500

    test

    Added the following checks:
    Loading during an existing scene event in progress returns SceneEventProgressStatus.SceneEventInProgress.
    Client trying to start a Load scene event throws an exception
    Client trying to start an Unload scene event throws an exception
    Unloading a scene that is not loaded returns SceneEventProgressStatus.SceneNotLoaded.
    Loading a scene that does not exist returns SceneEventProgressStatus.InvalidSceneName.

commit a0f6b39e09846c013fa6d218fe537ac44c377725
Merge: 1fe70247 bac7f416
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Aug 7 09:42:02 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit bac7f416ae29624277984c6d2d1eee07bf4afb77
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Aug 7 09:41:24 2021 -0500

    style and refactor

    Minor clean up on some comments.
    Minor refactoring of property and method accessibility.

commit 1fe70247b384fefb36a7488a3f9f7966528161aa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sat Aug 7 09:22:03 2021 -0500

    style

    updated comment

commit 82d356c485e76b51a70010db921d6d168a448978
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:43:01 2021 -0500

    refactor

    Removing the no longer used SceneLoadingTest

commit 34ec78646a2e50327dd28ed761405336c2215d4c
Merge: 06e96f2d adc58d89
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:41:25 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into test/AdditiveSceneLoading

commit adc58d8944458b0ffdd60439f9d115570474aebb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:11:08 2021 -0500

    refactor

    Removed debug information from SceneEventData.

commit 06e96f2d1ebef652c5b5b575cd075548e37db7df
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 18:05:59 2021 -0500

    refactor

    Moved code from legacy NetworkSceneManagerTest for assert when trying to load a scene with EnableSceneManagement set to false into the new NetworkSceneManagerTest.
    Removed the legacy NetworkSceneManagerTests script.

commit f1c0b21096468587002162573269b56d363a0995
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 17:45:42 2021 -0500

    test

    This is a multi-instance unit test with 1 host and 9 clients.  This tests the entire scene event notification sequence for loading and unloading additive scenes.
    This includes some changes to the new NetworkSceneManager required to do multi-instance unit tests.

commit c1d299aac76811154880826b2d366e5b7c483d15
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 15:39:29 2021 -0500

    refactor

    Added the ability to disable the re-synchronization for future snapshot development purposes.

commit 98354515fe7f0ff83fc9eb70afe757ce99cd0f66
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Aug 6 08:21:03 2021 -0500

    refactor

    Removing two exceptions that will not be needed.

commit cfa48e63e63298dfef8aeb7a5139ec471536c35f
Merge: 831fd1da d89e2f2f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 19:55:02 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 831fd1da8a9d88cc082abd2ef11ef5de598c4032
Merge: 37be5bc4 8919c1ed
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 15:35:46 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 37be5bc455300f633a3fd622e30cded02fa0e8d2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 15:35:31 2021 -0500

    style

    Did one last XML Documentation pass.

commit fa2aaaa9396d03421df81423d8297f513febab1f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 14:29:21 2021 -0500

    feat

    Finalized replacing all notification related events with scene events.
    SceneEvent now includes two additional types:
    S2C_LoadComplete: Server to client(s) all clients loaded scene
    S2C_UnLoadComplete: Server to client(s) all clients unloaded scene
    These replace the event notifications that specified all clients have loaded a specific scene, with the additional functionality that this notification is sent for both loading and unloading for all loading modes.

    Removed the legacy internal messages and related methods for all clients done loading a scene.

    This should mark the final overhaul for notifications

commit 139edff30404111537efddf47426a36b591e6dfa
Merge: 06e8a58a 1da76b29
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Aug 5 10:16:31 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 06e8a58a70441c8548cd40b7f57381dad62c767c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 23:57:43 2021 -0500

    feat

    SwitchSceneProgress changed to SceneEventProgress and is no longer a returned value when starting a scene event (load or unload).  This is still used internally to track when all clients have loaded the scene in question, but that is primarily used for SceneLoadingMode.Single.

    Removed the coroutine callback from NetworkManager and placed it within the SceneEventProgress class.

commit a608797972a5f5c09221610b53af9e84b5f940d8
Merge: 8495d1f8 d71dd1b8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 22:50:53 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 8495d1f85538fff40895fdd6e478c89fb7a2dd61
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 20:03:08 2021 -0500

    fix, refactor, and style

    re-fixing an issue with sending spawn calls to every client (n) times based on the number of clients connected (until it is re-fixed by the offender)

    Started the removal of certain NetworkSceneManager event notifications that are no longer required due to the more recent SceneEvent notifications.

    Removed the set active scene scene event for MS-1 (just not enough time to implement and be sure that it works perfectly)

    Removed a manual test for SceneManager callbacks that won't be used any longer.

    Updated XML documentation in various areas.

commit af56bdd2c4eb348cd19a8a1c04ce65a40bfcf0ad
Merge: 6d4d52fa f881d338
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 18:46:54 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 6d4d52fac651e6c1b4824f7d427e514c131d1d37
Merge: 277292e6 95886c59
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 18:28:55 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 277292e690dc8750e54d8be4f7a4faafc82ba6fa
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 18:08:13 2021 -0500

    feat

    Improved notifications and detection of notifications for manual verification that they are triggering properly.
    Added a SceneEventNotificationQueue test project script that is to be used with the NetworkManager to detect edge case notifications (i.e. in the middle of a scene transition).
    Fixed an edge case scenario with NetworkObject.Despawn that could occur during exiting the application and the SpawnManager no longer exists.

commit 978e8de133dd39692bead7ca23f24b9370e3aaf1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 16:14:41 2021 -0500

    style

    slightly increased the player prefab size

commit c30251b1579182171a25e70051bbc54c2c36d367
Merge: 5cffe56f 5b9f953b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 16:07:47 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 5cffe56f7873507b9674d78bc3c05a55b81b32cb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 16:06:20 2021 -0500

    feat

    Implemented the full scene event notification system that provides detailed information for both client(s) and server.  Made some modifications to the StatsDisplay that provides visual queues for when each scene event occurs.

commit 69a4751a1590dfe6f5c4d98c2f5f7a7a94153d18
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:56:22 2021 -0500

    refactor

    Updates to account for the namespace change...again.

commit 6a41cb8ce49f86099bc8fb49bd09ab7ccd333c61
Merge: c31c119c 838c6e5b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:51:28 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit c31c119c4e18f1dbdc6f9828648600bfc0011dc7
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:33:06 2021 -0500

    refactor

    Removing completely irrelevant code...

commit 3f98c0ab0a32c7e27d128babcfefa9cb9c64f218
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Aug 4 12:23:49 2021 -0500

    refactor and style

    Refactored the prefab pool examples for the changed  INetworkPrefabInstanceHandler interface.
    Made some adjustments to the code based on suggestions.
    In particular added a prefix to the SceneEventData.SceneEventTypes to help identify which is server to client and client to server.

commit ea747d3b887a621fde343725d4a61cb7e5deac7d
Merge: 5c4de91f f5c51f25
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 20:54:17 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 5c4de91ff5878b18a941dc2b500e3802f95d0f90
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 17:21:25 2021 -0500

    style

    Fixing non-required using statements.

commit 3274c561ebfbb12e22c58de4bd7c426d073a6603
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 17:08:13 2021 -0500

    refactor and fix

    Refactoring the Stats Display a bit.
    Added check for NetworkBehaviour Updater to not try to access the NetworkObject if it is null.  This can happen under scenarios where too many objects are being spawned and destroyed at the same time.

commit fd90a507320960aadcd094168ccd5c9502d67cc7
Merge: d7822d6c f8a7ef01
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 16:22:50 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit d7822d6cd7d874c029abe07da0f329ffaf77f8a6
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 16:20:50 2021 -0500

    fix

    merge fix.

commit d708f5e9a858ce84b1077b8f63340983b107e041
Merge: 22112987 6b78f322
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 16:14:21 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 221129870538e7987348e00052de0268ec19e960
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 15:52:32 2021 -0500

    refactor

    Updating additive pooling with additive scene unloading.
    Added the ability to specify whether  NetworkObjects should be destroyed on scene unload or not.  If the SpawnInSourceScene is set to true and the DestroyOnUnload is not set, then the already spawned NetworkObjects are moved to the currently active scene to allow them to persist until they naturally are destroyed.

    Fixed issues with most objects already destroyed messages.  Still have a few that pop up from time to time.

    Fixed issue with client not sending responses back to server.

    Refactored NetworkPrefabHandler and INetworkPrefabInstanceHandler so that the destroy method returns a bool value which determines if the NetworkObject should actually be destroyed or not (there are edge case scenarios this fixes).  Updated several tests to reflect these changes.

commit 77e9e07e9014e8a3816bd9d8d0e37d06c78b35b6
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 10:12:38 2021 -0500

    fix

    temporary fix for scene loading test.

commit c9fb565ce54e2fff3b9d9772c249e1bd1bf102a1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Aug 3 09:19:42 2021 -0500

    fix

    Standards check for no longer needed using statments

commit 49a0b3d3528792bf9a2e904f49d1bba1ac9ae0d8
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 2 22:12:07 2021 -0500

    fix

    This includes fixes for the namespace changes.

commit 4aa60b2fc8b6c12f285e5d29c9e247036f938ebc
Merge: ccd659e3 c8eb5fca
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 2 22:04:05 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit ccd659e3363f4d40e39adeaa0530ffcdb3046a4c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Aug 2 11:36:47 2021 -0500

    fix

    Checking for NetworkManager to exist before disabling.

commit c67dc73de9ac0dbf425ff1b94331fbd4708f08b4
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 1 20:26:00 2021 -0500

    refactor

    Work in progress for local notifications, how network prefab handler pools destroy objects, and how NetworkObjects marked for or not marked for do not destroy on load are handled.

commit c0da88954bc06e3b9455958061ba134787789d2f
Merge: f092e45a cbe74c2e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Aug 1 19:06:59 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit f092e45a056851d2a459b69c01031469368020a2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 29 17:54:37 2021 -0500

    refactor

    Cleaning up merge from develop.
    Starting to work on the local notification side of things.

commit 67057603f230748166aed262a9f928ddf5009cc2
Merge: d369c1c8 d6b2a486
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 29 14:33:25 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit d369c1c80baba35dd7dee11a5a1078e44db08a91
Merge: 26e94bb2 4b900723
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 29 14:08:13 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 26e94bb23918b0c39eb6cf2ab7343024fb65ab7f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 28 11:39:43 2021 -0500

    test

    Forgot to remove the applied frame rate.

commit 3bb2dc6ff5caf3cc5862a35aae16dfff6012d206
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 28 11:34:25 2021 -0500

    test

    Updating this adjustment to see if this makes it through the mac tests.

commit 44365744aae26d95057df01d9db9c43ccfdb85ff
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 19:00:06 2021 -0500

    refactor

    Removing temporary fix for issue with NetworkBuffer.
    Adding a test to the NetworkTransformTests to see if frame rate has anything to do with the seemingly random failures only on MAC.

commit b2157b97fcd723d246a44581417802738cdefd6e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 18:17:27 2021 -0500

    refactor

    Reverted minor modifications to transform test.

commit 0aacdfe8ae871ad60788901a8c8c6d514e2e9483
Merge: 039ca2c8 c25821d2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 18:14:36 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 039ca2c84cf6ff55cacb5f84a04076153066930f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:53:00 2021 -0500

    refactor

    Increasing timeout for one at a time.

commit 28eb59ed6c0898db2ce05bb44c6476031f7ea147
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:25:36 2021 -0500

    refactor

    removed and re-added scenes in build list

commit b65203e04b9d36b04dbb7ae826636150e40de82b
Merge: 217748a1 82e1c33e
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:24:54 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 217748a1b78281798d2fda6f04609f46dbfd802d
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 16:10:53 2021 -0500

    fix

    Removing some adjustments I did not intend on checking in.

commit 28545c3e7aaa6fbe19aea5701455cdecc4e8ae75
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 27 08:07:12 2021 -0500

    refactor and fix

    Refactoring things based on more recent changes.
    Predominantly the Message Ordering changes and the time synchronization.

commit 7b5fb895c4d74dc6c0d1c820c4dd30f8417f3ee2
Merge: a1fdf5bb b9ffc1f1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Fri Jul 23 18:26:57 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 9d8c0b7992dd0227e526584259dbf55db56f0c97
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 22 15:58:34 2021 -0500

    style

    this comment was left out of last commit.

commit 510226d12f1bb06e27a71587f4c7f57904e1b9b9
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 22 15:57:33 2021 -0500

    feat and refactor

    Added ValidateSceneBeforeLoading delegate and method to provide users with a way to validate a scene before it is loaded for security and/or validation purposes.

    Removed AllowRuntimeSceneChanges

    Updated some comments

commit 444263ebca3ba51bebe0a1f2006e4b273c60baeb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 18:49:23 2021 -0500

    fix

    There were two issues:
    Assets outside of the primary project domain, which I had to put some checks to prevent from populating under specific scenarios (i.e. first time loading test project with no ScenesInBuildList asset).  Then with testing I had to bypass these checks so dynamically created NetworkManagers would be assigned the ScenesInBuildList asset automatically.
    This should fix the later issue and fix previous yamato failed builds.

commit 8ccc6d343f51afb44b571aff2c0b9c2e3ceb2654
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 16:30:08 2021 -0500

    Fix

    Found a potential issue with having references in a different assembly and/or first time loading the testproject.

commit 29c5360fe29651047a936532f56728fe563d9386
Merge: d8eb7e55 a1fdf5bb
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 16:01:42 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit a1fdf5bb4df736192a9e0e31c9cc684285f6543b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 15:59:09 2021 -0500

    FIx and Style

    Fix for client side where during resync the GameObject was being destroyed but the spawn manager's lists tracking spawned NetworkObjects was not being updated.  The symptom was when a NetworkObjectId was recycled for a new NetoworkObject the client would still have that NetworkObjectId registered.

    This also includes some style updates.

commit d8eb7e55f06b396eee9f7940d01b2e7c6dcb0ad3
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 15:51:52 2021 -0500

    Fix

    Removing re-syncd NetworkObject from spawn manager, this was causing delayed NetworkObjectId assignment issues on the client side.

    Also, added check to not populate the scenes in build when transitioning into or out of play mode.

commit 39313ebd3c3d10f70841afcdc8e961143a2092de
Merge: 707c3273 c890f06c
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 14:38:43 2021 -0500

    Merge branch 'feat/MTT-820-AdditiveSceneLoading' into feat/ScenesInBuildMLAPISceneRegistration

commit c890f06ce8cc266b9eb742391ef4bb3045a95c32
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 21 14:38:01 2021 -0500

    Refactor and Fix

    Fixed issue with rogue dynamically spawned NetowrkObjects that were spawned during a client scene synchronization sequence where it required a Custom NetworkPrefab hanler to spawn properly but the scene containing that custom network prefab handler had yet to be loaded so it was never associated with the pool.

    Migrated the additive scene loading scene transitioning tests into the manual tests region of TestProject

commit 707c32738a0f0e088d7d7a7e86874f45b60370d9
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 17:45:50 2021 -0500

    feat

    This creates a ScenesInBuild asset if one does not exist as well as populates it with the names of the scenes in the build to keep the same types of checks done within the NetworkSceneManager (i.e. does the scene index exist etc).
    The ScenesInBuild asset can detect if it is moved around, however it is created in the root assets folder initially.  It also updates itself to the scenes in build list via the serialization process.
    All NetworkManager instances reference this asset.  In turn, the NetworkSceneManager access the ScenesInBuild.Scenes list now.
    Adjusted all unit tests and helpers for this update as well (except multiprocessor).
    TestRunner passes all tests in editor and play modes.

commit e798cc27ee9227c39d5e231c2c2cfdd81d2708ac
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 12:29:15 2021 -0500

    WIP

    Work in progress

commit 28d9df4c1a0818ce1d7e6529780024c1ed604c6c
Merge: 55ffbd3b fa2be6f1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 08:59:06 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit 55ffbd3b48cccba178e2a72e1a3d9f3bbf21a188
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Tue Jul 20 08:58:41 2021 -0500

    style

    comments and naming

commit 9ac6a86ed982de93044347c116e45db94f7ebc58
Merge: e16628cf bdd7d714
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 15 17:21:03 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit e16628cf7886f1810d0d2e887b49cb05bfd25846
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Thu Jul 15 17:18:20 2021 -0500

    refactor and feat

    Did some minor refactoring to make Load and Unload the only two methods that need to be called.  Removed the switch event related enum types since they are no longer used.

    Added a re-synchronization step to handle edge case scenarios where a late joining client might miss destroy messages during the initial synchronization process.  This includes adding an additional DependentSceneName property to NetworkObject.  This lets the NetworkSceneManager know that a scene other than the NetworkObject's current scene is dependent upon this NetworkObject and to not instantiate it until that dependent scene is loaded.

    Removed a bunch of user-side code (i.e. test project) from GenericNetworkObject that was required to handle the above edge case scenarios regarding scene dependencies.  Adjusted the NetworkPrefabPool and NetworkPrefabPoolAdditive to account for this addition, and removed a chunk of user-side code that would be required to handle this scenario.

    Refactored SceneEventData to not implement INetworkSerializable which removes additional allocation for the NetworkSerializer during read and write operations.  Also adjusted the constructor to accept a NetworkManager instance to make it multi-instance compatible.

    Set the SceneTransitioningBase1 NetworkManager config to not recycle NetworkObjectIds due to an issue in how they are recycled.  (topic for discussion)

commit c686eee1e9bc207d4f5b251406a59da34cb16b2f
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 14 16:41:19 2021 -0500

    fix

    Removing Scene Loading Test:
    This test needs to be completely refactored and no longer is valid.
    WIP

commit 4bcd93154defca41b6f7d77900aa47957b3a8b61
Merge: d1670b79 13e2b7f1
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 14 15:57:48 2021 -0500

    Merge remote-tracking branch 'origin/develop' into feat/MTT-820-AdditiveSceneLoading

commit d1670b79f9bb4b27c561d84452369ff96a9445cc
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Wed Jul 14 15:45:20 2021 -0500

    refactor and fix

    Minor test project fixes and additional tests for the AdditiveSceneToggleHandler to test back to back scene loading during a scene transition.
    Removed the distinguishing difference between switchscene and loadscene, left the switchscene as a wrapper around loadscene.
    Updated existing profiling code base to remove legacy scene manager profiler checks.

commit 3a7a0e9ccd1de3d74f1616a042dc6533000adade
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 17:02:02 2021 -0500

    style

    PascalCased my enums and added event in front to avoid any NDA complications for the time being.

commit d7846f82def8d9bfe2d1757fdd025569fbc6d017
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 16:33:06 2021 -0500

    fix

    Adding missing scene assets for the multiprocess test.
    Making sure the SceneLoading test destroys the network manager instance.

commit d8828190dd12983d0282bda55d7b7d5bdc158db9
Merge: a5c3bf84 089c2065
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 15:42:50 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit a5c3bf845c4be027869c870361a9b03b672f7c91
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 15:41:11 2021 -0500

    fix

    Two issues were discovered while getting the parenting test working:
    1.) t was doing a move objects to scene during the client side synchronization process (which doesn't need to happen) and as such was setting all parents to null which was throwing an exception.
    2.) The server side wasn't filtering out any pre-loaded scenes during the synchronization process.

commit 35a46b746ce85aea925148717ec2681eb6283ed6
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 13:15:59 2021 -0500

    fix

    Fixing other unit test issues.
    Removing the temporary block for clients to receive messages (it was an artifact from testing).
    Still have a few tests that are failing.

commit 729a2ce09aef653fdc5371f9437333b796d62a72
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 12:02:53 2021 -0500

    fix

    Fixes the basic scene transitioning test failure.

commit ef7736903aad357db46ec7133f148e16754f04a4
Merge: 5d10e276 833f1faf
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 09:55:26 2021 -0500

    Merge branch 'develop' into feat/MTT-820-AdditiveSceneLoading

commit 5d10e276e8e6ef54e87876d6df9494d09c968fa2
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Mon Jul 12 09:21:19 2021 -0500

    refactor

    Minor checks for an object still being around during clean up.

commit df9bc79286977e56c04890d80bf0c8bec913e72b
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:   Sun Jul 11 21:24:49 2021 -0500

    feat and refactor

    Some temporary fixes for message ordering and buffering during late-join until this gets merged with the message ordering updates and we add the ability to buffer messages while a player is late-joining. Primarily in the GenericNetworkObjectBehaviour class.

    Added a proposed solution to handle order of operations if user decides to allow all NetworkObjects from a prefab pool to be spawned in the active scene.  This requires the ability to separate NetworkObjects (server side) by associated scene so that they will be synchronized properly with their spawn generator's pool.

    Now tracking which additive scenes have been loaded to be assured they are unloaded when doing a full scene switch (i.e. singlemode loading), otherwise there can be issues that arise with currently loaded additive scenes.

commit 88617d2e56586e63917936fc8216ce45e1862f8a
Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com>
Date:…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFA11 0xFA11 0xFA11 left review comments

@ShadauxCat ShadauxCat ShadauxCat approved these changes

@mattwalsh-unity mattwalsh-unity mattwalsh-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoelStephensUnity @ShadauxCat @0xFA11 @mattwalsh-unity