Unity-Technologies · LukeStampfli · Aug 19, 2021 · Aug 2, 2021 · Aug 3, 2021 · Aug 3, 2021
@@ -4,6 +4,7 @@
 using System.Linq;
 using UnityEngine;
 using Unity.Profiling;
+using UnityEngine.SceneManagement;
 using Debug = UnityEngine.Debug;
 
 namespace Unity.Netcode
@@ -839,10 +840,33 @@ private void OnEnable()
             }
         }
 
+        private void Awake()
+        {
+            UnityEngine.SceneManagement.SceneManager.sceneUnloaded += OnSceneUnloaded;
+        }
+
+        // Ensures that the NetworkManager is cleaned up before OnDestroy is run on NetworkObjects and NetworkBehaviours when unloading a scene with a NetworkManager
+        private void OnSceneUnloaded(Scene scene)
+        {
+            if (scene == gameObject.scene)
+            {
+                OnDestroy();
+            }
+        }
+
+        // Ensures that the NetworkManager is cleaned up before OnDestroy is run on NetworkObjects and NetworkBehaviours when quitting the application.
+        private void OnApplicationQuit()
+        {
+            OnDestroy();
+        }
+
+        // Note that this gets also called manually by OnSceneUnloaded and OnApplicationQuit
         private void OnDestroy()
         {
             Shutdown();
 
+            UnityEngine.SceneManagement.SceneManager.sceneUnloaded -= OnSceneUnloaded;
+
             if (Singleton == this)
             {
                 Singleton = null;

@@ -392,20 +392,8 @@ public static void NetworkHide(List<NetworkObject> networkObjects, ulong clientI
             }
         }
 
-        private bool m_ApplicationQuitting = false;
-
-        private void OnApplicationQuit()
-        {
-            m_ApplicationQuitting = true;
-        }
-
         private void OnDestroy()
         {
-            if (m_ApplicationQuitting)
-            {
-                return;
-            }
-
             if (NetworkManager != null && NetworkManager.IsListening && NetworkManager.IsServer == false && IsSpawned)
             {
                 throw new NotServerException($"Destroy a spawned {nameof(NetworkObject)} on a non-host client is not valid. Call {nameof(Destroy)} or {nameof(Despawn)} on the server/host instead.");

@@ -65,7 +65,7 @@ private static void LogServer(string message, LogType logType)
                     {
                         var bufferSizeCapture = new CommandContextSizeCapture(nonNullContext);
                         bufferSizeCapture.StartMeasureSegment();
-                        nonNullContext.NetworkWriter.WriteByte((byte) logType);
+                        nonNullContext.NetworkWriter.WriteByte((byte)logType);
                         nonNullContext.NetworkWriter.WriteStringPacked(message);
                         var size = bufferSizeCapture.StopMeasureSegment();
 

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 
 namespace Unity.Netcode
 {

@@ -1,4 +1,4 @@
-#if MULTIPLAYER_TOOLS
+#if MULTIPLAYER_TOOLS
 using System;
 using System.Collections;
 using System.Linq;

@@ -1,4 +1,4 @@
-#if MULTIPLAYER_TOOLS
+#if MULTIPLAYER_TOOLS
 using System;
 using System.Collections;
 using UnityEngine;

@@ -1,4 +1,4 @@
-#if MULTIPLAYER_TOOLS
+#if MULTIPLAYER_TOOLS
 using System;
 
 namespace Unity.Netcode.RuntimeTests.Metrics.Utlity

@@ -1,4 +1,4 @@
-using System;
+using System;
 
 namespace Unity.Netcode.RuntimeTests.Metrics.Utlity
 {

@@ -1,4 +1,4 @@
-using System.Collections;
+using System.Collections;
 using Unity.Netcode;
 using Unity.Netcode.RuntimeTests;
 using NUnit.Framework;