fix: NetworkAnimator does not allow disabling or enabling parameters for synch (#3586)

* update

Provide users with a way to disable updating changes to specific parameters.

* update

Don't include excluded parameters during initial synchronization.

* update

Adding the ability to select server or owner authority mode via the inspector view.

* update - wip

Work in progress.

* update

Test project manual tests for animation (of which some are used for integration testing).

* update

Finalizing editor inspector view UI for excluding animator properties.
Added some additional logic to NetworkAnimator.
Added first test that verifies excluding parameters works.

* update

Renamed the new method `ToggleParameterSync` to `EnableParameterSynchronization`. Added  overridden version of `EnableParameterSynchronization` that accepts a string for the name and changed the original method to accept the hash value of the parameter name.

Did some minor clean up in the `NetworkAnimatorStateChangeHandler.NetworkUpdate` method.

Added some additional comments in various places.

* update

Reverted the change in HiddenScriptEditor.
Moved away from a NetworkAnimator custom editor to a custom property drawer to handle displaying the Animator parameters to be synchronized.
Handling the population of parameters and populating the NetworkAnimator.AnimatorParameterEntries during OnValidate.
Had to re-apply unchecking the excluded parameter in some prefabs for testing purposes.

* update

Renaming NetworkAnimatorParameterEntryEditor to  NetworkAnimatorParameterEntryDrawer since it is a property drawer.

Excluding NetworkAnimatorParameterEntryDrawer when the animation package is not installed.

* update

Converting all legacy ClientRpc and ServerRpc usages over to the newer universal RPC format.
Using a pre-allocated Persistent RpcTargetGroup as opposed to the List.
When using `NetworkAnimator.SetTrigger` with a client-server network topology and it is the server or host invoking the method, then go ahead and set the trigger since it no longer sends itself an RPC/no longer invokes the InternalSetTrigger via RPC.

* update

Adding change log entries.

* style

adjusting typo

* update

Implementing suggested changes.

* fix

Fixing issue discovered by Noellie in the HasAuthority check.

* update

fixing change log

* update

Always assure owner authoritative mode when in distributed authority mode.

* doc update

Updating the NetworkAnimator documentation for this fix.

* style - PVP

PVP-124-2
Removing trailing spaces

Author: NoelStephensUnity

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -13,10 +13,12 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - It is now possible to control which port clients will bind to using the `UnityTransport.ConnectionData.ClientBindPort` field. If not set, clients will bind to an ephemeral port (same as before this change). (#3764)
 - Added a flag to override command-line arguments (port and ip) in `SetConnectionData`. (#3760)
 - Added a command-line singleton to parse environment command-line arguments. (#3760)
-
+- Added `NetworkAnimator.AuthorityMode` which allows you to select whether the `NetworkAnimator` will use a server or owner authority model for state updates (like `NetworkTransform`). (#3586)
+- Added the ability to select which `Animator` parameters the authority `NetworkAnimator` instance should synchronize. This can be done via the inspector view interface or during runtime via `NetworkAnimator.EnableParameterSynchronization`. (#3586)
 
 ### Changed
 
+- Changed NetworkAnimator to use the `RpcAttribute` along with the appropriate `SendTo` parameter. (#3586)
 - Improve performance of `NetworkTransformState`. (#3770)
 
 
@@ -32,6 +34,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 - Fixed issue where invoking an RPC, on another `NetworkBehaviour` associated with the same `NetworkObject` that is ordered before the `NetworkBehaviour` invoking the RPC, during `OnNetworkSpawn` could throw an exception if scene management is disabled. (#3782)
 - Fixed issue where the `Axis to Synchronize` toggles didn't work with multi object editing in `NetworkTransform`. (#3781)
 - Fixed issue where using the dedicated server package would override all attempts to change the port by code. (#3760)
+- Fixed issue with authority animator instance sending itself RPCs. (#3586)
 
 ### Security
 

com.unity.netcode.gameobjects/Documentation~/components/helper/networkanimator.md

@@ -0,0 +1,96 @@
+
+#if COM_UNITY_MODULES_ANIMATION
+using Unity.Netcode.Components;
+using UnityEditor;
+using UnityEngine;
+
+namespace Unity.Netcode.Editor
+{
+    [CustomPropertyDrawer(typeof(NetworkAnimator.AnimatorParametersListContainer))]
+    internal class NetworkAnimatorParameterEntryDrawer : PropertyDrawer
+    {
+        // Draw the property inside the given rect
+        public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
+        {
+            EditorGUI.BeginProperty(position, label, property);
+
+            // Draw the foldout for the list
+            SerializedProperty items = property.FindPropertyRelative(nameof(NetworkAnimator.AnimatorParameterEntries.ParameterEntries));
+            position.height = EditorGUIUtility.singleLineHeight;
+            property.isExpanded = EditorGUI.Foldout(position, property.isExpanded, label);
+
+            if (property.isExpanded)
+            {
+                // Set the indention level down
+                EditorGUI.indentLevel++;
+                for (int i = 0; i < items.arraySize; i++)
+                {
+                    position.y += EditorGUIUtility.singleLineHeight + 2;
+                    SerializedProperty element = items.GetArrayElementAtIndex(i);
+                    var nameField = element.FindPropertyRelative(nameof(NetworkAnimator.AnimatorParameterEntry.name));
+                    // Draw the foldout for the item
+                    element.isExpanded = EditorGUI.Foldout(position, element.isExpanded, nameField.stringValue);
+                    if (!element.isExpanded)
+                    {
+                        continue;
+                    }
+                    // Draw the contents of the item
+                    position.y += EditorGUIUtility.singleLineHeight + 2;
+                    // Set the indention level down
+                    EditorGUI.indentLevel++;
+                    // Calculate rects
+                    var nameHashRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);
+                    position.y += EditorGUIUtility.singleLineHeight + 2;
+                    var paramRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);
+                    position.y += EditorGUIUtility.singleLineHeight + 2;
+                    var syncRect = new Rect(position.x, position.y, position.width, EditorGUIUtility.singleLineHeight);
+
+                    // Get the three properties we want to visualize in the inspector view
+                    var synchronizeField = element.FindPropertyRelative(nameof(NetworkAnimator.AnimatorParameterEntry.Synchronize));
+                    var nameHashField = element.FindPropertyRelative(nameof(NetworkAnimator.AnimatorParameterEntry.NameHash));
+                    var parameterTypeField = element.FindPropertyRelative(nameof(NetworkAnimator.AnimatorParameterEntry.ParameterType));
+
+                    // Draw the read only fields
+                    GUI.enabled = false;
+                    EditorGUI.PropertyField(nameHashRect, nameHashField);
+                    EditorGUI.PropertyField(paramRect, parameterTypeField);
+                    GUI.enabled = true;
+                    // Draw the read/write fields
+                    EditorGUI.PropertyField(syncRect, synchronizeField);
+                    // Set the indention level up
+                    EditorGUI.indentLevel--;
+                }
+                // Set the indention level up
+                EditorGUI.indentLevel--;
+            }
+            EditorGUI.EndProperty();
+        }
+
+        public override float GetPropertyHeight(SerializedProperty property, GUIContent label)
+        {
+            var totalHeight = EditorGUIUtility.singleLineHeight;
+            if (!property.isExpanded)
+            {
+                return totalHeight;
+            }
+            var singleLineWithSpace = EditorGUIUtility.singleLineHeight + 2;
+            SerializedProperty items = property.FindPropertyRelative(nameof(NetworkAnimator.AnimatorParameterEntries.ParameterEntries));
+
+            totalHeight += singleLineWithSpace;
+            for (int i = 0; i < items.arraySize; i++)
+            {
+                SerializedProperty element = items.GetArrayElementAtIndex(i);
+                if (element.isExpanded)
+                {
+                    totalHeight += (singleLineWithSpace * 4);
+                }
+                else
+                {
+                    totalHeight += EditorGUIUtility.singleLineHeight;
+                }
+            }
+            return totalHeight;
+        }
+    }
+}
+#endif