Update to MLAPI: onnetworkspawn refactoring, player prefab removed from networkmanager prefab list #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
SamuelBellomo
changed the title
| @@ -97,7 +97,7 @@ private struct ActionRequest | |||
| /// </summary> | |||
| CharacterClass CharacterData => GameDataSource.Instance.CharacterDataByType[m_NetworkCharacter.CharacterType]; | |||
|
|
|||
| public override void NetworkStart() | |||
| public override void OnNetworkSpawn() | |||
There was a problem hiding this comment.
as discussed, let's make sure there's a despawn that unregisters this if needed
There was a problem hiding this comment.
Done. Added an event to subscribe to (HeroActionBar and HeroEmoteBar do this) for when the local player's ClientInputSender is NetworkSpawned & NetworkDespawned.
SamuelBellomo
previously approved these changes
Jul 5, 2021
SamuelBellomo
approved these changes
Jul 7, 2021
Cosmin-B
approved these changes
Jul 7, 2021
Cosmin-B
added a commit
that referenced
this pull request
Sep 14, 2021
* feature/adding-UTP: Adding ParrelSync and updating third party notice.md (#357) updating to latest UTP Feature/player persistence prefab refactor (#349) upping MLAPI develop version (#355) Update to MLAPI: onnetworkspawn refactoring, player prefab removed from networkmanager prefab list (#352) porting to UTP # Conflicts: # Assets/BossRoom/Prefabs/NetworkingManager.prefab # Assets/BossRoom/Scenes/Startup.unity # Assets/BossRoom/Scripts/Client/BossRoom.Client.asmdef # Assets/BossRoom/Scripts/Shared/BossRoom.Shared.asmdef # Assets/BossRoom/Scripts/Shared/Game/UI/Editor/NetworkLatencyWarning.cs # Packages/manifest.json # Packages/packages-lock.json # ProjectSettings/PackageManagerSettings.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BossRoom now tracks MLAPI develop hash
7e19026a74f6573cc4aa22d746275332e702d2c5.This fixes quite a bit of editor QoL issues. Namely:
NetworkVariable<T>in editor fix: fix: do not access/render runtime info if not playing in the editor com.unity.netcode.gameobjects#898.NetworkPrefabsinside NetworkManager being invalidated: fix: NetworkPrefabs container's elements invalidated in the NetworkManager after relaunching Unity Project com.unity.netcode.gameobjects#905.Notable API change:
NetworkStart()refactored toOnNetworkSpawn(). Same functionality.Playerprefab has also been removed fromNetworkPrefabslist since there is now a dedicated field forPlayer Prefab.