Enable mixed call stacks when debuggee loads a mono-2.0* dynamic libr… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary into the process. We still only process if a file exists on disk with the same process id. Also, enable mixed call stacks for non-main threads.
mderoy
approved these changes
Jan 5, 2018
| { | ||
| private static List<Range> _rangesSortedByIp = new List<Range>(); | ||
| private static FuzzyRangeComparer _comparer = new FuzzyRangeComparer(); | ||
| private static bool _enabled = true; | ||
| private static bool _enabled; | ||
| private static IVsOutputWindowPane _debugPane; | ||
| private static string _currentFile; | ||
| private static FileStream _fileStream; | ||
| private static StreamReader _fileStreamReader; | ||
|
|
||
| public void OnLoadComplete(DkmProcess process, DkmWorkList workList, DkmEventDescriptor eventDescriptor) |
There was a problem hiding this comment.
Future Cleanup: We could probably remove this window stuff, unless we're planning on logging things to the output window.
There was a problem hiding this comment.
I thought about it, but I see we log other info there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ary into the process. We still only process if a file exists on disk with the same process id. Also, enable mixed call stacks for non-main threads.