Skip to content

WIP: AIRO-1243 Make Unity ROS Service Async #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sdiao
Copy link
Contributor

@sdiao sdiao commented Sep 23, 2021

Proposed change(s)

Describe the changes made in this PR.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [e.g. Windows 10]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

at669
at669 previously approved these changes Sep 28, 2021
Copy link
Contributor

@at669 at669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with P&P and seems to work in conjunction with Endpoint laurie/NoMoreSourceDestinationDict branch!

Func<Message, Message> m_ServiceImplementation;
private Func<Message, Task<Message>> m_ServiceImplementationAsync;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: redundant private specification

@at669
Copy link
Contributor

at669 commented Sep 28, 2021

should I be able to show a default or custom HUD window or visualizer for services? if i try to turn any of the above on for the MoverService, I get:

ROS side: [ERROR] [1632851615.610341]: Failed to resolve message name: 'module' object has no attribute 'MoverService'
Unity side: SysCommand.subscribe - Unknown message class 'niryo_moveit/MoverService'

@at669 at669 dismissed their stale review September 28, 2021 21:19

Error when viewing services

@LaurieCheers-unity LaurieCheers-unity merged commit 985ab52 into laurie/VisualizationPackage Sep 29, 2021
@LaurieCheers-unity LaurieCheers-unity deleted the AIRO-1243-Unity-Service-Async branch January 18, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants