Skip to content

FIX: UITK Listen button not working with Any control types #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

jamesmcgill
Copy link
Collaborator

Description

Fix issue where the 'Listen' button did not work on the new UITK based editor when the controlType was set to Any.

Changes made

Ensure the control types drop-down list always begins with Any in the first position. This is the behaviour in the previous editor and Any is treated as a special case.
Prevent putting the string "Any" into InputAction.expectedControlType, it's expected to be null in this case (and serialized as empty string).
Removed internal jira links from the changelog.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesmcgill jamesmcgill merged commit fa5f304 into develop Nov 2, 2023
@jamesmcgill jamesmcgill deleted the ISX-1650-listen-button-fix branch November 2, 2023 09:34
jamesmcgill added a commit that referenced this pull request Nov 8, 2023
* FIX: UITK Listen button not working with Any control types

* Remove jira links for ISX project issues from changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants