Remove unused test struct

Author: jfreire-unity

Assets/Tests/InputSystem/Plugins/HIDTests.cs

@@ -1122,7 +1122,7 @@ public void Devices_GenericHIDConvertsXAndYUsagesToStickControl()
     }
 
     [StructLayout(LayoutKind.Explicit)]
-    struct SimpleJoystickLayoutWithStickUshort : IInputStateTypeInfo
+    struct SimpleJoystickLayoutWithStick : IInputStateTypeInfo
     {
         [FieldOffset(0)] public byte reportId;
         [FieldOffset(1)] public ushort x;
@@ -1131,16 +1131,6 @@ struct SimpleJoystickLayoutWithStickUshort : IInputStateTypeInfo
         public FourCC format => new FourCC('H', 'I', 'D');
     }
 
-    [StructLayout(LayoutKind.Explicit)]
-    struct SimpleJoystickLayoutWithStickByte : IInputStateTypeInfo
-    {
-        [FieldOffset(0)] public byte reportId;
-        [FieldOffset(1)] public sbyte x;
-        [FieldOffset(2)] public sbyte y;
-
-        public FourCC format => new FourCC('H', 'I', 'D');
-    }
-
     [Test]
     [Category("Devices")]
     public void Devices_GenericHIDXAndYDrivesStickControl()
@@ -1175,7 +1165,7 @@ public void Devices_GenericHIDXAndYDrivesStickControl()
         Assert.That(device, Is.TypeOf<Joystick>());
         Assert.That(device["Stick"], Is.TypeOf<StickControl>());
 
-        InputSystem.QueueStateEvent(device, new SimpleJoystickLayoutWithStickUshort { reportId = 1, x = ushort.MaxValue, y = ushort.MinValue });
+        InputSystem.QueueStateEvent(device, new SimpleJoystickLayoutWithStick { reportId = 1, x = ushort.MaxValue, y = ushort.MinValue });
         InputSystem.Update();
 
         Assert.That(device["stick"].ReadValueAsObject(),

Packages/com.unity.inputsystem/InputSystem/Plugins/HID/HIDParser.cs

@@ -277,7 +277,7 @@ private unsafe static int ReadData(int itemSize, byte* currentPtr, byte* endPtr)
                     return 0;
                 var data1 = *currentPtr;
                 var data2 = *(currentPtr + 1);
-                return (short)(data2 << 8) | data1;
+                return (short)((data2 << 8) | data1);
             }
 
             // Read int.