[10.x.x] Merge Hdrp/staging [Skip CI] #984

sebastienlagarde · 2020-06-19T10:25:40Z

Purpose of this PR

Various fixes for Graphics tests with Render Graph Various fixes for Graphics tests with Render Graph #725
Finished management of Compute Buffers for render graph. Finished management of Compute Buffers for render graph. #966
Fix material ui nullref Fix material ui nullref #982
Make Post-processing passes rendergraph ready Make Post-processing passes rendergraph ready #963
Change extensions of CAS includes from h to hlsl Change extensions of CAS includes from h to hlsl #961
Added scene view camera documentation Added scene view camera documentation #975
[skip ci] Add test scene for transparent depth pre & post pass [skip ci] Add test scene for transparent depth pre & post pass #978
Small final histogram issue (resize issue) and improve debug exposure shader compile times Small final histogram issue (resize issue) and improve debug exposure shader compile times #967
Hdrp Improved Depth Of Field (Hdrp Improved Depth Of Field #965)

Testing status

Manual Tests: What did you do?

Opened test project + Run graphic tests locally
Built a player
Checked new UI names with UX convention
Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
C# and shader warnings (supress shader cache to see them)
Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?

Comments to reviewers

Notes for the reviewers you have assigned.

Fixed a lot of gcalloc.

…nder graph is enabled.

… to Color Grading not being 100% neutral)

This reverts commit 505924b.

Reduced error message spam when encountering an execution error.

…n passes.

…Graphics into HDRP/rendergraph-graphicstests

Fixed a number of pass pruning issues.

This reverts commit 76a7c00.

This reverts commit 7b8acc0.

This reverts commit 84467f6.

This reverts commit 95952b0.

…ug exposure considerably

This reverts commit 8e7aca7.

…o-resize-issue Small final histogram issue (resize issue) and improve debug exposure shader compile times

As a bonus, texts are now ordered to be after post process, and I also added an arra placer utility

[skip ci] Add test scene for transparent depth pre & post pass

…camera Added scene view camera documentation

…des-to-hlsl Change extensions of CAS includes from h to hlsl

…Graphics into HDRP/rg-create-computebuffer # Conflicts: # com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs

…render-graph Make Post-processing passes rendergraph ready

…nullref Fix material ui nullref

…ebuffer Finished management of Compute Buffers for render graph.

* Initial unoptimized physically based DoF implementation * Minor fixes * Fix compilation of inactive per,utations * Add interleaved noise * Add alpha support * Add adaptive gather radius * always use the old DoF for now * take gatefit into account * Add a couple more levels in the CoC pyramid * Fix some inactive code paths * Fix CoC pyramid for near field * Rename Cycle Of Confusion to Circle Of Confusion Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

JulienIgnace-Unity added 30 commits May 27, 2020 09:52

WIP for enabling valid graphics tests with Render Graph.

1df359c

Fixed a lot of gcalloc.

Fixed more GCAlloc and added an option for a test to not be run if re…

64ef0ca

…nder graph is enabled.

First batch of disabled tests.

505924b

Fixed decal rendering

a6c1f8e

Implemented ColorGrading and Uber Post (fixes a lot of small diff due…

04d0d20

… to Color Grading not being 100% neutral)

Revert "First batch of disabled tests."

4934ab9

This reverts commit 505924b.

Temp "texture not bound" error fix until bloom is implemented.

0dd42d8

Fixed an error when using a stale invalid renderer list handle.

027a5c5

Reduced error message spam when encountering an execution error.

Add some debug info to compiled passes and removed wrong refCount++ o…

349a273

…n passes.

Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…

a98f454

…Graphics into HDRP/rendergraph-graphicstests

Added possibility to disallow pass pruning

3eb0eb6

Fixed a number of pass pruning issues.

Small fixes

e1f9e08

temporarily removed pruning of passes without product

1213511

Fixed HDRP asset for test 5009

95952b0

Implement alpha copy for post processes

1d97a44

Small render graph error fix for motion vector pass.

0c62ef7

Disabled for render graph tests that are currently broken.

84467f6

Updated yamato with new render graph configurations

7b8acc0

Fixed lens distortion

46a64a3

Reenabled 4021

76a7c00

Added an option to ignore tests when render graph is enabled.

9c4c38e

Disabled for render graph tests that are currently broken.

e5d8dd0

Reenabled 4021

ec2a4af

Updated yamato script to add the RenderGraph pipeline.

399512c

Revert "Reenabled 4021"

68fb303

This reverts commit 76a7c00.

Revert "Updated yamato with new render graph configurations"

fb085d0

This reverts commit 7b8acc0.

Revert "Disabled for render graph tests that are currently broken."

b3ac299

This reverts commit 84467f6.

Reverted HDRP test framework files (will go to another PR)

d0bb7fa

Revert "Fixed HDRP asset for test 5009"

4ac6aa2

This reverts commit 95952b0.

Fixed HDRP asset for test 5009

0e1d250

FrancescoC-unity and others added 23 commits June 18, 2020 10:50

revert misalignment

106320d

Moved decal property mask buffer to render graph created buffer.

7d1681f

Fixed reset size of width/height

5a3d99f

Fix small issue when resizing window and improve compile time for deb…

8e7aca7

…ug exposure considerably

Revert compile time improvement... warning still there, makes no sense.

03af921

This reverts commit 8e7aca7.

Fixed size of dbuffer property mask buffer.

49a908c

avoid warning and prevent unrolling (improve compile time)

79da69b

Merge pull request #967 from Unity-Technologies/HDRP/final-image-hist…

c77e3ee

…o-resize-issue Small final histogram issue (resize issue) and improve debug exposure shader compile times

Added scene view camera doc

e5ee34d

Update TableOfContents.md

aa5c854

Add test scene for transparent depth pre & post pass

3b3ceb4

As a bonus, texts are now ordered to be after post process, and I also added an arra placer utility

Merge pull request #978 from Unity-Technologies/HDRP/tests/pre-post-pass

2c622a3

[skip ci] Add test scene for transparent depth pre & post pass

Merge pull request #975 from Unity-Technologies/HDRP/docs/Scene-view-…

314b501

…camera Added scene view camera documentation

Merge pull request #961 from Unity-Technologies/HDRP/rename-cas-inclu…

5c30a76

…des-to-hlsl Change extensions of CAS includes from h to hlsl

Fixed unit tests

0fd07af

Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…

f732507

…Graphics into HDRP/rg-create-computebuffer # Conflicts: # com.unity.render-pipelines.core/Runtime/RenderGraph/RenderGraphResourceRegistry.cs

Merge pull request #963 from Unity-Technologies/HDRP/post-processing-…

bfcda7b

…render-graph Make Post-processing passes rendergraph ready

Fixed Receive SSR transparent nullref

6cf8c91

Fixed terrain and axf nullref

dc97a6b

Updated changelog

944cfac

Merge pull request #982 from Unity-Technologies/HDRP/fix/material-ui-…

c46d266

…nullref Fix material ui nullref

Merge pull request #966 from Unity-Technologies/HDRP/rg-create-comput…

cb8a7f3

…ebuffer Finished management of Compute Buffers for render graph.

sebastienlagarde requested a review from JulienIgnace-Unity June 19, 2020 10:25

Merge branch 'master' into HDRP/staging

b58a5d5

github-actions bot added HDRP testing labels Jun 19, 2020

JulienIgnace-Unity approved these changes Jun 19, 2020

View reviewed changes

Merge branch 'master' into HDRP/staging

fcf02f0

sebastienlagarde merged commit 3cfe2a2 into master Jun 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[10.x.x] Merge Hdrp/staging [Skip CI] #984

[10.x.x] Merge Hdrp/staging [Skip CI] #984

Uh oh!

sebastienlagarde commented Jun 19, 2020 •

edited

Loading

Uh oh!

Uh oh!

[10.x.x] Merge Hdrp/staging [Skip CI] #984

[10.x.x] Merge Hdrp/staging [Skip CI] #984

Uh oh!

Conversation

sebastienlagarde commented Jun 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

Uh oh!

sebastienlagarde commented Jun 19, 2020 •

edited

Loading