Skip to content

[8.x.x Backport] Fix depth pyramid issues with dynamic resolution #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed for area light not updating baked light result when modifying with gizmo.
- Fixed issue with white flash when enabling SSR.
- Fix inconsistencies with transparent motion vectors and opaque by allowing camera only transparent motion vectors.
- Fixed issue with depth pyramid generation and dynamic resolution.

### Changed
- Shadowmask and realtime reflection probe property are hide in Quality settings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4047,6 +4047,7 @@ void GenerateDepthPyramid(HDCamera hdCamera, CommandBuffer cmd, FullScreenDebugM
{
CopyDepthBufferIfNeeded(hdCamera, cmd);

m_SharedRTManager.GetDepthBufferMipChainInfo().ComputePackedMipChainInfo(new Vector2Int(hdCamera.actualWidth, hdCamera.actualHeight));
int mipCount = m_SharedRTManager.GetDepthBufferMipChainInfo().mipLevelCount;

using (new ProfilingScope(cmd, ProfilingSampler.Get(HDProfileId.DepthPyramid)))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,10 @@ public void Allocate()
// This function is NOT fast, but it is illustrative, and can be optimized later.
public void ComputePackedMipChainInfo(Vector2Int viewportSize)
{
// No work needed.
if (viewportSize == mipLevelSizes[0])
return;

textureSize = viewportSize;
mipLevelSizes[0] = viewportSize;
mipLevelOffsets[0] = Vector2Int.zero;
Expand Down