[Template]added new input package as template dependancy #7419
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
ernestasKupciunas
requested review from
ernestasKupciunas
and removed request for
a team
ernestasKupciunas
suggested changes
May 23, 2022
There was a problem hiding this comment.
Controls for mobiles are not working. Works fine on Standalone MacOS.
Tested with:
Controls are not working:
VLNQA00268, Samsung Galaxy S10+, 10.0.0, Exynos 9 9820, Mali-G76
VLNQA00279 - Samsung Galaxy S10+ USA (SM-G975U), CPU: Snapdragon 855 SM8150, GPU: Adreno 640, OS: 9.0.0
iPhone 12Pro, SoC: A14, iOS: 14.1
Controls work fine:
MacBook Pro (16-inch, 2021), CPU: Apple M1 Max, Memory: 64 GB, macOS: Monterey 12.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
New input system wasn't added when previous work done to support it in the templates, this PR fixes that
Testing status
Loaded the template and observed no errors
Comments to reviewers
Need QA to check platforms and controls still work