Skip to content

[HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

[HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953

merged 3 commits into from
Feb 2, 2022

Conversation

remi-chapelain
Copy link
Contributor

@remi-chapelain remi-chapelain commented Feb 2, 2022 •
edited
Loading

Purpose of this PR

Following this PR, the same fix is needed for the lens flare indoor sample scene.

Testing status

Switched between scenes (outdoor, indoor) with and without always refresh. ✔️

Comments to reviewers

Needs backport 2021.2 and need to check after backport that the volume has the proper override since we had issue with backport for the indoor template scenes

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Feb 2, 2022
@remi-chapelain remi-chapelain marked this pull request as ready for review February 2, 2022 10:21
@sebastienlagarde sebastienlagarde merged commit d6c0c8c into master Feb 2, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-indoor-lensflare-sample branch February 2, 2022 11:12
sebastienlagarde pushed a commit that referenced this pull request Feb 2, 2022
@remi-chapelain @sebastienlagarde
[HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953
a469093
@sebastienlagarde sebastienlagarde mentioned this pull request Feb 2, 2022
Merged
sebastienlagarde added a commit that referenced this pull request Feb 2, 2022
@sebastienlagarde @anisunity
@alelievr @remi-chapelain
[HDRP] Backport various Prs (#6960)
5be0c9d 
* Changed the roughness value used for screen space reflections and ray traced reflections to match environment lighting (case 1390916). #680

* [HDRP] Improve custom pass name UI #6859

* Fixed using the wrong directional light data for clouds and the definition of current Sun when the shadow pass is culled (case 1399000) #6925

* [HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953

* [Hdrp] Merge Hd/bugfix #6954

* Update HDAdditionalLightData.cs

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@anisunity anisunity Awaiting requested review from anisunity

Assignees
No one assigned
Labels
backported-2021.2 backported-2022.1 HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-chapelain @sebastienlagarde