Skip to content

2021.2/universal/case 1379188 particle unlit blend #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 3, 2022
Merged

2021.2/universal/case 1379188 particle unlit blend #6840

merged 6 commits into from
Feb 3, 2022

Conversation

eh-unity
Copy link
Contributor

@eh-unity eh-unity commented Jan 25, 2022 •
edited
Loading

Purpose of this PR

Custom backport of particle unlit shader blending fixes.
Case: 1379188

In master fixed by this PR: #5762 and additionally this #6861

Testing status

Ran local foundation tests.

Comments to reviewers

Notes for the reviewers you have assigned.

@eh-unity eh-unity changed the base branch from master to 2021.2/staging January 25, 2022 17:22
@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@eh-unity eh-unity marked this pull request as ready for review January 25, 2022 17:23
@eh-unity eh-unity requested review from a team as code owners January 25, 2022 17:23
@eh-unity eh-unity requested a review from ellioman January 26, 2022 11:20
phi-lira
phi-lira approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@phi-lira phi-lira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to refer to the original PR, even when this is a custom backport. It helps add context and reviewers.

@phi-lira
Copy link
Contributor

Referencing the original PR is also good because then we would be able to see which PR backported it, also you should add backported tag in the original PR.

@eh-unity
Copy link
Contributor Author

This does not have a parent PR. In master the issue was fixed by the overall blending changes, while here I fixed only the reported issue. And while doing so I discovered another issue which is fixed in another PR in master.
But I can add reference to the blending PR in master.

ellioman
ellioman reviewed Jan 28, 2022
View reviewed changes
com.unity.render-pipelines.universal/CHANGELOG.md Outdated
Comment on lines 9 to 11
Version Updated
The version number for this package has increased due to a version update of a related graphics package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this part since you're the first one adding something to 12.1.5.

ellioman
ellioman approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@ellioman ellioman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the changelog and we're good.

@eh-unity
Copy link
Contributor Author

eh-unity commented Feb 3, 2022

Test failures in commit ad77d5b
appear to be the same as in 21.2/staging.

@eh-unity eh-unity merged commit 35273a9 into 2021.2/staging Feb 3, 2022
@eh-unity eh-unity deleted the 2021.2/universal/case-1379188-particle-unlit-blend branch February 3, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

@simon-engelbrecht-soerensen simon-engelbrecht-soerensen simon-engelbrecht-soerensen approved these changes

@phi-lira phi-lira phi-lira approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eh-unity @phi-lira @ellioman @simon-engelbrecht-soerensen