Skip to content

Fix for issue with SSAO (and in fact anything sampling depth pyramid) at edges #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Fix for issue with SSAO (and in fact anything sampling depth pyramid) at edges #6839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a539f5
tentative fix
FrancescoC-unity Jan 24, 2022
05285c1
changelog
FrancescoC-unity Jan 25, 2022
db0d018
right parenthesis
FrancescoC-unity Jan 25, 2022
9bacf73
Merge branch 'hd/bugfix' into HDRP/correct-depth-downsampling
sebastienlagarde Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a nullref exception when creating a new scene while LightExplorer is open.
- Fixed issue that caused the uber post process to run even if nothing is to be done, leading to different results when disabling every post process manually vs disabling the whole post-processing pipeline.
- Fixed issue that placed an OnDemand shadow in the atlas before it was ever rendered.
- Fixed issue at edge of screen on some platforms when SSAO is on.

## [14.0.0] - 2021-11-17

Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/DownsampleDepth.shader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Shader "Hidden/HDRP/DownsampleDepth"
float4 depths = GATHER_RED_TEXTURE2D_X(_CameraDepthTexture, s_linear_clamp_sampler, input.texcoord * _ScaleBias.xy + _ScaleBias.zw);
outputDepth = MinDepth(depths);
#else
uint2 fullResUpperCorner = uint2(input.positionCS.xy * 2.0);
uint2 fullResUpperCorner = uint2((((float2)input.positionCS.xy - 0.5f) * 2.0) + 0.5f);
float4 depths;
depths.x = LoadCameraDepth(fullResUpperCorner);
depths.y = LoadCameraDepth(fullResUpperCorner + uint2(0, 1));
Expand Down