Skip to content

[10.0.0] Remove player connection argument from Android URP test runs [skip ci] #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

tomzig16
Copy link
Contributor

@tomzig16 tomzig16 commented Jun 1, 2020

Purpose of this PR

Latest changes to Android .yml files have player-connection arguments which made tests fail with newer UTR versions by simply failing connecting to devices. This PR removes them.


Testing status

Automated Tests:
Ran Yamato tests

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/android%252Furp-tests%252Fremove-bokken-device-ip

Any test projects to go with this to help reviewers?
No changes to the projects were made


Comments to reviewers

This PR only modifies android yml files, so I see no point in running ABV, added skip ci.
Regarding failure: I have accidentally started hybrid android tests, which fails to build. This PR does not affect that suite.

@tomzig16 tomzig16 requested a review from a team as a code owner June 1, 2020 11:58
@github-actions github-actions bot added the yamato label Jun 1, 2020
@stramit stramit merged commit 4285c42 into master Jun 2, 2020
@stramit stramit deleted the android/urp-tests/remove-bokken-device-ip branch June 2, 2020 06:34
@theopnv
Copy link
Contributor

theopnv commented Jun 2, 2020

Hi, if I'm not mistaken there may be a hidden problem here.
@tomzig16 , your changes involved modifying the .yml files directly, which works, but at any time the yml files can be re-generated by someone else running the Python script (.yamato/ruamel/build.py). (They were regenerated on my local branch based on master and which includes your commit).
I think the yml files should now be generated only by running this python script after updating the related config metafiles, so that your changes aren't overridden: https://docs.google.com/document/d/1UlmDR0gkpnMGR9nQnksZdjKzSesyTlIRgWvj_uQYBAI/edit#heading=h.v36jmxupizei

@tomzig16
Copy link
Contributor Author

tomzig16 commented Jun 3, 2020

Thank you @theo-pnv , I have made a PR (#714) addressing your comments.

sebastienlagarde pushed a commit that referenced this pull request Feb 2, 2022
… traced reflections to match environment lighting (case 1390916). #680
sebastienlagarde added a commit that referenced this pull request Feb 2, 2022
* Changed the roughness value used for screen space reflections and ray traced reflections to match environment lighting (case 1390916). #680

* [HDRP] Improve custom pass name UI #6859

* Fixed using the wrong directional light data for clouds and the definition of current Sun when the shadow pass is culled (case 1399000) #6925

* [HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953

* [Hdrp] Merge Hd/bugfix #6954

* Update HDAdditionalLightData.cs

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants