Skip to content

[HDRP] backport misc PRs #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 13, 2022
Merged

[HDRP] backport misc PRs #6738

merged 15 commits into from
Jan 13, 2022

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Jan 13, 2022 •
edited
Loading

Purpose of this PR

Fixed the property name of screen weight distance (#6586)
Documentation and images for custom mip for texture samplers (#6592)
[HDRP] Fix tile/cluster debug for Decal and Fog #6635
Minor rewording of PT doc. (#6637)
Review new warmup cost section (#6683)
Path fixes (#6692)
fixed typo "pratices" -> "practices" in ToC (#6699)
fixed link to decal.md (#6700)
Volume docs bugfixes (#6714)
NeedMotionVectorForTransparent was checking for wrong flag #6719
[HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722
Fix (#6649)
[HDRP] Fix rendering when adding an incompatible platform to the proj…
Fixed a crash with render graph viewer
Fixed Custom Pass DrawRenderers shader not compatible with SRP Batcher …

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

emilybrown1 and others added 15 commits January 13, 2022 14:21
@emilybrown1 @sebastienlagarde
Fixed the property name of screen weight distance (#6586)
112a438
@kecho @sebastienlagarde
Documentation and images for custom mip for texture samplers (#6592)
7e26b3a 
* Documentation and images for custom mip for texture samplers

* Code review suggested changes.
@simonb-unity @sebastienlagarde
[HDRP] Fix tile/cluster debug for Decal and Fog #6635
f6be3b6
@eturquin @sebastienlagarde
Minor rewording of PT doc. (#6637)
4e60484
@Vic-Cooper @sebastienlagarde
Review new warmup cost section (#6683)
2660a92 
A few fixes applied to the changes in #6498 and #6323.
@Vic-Cooper @sebastienlagarde
Path fixes (#6692)
7acd411 
Updated incorrect menu paths.
@emilybrown1 @sebastienlagarde
fixed typo "pratices" -> "practices" in ToC (#6699)
e55ace6
@emilybrown1 @sebastienlagarde
fixed link to decal.md (#6700)
36d8621
@Vic-Cooper @sebastienlagarde
Volume docs bugfixes (#6714)
4dc3a79 
* Volume docs bugfixes

Updates screenshots, menu paths and fixed some typos and inaccuracies.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
@FrancescoC-unity @sebastienlagarde
NeedMotionVectorForTransparent was checking for wrong flag #6719
4e89992
@JMargevics @sebastienlagarde
[HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722
f37925e
@FrancescoC-unity @sebastienlagarde
Fix (#6649)
25cbb34
@sebastienlagarde
[HDRP] Fix rendering when adding an incompatible platform to the proj…
19e4d6a 
…ect #6495
@sebastienlagarde
Fixed a crash with render graph viewer
9b2ee0f
@sebastienlagarde
Fixed Custom Pass DrawRenderers shader not compatible with SRP Batcher …
24204df 
…#6501
@sebastienlagarde sebastienlagarde marked this pull request as ready for review January 13, 2022 13:34
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_2021.2
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%2F_abv.yml%23all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde merged commit 717cb1d into 2021.2/staging Jan 13, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/misc-backport branch January 13, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienIgnace-Unity JulienIgnace-Unity Awaiting requested review from JulienIgnace-Unity

Assignees
No one assigned
Labels
HDRP SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sebastienlagarde @emilybrown1 @kecho @simonb-unity @eturquin @Vic-Cooper @FrancescoC-unity @JMargevics