[VFX] Staging to Master #6689

PaulDemeulenaere · 2022-01-06T14:33:45Z

Purpose of this PR

Sticky note title had wrong font size while editing (#301) @julienamsellem
Vfx/fix/1365868 vcs toolbar dropdown (#286) @julienamsellem
Fix Collision & Zero scaled (#299) @PaulDemeulenaere
Fix GPU event particle init after restarting VisualEffect (#297) @gabrieldelacruz
Avoid error when using select-all shortcut to delete vfx content (#305) @ludovic-theobald
Bounds helper Edit Mode test (#303) @ludovic-theobald
Force read Alive in update when use somewhere else #302) @ludovic-theobald

Testing status

Yamato 🟢

Comments to reviewers

N/A

@tristan

* Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant * Fix reference lost in m_SerializableType No idea of implication of this :-/ * Squashed commit of the following: (retrieve fix from @tristan) commit c24981d7dad15100eb40a92a6a9370e9ba800acd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 17:27:57 2020 +0200 Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 commit a87ba18 Merge: 13b501e 296ffd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:25:02 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/error-at-creation # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 13b501e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:24:27 2020 +0200 *Add warning for CollisionDepthBuffer Update & Fix Changelog.md commit 4bfb1e7 Author: Tristan Genevet <tristan@unity3d.com> Date: Thu Oct 8 18:10:42 2020 +0200 Fix for displaying error from the creation of a node. * Add error feedback on failing custom spawner reference * Revert "Allow Set Spawn Count & Set Spawn Time" This reverts commit 0a6c75c. # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Remove unexpected change * *Revert change in changelog * *WIP* add ResolveCustomCallbackInstance Some refactor mark as "TODOPAUL" * Clean implementation : customBehavior & comment * *Add test to cover sanitize before modify references * Change namespace for builtin custom spawner & sanitize * Extend test to verify connexion * *Update changelog.md * Add specific error if customBehavior returns null * Fix corner case when ScriptableObject reference has been lost * Work but not idea with copy/past + potential leak * Better implementation : use directly "MonoScript" * Fix spawnerTest * Rename "Can't found" => "Can't find"

…pacity (#174) Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136 And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8

* Add test * Add test to cover behavior from case 1271839

* Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog

* Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Initial commit * Overflow handling options for the user * Addressing mode for overflow to the choice of the user * Foldable to Constant value * Update 09_PointCache.vfx * Added reference images * Remove float-to-integer conversion * Put the choice of the output type in the Inspector only * Simplify output type handling * Sample Point cache != Attribute map => two operators * Update Branch (error .yamato/docs/editor_pinning.png) * Update SamplePointCache.cs * Update 09_PointCache.vfx * Output type set in a cogwheel * Update 09_PointCache.vfx * Revert "Update Branch (error .yamato/docs/editor_pinning.png)" This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc. * Restore vfx asset * Revert back to using generics for type handling * Update SampleAttributeMap.cs * Reformating + changelog * Update 09_PointCache.vfx * Update SamplePointCache.cs * Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap * Merge branch 'vfx/staging' into vfx/feature/sample-point-cache * Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache" This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e.

* Update Pass.template * Update CHANGELOG.md

…fx-graphics into vfx/staging

* Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog

* Avoid implicit trucation in template + safe normalize setting * Update CHANGELOG.md * Added variants * Delete conditioning on GPU evaluation + conservative safe normalize Co-authored-by: Julien Fryer <julienf@unity3d.com>

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/09_AttributeMaps.png

…-graphics/pull/176 Issue introduced at 44f497b : Incorrect VFXExpressionCondition See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z

This reverts commit ddee2e3.

Instability detected.

* Add helper to check invalid collision matrices Avoid incorrect InvFieldTransform for collision sphere, cone & SDF * Fix incorrect column extraction in GPU implementation * *Update changelog.md * Fix typo * Fix missing check zeroScale on KillSphere See https://docs.google.com/document/d/1DRbHfYL948hLPiFywFMudJJLx9vetaD-C3hA3AaUSNM/edit?disco=AAAASPDxyE8 * Fix torus when majorRadius is zeo Avoid division by zero when majorRadius is zero It isn't a regression but simply a corner case (which can be easily avoided) See https://docs.google.com/document/d/1DRbHfYL948hLPiFywFMudJJLx9vetaD-C3hA3AaUSNM/edit?disco=AAAARjEC47s

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

* Add implicitPreBlock to VFXBasicInitialize to force alive on gpu spawn * Detect if it is the first time accessing the previous buffer, and use 0 instead * Update CHANGELOG.md * Update CHANGELOG.md * Add explanatory comment for implicit alive block in VFXBasicInitialize

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

* Avoid error when using select-all shortcut to delete vfx content This action was including the VFXSystemBorder in the list of elements to delete whereas it seems not expected because it does not happen when doing a rectangle selection with the mouse. * Updated changelog

* draft of test for bounds helper * Updated working tests * Double check to avoid NRE (ceinture & bretelles comme on dit) Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Julien Amsellem <julien.amsellem@unity3d.com>

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

* Force read Alive when it's written somewhere * Update changelog * Correct version for changelog Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

@ludovic-theobald

Discuss with @ludovic-theobald about this, intentional direct commit to vfx/staging

julienf-unity

Ok. I just added a note in #302 I'm wondering if the fix could have side effects

PaulDemeulenaere · 2022-01-12T13:09:35Z

Ok. I just added a note in #302 I'm wondering if the fix could have side effects

Ok, I will wait for observation before merging then.

julienf-unity · 2022-01-12T15:05:04Z

No it can be merged, No need to delay all the fixes. If there's a fix, it will be comitted afterwards

PaulDemeulenaere · 2022-01-12T16:24:30Z

Awaiting for some result in Yamato before hitting the "Squash" button ⏳

PaulDemeulenaere · 2022-01-12T17:29:22Z

URP compilation broke on master, see this conversation

PaulDemeulenaere · 2022-01-13T12:45:32Z

Only Formatting failing (not related to this PR), ready to be merge 🎉

gabrieldelacruz and others added 30 commits November 27, 2020 15:27

Missing Reference image for test 32_ExcludeFromTAA

5015bd6

Add test to cover case exposed by 1258022 (#54)

cc36c16

[Test] Add test to cover "Thread Group Size" error (#104)

cf3b4ae

* Add test * Add test to cover behavior from case 1271839

Fix Preset (with exclusion) (#177)

ff94af5

* Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog

Update gradient test (#151)

a515f2f

* Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com>

Fix point cache vfx + update HDRP vfx

071ce22

Update URP assets

a6ee6de

Fix changelog

8b44f3b

Merge branch 'master' into vfx/staging

7649fe1

Fix Case 1223747 - NaN caused by normal bending (#181)

83ad751

* Update Pass.template * Update CHANGELOG.md

Merge branch 'vfx/staging' of github.cds.internal.unity3d.com:unity/v…

ebcf59f

…fx-graphics into vfx/staging

1293608 - Fix LPPV not working in deferred (#180)

8f3b4f9

* Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog

Fix 1290493 - Spaceship specific warnings (#176)

44f497b

* Avoid implicit trucation in template + safe normalize setting * Update CHANGELOG.md * Added variants * Delete conditioning on GPU evaluation + conservative safe normalize Co-authored-by: Julien Fryer <julienf@unity3d.com>

Fix incorrect compilation condition for linux build (#184)

5cf1dba

Merge branch 'master' into vfx/staging

dcf74db

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/09_AttributeMaps.png

Fix formatting

0656778

Update 26_NonUniformScale kind of sky : gradient instead of procedural

2a9964b

Fix regression from https://github.cds.internal.unity3d.com/unity/vfx…

b89005c

…-graphics/pull/176 Issue introduced at 44f497b : Incorrect VFXExpressionCondition See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z

Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe

b65e953

*Update VFX (newly introduced safeNormalize, default 0)

79d801d

Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA

ddee2e3

Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA"

8c5f44f

This reverts commit ddee2e3.

32_ExcludeFromTAA : Disable XR

362b7f0

33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006

dd7b751

*Update Image Reference for D312 (mainly missing file)

d9a3a0b

*Disable 32_ExcludeFromTAA

a05860f

Instability detected.

PaulDemeulenaere and others added 8 commits December 9, 2021 08:39

Merge branch 'master' into vfx/staging

fe9085d

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

Fix changelog.md ordering (new entry in 14.x.x)

3ff23b0

Merge branch 'master' into vfx/staging

cf2eabe

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

[Test] Bounds helper Edit Mode test (#303)

5a81703

* draft of test for bounds helper * Updated working tests * Double check to avoid NRE (ceinture & bretelles comme on dit) Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Julien Amsellem <julien.amsellem@unity3d.com>

Merge branch 'master' into vfx/staging

7a4bde9

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

github-actions bot added testing vfx labels Jan 6, 2022

[Fix 1376278] Force read Alive in update when use somewhere else (#302)

bdeb917

* Force read Alive when it's written somewhere * Update changelog * Correct version for changelog Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

Unity-Technologies deleted a comment from github-actions bot Jan 6, 2022

Fix instability increasing threshold of bounds test

e2366ce

Discuss with @ludovic-theobald about this, intentional direct commit to vfx/staging

Unity-Technologies deleted a comment from github-actions bot Jan 7, 2022

Merge branch 'master' into vfx/staging

4ee6a89

Unity-Technologies deleted a comment from github-actions bot Jan 7, 2022

PaulDemeulenaere requested a review from julienf-unity January 7, 2022 15:19

PaulDemeulenaere marked this pull request as ready for review January 7, 2022 15:20

julienf-unity approved these changes Jan 10, 2022

View reviewed changes

Merge branch 'master' into vfx/staging

8419c03

Unity-Technologies deleted a comment from github-actions bot Jan 12, 2022

Merge branch 'master' into vfx/staging

02aa856

Unity-Technologies deleted a comment from github-actions bot Jan 13, 2022

PaulDemeulenaere merged commit 3f97a32 into master Jan 13, 2022

PaulDemeulenaere deleted the vfx/staging branch January 13, 2022 12:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[VFX] Staging to Master #6689

[VFX] Staging to Master #6689

Uh oh!

PaulDemeulenaere commented Jan 6, 2022 •

edited

Loading

Uh oh!

julienf-unity left a comment •

edited

Loading

Uh oh!

PaulDemeulenaere commented Jan 12, 2022

Uh oh!

julienf-unity commented Jan 12, 2022

Uh oh!

PaulDemeulenaere commented Jan 12, 2022

Uh oh!

PaulDemeulenaere commented Jan 12, 2022

Uh oh!

PaulDemeulenaere commented Jan 13, 2022

Uh oh!

Uh oh!

[VFX] Staging to Master #6689

[VFX] Staging to Master #6689

Uh oh!

Conversation

PaulDemeulenaere commented Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

julienf-unity left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PaulDemeulenaere commented Jan 12, 2022

Uh oh!

julienf-unity commented Jan 12, 2022

Uh oh!

PaulDemeulenaere commented Jan 12, 2022

Uh oh!

PaulDemeulenaere commented Jan 12, 2022

Uh oh!

PaulDemeulenaere commented Jan 13, 2022

Uh oh!

Uh oh!

PaulDemeulenaere commented Jan 6, 2022 •

edited

Loading

julienf-unity left a comment •

edited

Loading