Add Overlay Render Queue to Custom Pass #6520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix AxF debug output in certain configurations. * Update comment
* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
sebastienlagarde
approved these changes
Dec 9, 2021
alelievr
approved these changes
Dec 9, 2021
wDohwFwYKI.mp4Verified with Overlay TMP shaders and a custom unlit shader. The solution is not so obvious for common user who just wants an overlay TMP shader, so covering this somewhere in docs would be a good idea i think :) |
JMargevics
approved these changes
Dec 10, 2021
This was referenced Mar 15, 2022
unity-emilk
pushed a commit
that referenced
this pull request
Apr 29, 2022
Backport: #6520 Address case https://fogbugz.unity3d.com/f/cases/1379399/ The original request of this bug report was to add support for the Overlay render queue to HDRP. Since overlay is an invalid render queue range for HDRP's internal draw calls, I instead explored the route of ensuring that the custom pass volume is capable over drawing renderers in this queue. I found that the Draw Renderers Custom Pass did not include the Overlay range, so I added it.
unity-emilk
pushed a commit
that referenced
this pull request
Apr 29, 2022
Backport: #6520 Address case https://fogbugz.unity3d.com/f/cases/1379399/ The original request of this bug report was to add support for the Overlay render queue to HDRP. Since overlay is an invalid render queue range for HDRP's internal draw calls, I instead explored the route of ensuring that the custom pass volume is capable over drawing renderers in this queue. I found that the Draw Renderers Custom Pass did not include the Overlay range, so I added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Address case https://fogbugz.unity3d.com/f/cases/1379399/
The original request of this bug report was to add support for the Overlay render queue to HDRP.
Since overlay is an invalid render queue range for HDRP's internal draw calls, I instead explored the route of ensuring that the custom pass volume is capable over drawing renderers in this queue. I found that the Draw Renderers Custom Pass did not include the Overlay range, so I added it.
We should now support shaders that decide to use the Overlay queue, like TextMeshPro, by utilizing a draw renderers custom pass.
Testing status
I manually used the draw renderers custom pass with overlay queue shaders to verify that they are now correctly drawn.
Comments to reviewers
~