Fix errors when APV debug is on and we switch to an asset that has APV disabled #6483

FrancescoC-unity · 2021-12-06T10:23:52Z

Fix for https://fogbugz.unity3d.com/f/cases/1385066/

The issue was that the debug was still drawn even if the feature is disabled by the pipeline.

What did I test The repro steps

* Fix AxF debug output in certain configurations. * Update comment

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4599)" This reverts commit 2325e3f.

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…positor (#4599)"" This reverts commit 30fffd5.

… the Graphi

…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>

…le (#6296) * Fix * Changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Clarifying something * fix raytraced version Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Disable atmospheric scattering for matcap debug lighting mode * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Always recompute LUT hash when colro curves are overridden * Changelog * Missing tiny part of comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

This reverts commit 4ffd193.

github-actions · 2021-12-06T10:24:07Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

github-actions · 2021-12-06T10:24:19Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

iM0ve

Small fix, testing the repro should be sufficient

pmavridis and others added 30 commits May 26, 2021 19:23

[HDRP] Fix AxF debug output in certain configurations (#4641)

5945333

* Fix AxF debug output in certain configurations. * Update comment

Fix SSR accumulation white flash (#4648)

64a6c13

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Display Info Box when MSAA + ray tracing is onr (#4627)

f49b710

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix distortion when resizing the window in player builds with the Gra…

05cc16a

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Add support for the camera bridge in the graphics compositor (#4599)

2325e3f

Merge branch 'master' into hd/bugfix

c09379f

Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)

b5962c9

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a memory leak related to not disposing of the RTAS at the end H…

77b6b7f

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix custom pass utils Blur + Copy overdraw. (#4623)

bf941a9

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix draw procedural invalid pass idx 1 on first template load (#4632)

806dfbe

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed light reset to preserve type (#4624)

88779ea

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Add support for the camera bridge in the graphics compositor (#…

30fffd5

…4599)" This reverts commit 2325e3f.

AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …

aabbb4b

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Revert "Add support for the camera bridge in the graphics com…

dfdb311

…positor (#4599)"" This reverts commit 30fffd5.

revert: Fix distortion when resizing the window in player builds with…

891fda0

… the Graphi

Merge branch 'master' into hd/bugfix

7b17e06

Merge branch 'master' into hd/bugfix

32df1bf

Fix for discrepancies in saturation and intensity between screen spac…

0032b9c

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (

41716f0

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix VfX lit particle AOV output color space (#4646)

333c800

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Fixed transparent unlit (#4605)

809316c

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

7b1ad29

Fix distortion with MSAA (#4711)

08a578d

Fix contact shadow debug views (#4720)

3c418c0

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update Decal-Projector.md (#4695)

352f65d

[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…

acc5073

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd54a00

Fix decal layer enum (#4753)

1672dc6

Fix typo

c40c5c5

adrien-de-tocqueville and others added 14 commits November 25, 2021 17:52

Fixed camera bridge action in release build (#6313)

40458a5

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>

Fix for shadows disappearing when no dynamic shadow caster is availab…

939e08f

…le (#6296) * Fix * Changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Clarifying something * fix raytraced version Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed directional light height fog attenuation (#6318)

3b92e91

Disable Atmospheric Scattering when Scene Lighting is Disabled (#6328)

0d92f08

* Disable atmospheric scattering for matcap debug lighting mode * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

a524e7d

Use uint as loop variable for directional lights in contact shadows.

558f213

Fix color curves changes not applying immediately in editor (#6322)

8c5fdb8

* Always recompute LUT hash when colro curves are overridden * Changelog * Missing tiny part of comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Test

4ffd193

Revert "Test"

ad00e39

This reverts commit 4ffd193.

Update 112_Reflection_AlternativeSGNodes.png

0a33d81

Merge branch 'master' into hd/bugfix

7b2d354

Update CHANGELOG.md

ddd647b

Do debug only if init and enabled

1c35be0

changelog

72dc3f8

FrancescoC-unity added the HDRP label Dec 6, 2021

FrancescoC-unity requested review from sebastienlagarde, JulienIgnace-Unity and a team December 6, 2021 10:23

FrancescoC-unity self-assigned this Dec 6, 2021

github-actions bot added the SRP label Dec 6, 2021

sebastienlagarde approved these changes Dec 6, 2021

View reviewed changes

sebastienlagarde changed the base branch from hd/bugfix to master December 6, 2021 12:53

Merge branch 'master' into HDRP/fix-apv-debug-mode-breaking

67cceaa

JulienIgnace-Unity approved these changes Dec 6, 2021

View reviewed changes

iM0ve approved these changes Dec 7, 2021

View reviewed changes

Merge branch 'master' into HDRP/fix-apv-debug-mode-breaking

86aecc2

sebastienlagarde merged commit d7651cb into master Dec 14, 2021

sebastienlagarde deleted the HDRP/fix-apv-debug-mode-breaking branch December 14, 2021 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix errors when APV debug is on and we switch to an asset that has APV disabled #6483

Fix errors when APV debug is on and we switch to an asset that has APV disabled #6483

Uh oh!

FrancescoC-unity commented Dec 6, 2021

Uh oh!

github-actions bot commented Dec 6, 2021

Uh oh!

github-actions bot commented Dec 6, 2021

Uh oh!

iM0ve left a comment

Uh oh!

Uh oh!

Fix errors when APV debug is on and we switch to an asset that has APV disabled #6483

Fix errors when APV debug is on and we switch to an asset that has APV disabled #6483

Uh oh!

Conversation

FrancescoC-unity commented Dec 6, 2021

Uh oh!

github-actions bot commented Dec 6, 2021

Uh oh!

github-actions bot commented Dec 6, 2021

Uh oh!

iM0ve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!