Decal Layers (Rendering Layers) #6442

lukaschod · 2021-12-01T14:26:54Z

Purpose of this PR

Changing light layers backend into more general rendering layers

Adding new texture _CameraRenderingLayersTexture into URP that contains screen space rendering layers of meshes.
Adding new class DrawObjectsAndRenderingLayersPass that writes into _CameraRenderingLayersTexture as second render target.
Adding new varation of functionality DepthNormalOnlyPass that allows writing into _CameraRenderingLayersTexture as second render target.
Changing GBuffer to write into _CameraRenderingLayersTexture instead of light layers now.
Added new interanl API for requesting rendering layers ScriptableRendererFeature.RequireRenderingLayers(bool isDeferred, out RenderingLayerUtils.Event atEvent, out RenderingLayerUtils.MaskSize maskSize)

Removing light layers concept from shader backend

Now all logic for comparing layers is done with full rendering layer mask in shaders (C# converts them during the property set). The benefits of this simplifies logic as there is no longer a need to transform rendering layers to light layers when comparing and also avoiding this with decal layers. This should not effect performance as shader always contained them as 32 bit integer. Also this opens a door in the future if we would decide to have rendering layers only in UX side too.

Adding internal API for renderer features to request _CameraRenderingLayersTexture

ScriptableRendererFeature will contain new method internal override bool RequireRenderingLayers(bool isDeferred, out RenderingLayerUtils.Event atEvent, out RenderingLayerUtils.MaskSize maskSize). This will allow URP to know if to produce _CameraRenderingLayersTexture and also at what event. Depending on the event it will be produced either with DepthNormalOnlyPass/DrawObjectPass/GBufferPass.

Decal Layers

Decal Layers implemented with above features and optimized for tiled-renderers. In case of DBuffer DepthNormalOnlyPass used for rendering layers. For Screen Space Forward ForwardOpaquePass provides it and for deferred GBuffer provides it.

New Decal Layers option to control its support in renderer feature:

New property in Decal Projector to specify Decal Layer it belongs to:

Testing status

Tested locally on simple project combinations of DecalLayer/LightLayer/Forward/Deferred/NativeRenderPass/GameView/SceneView/ScreenSpaceDecal/DBuffer/DepthNormalPass.
Added automated test 250 to test Rendering Layers. Basically render rendering layer at specific events.
Green ABV.
Regression Test.

Tiny Presentation

https://docs.google.com/presentation/d/12FzT-Kec55c2IdIXXH24nkI7Ksmb7tzDGWLSDdAcflk/edit#slide=id.g11145254bef_0_43

Technical Design Document

https://docs.google.com/document/d/1Vw6VkHaJkgwwi2_Rv_a98241OaFHsKtm72KuJsIGnJc/edit#

Comments to reviewers

Currently there is idea for removing decal and light layers and keeping only rendering layers for UX too (There is more info in TDD).

github-actions · 2021-12-01T14:27:15Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

lukaschod · 2021-12-08T12:31:42Z

com.unity.render-pipelines.universal/Editor/Decal/DecalPass.template

@@ -63,7 +63,9 @@ Pass
    #endif
    #if _RENDER_PASS_ENABLED
    #define GBUFFER3 0


Need better way to specify inputs

…dering layers

…nsistency

…of passes

…ers changes

…endering Layers Utils for that

…ternal API

…ogic only in C# side

…nal with render layers

lukaschod · 2022-02-08T15:32:23Z

com.unity.render-pipelines.universal/ShaderLibrary/ShaderVariablesFunctions.hlsl

+float EncodeMeshRenderingLayer(uint renderingLayer)
+{
+    // TODO: Expose as property for the size
+    return PackInt(renderingLayer, 16);


I am guessing adding propery that controls size is the best approach here

lukaschod · 2022-02-08T16:34:50Z

com.unity.render-pipelines.universal/Runtime/DeferredLights.cs

@@ -153,21 +153,27 @@ internal GraphicsFormat GetGBufferFormat(int index)
            else if (index == GBufferShadowMask) // Optional: shadow mask is outputed in mixed lighting subtractive mode for non-static meshes only
                return GraphicsFormat.R8G8B8A8_UNorm;
            else if (index == GBufferRenderingLayers) // Optional: rendering layers is outputed when light layers are enabled (subset of rendering layers)
-                return GraphicsFormat.R8_UNorm;
+                return GraphicsFormat.R16_UNorm;


This needs to be controllable

sebastienlagarde · 2022-02-08T16:43:46Z

com.unity.testing.urp/Scripts/Runtime/DrawRenderingLayers.shader

+            #pragma vertex FullscreenVert
+            #pragma fragment Fragment
+            #pragma multi_compile _ _USE_DRAW_PROCEDURAL
+            #pragma enable_d3d11_debug_symbols


don't forget to comment this enable_d3d11_debug_symbols

…universal/decal-layers # Conflicts: # com.unity.render-pipelines.universal/Editor/GlobalSettings/UniversalRenderPipelineGlobalSettingsUI.Skin.cs # com.unity.render-pipelines.universal/Runtime/Decal/DBuffer/DBufferRenderPass.cs # com.unity.render-pipelines.universal/Runtime/Passes/ScriptableRenderPass.cs # com.unity.render-pipelines.universal/Runtime/RendererFeatures/DecalRendererFeature.cs # com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs

kaychang-unity · 2022-02-10T14:16:42Z

Does ShaderPreprocessor.cs needs to be updated to strip out _WRITE_RENDERING_LAYERS ?

lukaschod · 2022-02-23T08:20:01Z

Does ShaderPreprocessor.cs needs to be updated to strip out _WRITE_RENDERING_LAYERS ?

Updated

com.unity.render-pipelines.universal/Shaders/Lit.shader

…universal/decal-layers # Conflicts: # TestProjects/UniversalGraphicsTest_Foundation/Assets/CommonAssets/UniversalRPAsset.asset # TestProjects/UniversalGraphicsTest_Foundation/ProjectSettings/EditorBuildSettings.asset # com.unity.render-pipelines.universal/Editor/ShaderGraph/Targets/UniversalUnlitSubTarget.cs # com.unity.render-pipelines.universal/Runtime/Passes/DrawObjectsPass.cs # com.unity.render-pipelines.universal/Runtime/Passes/GBufferPass.cs

rbechoe · 2022-05-18T09:31:02Z

Was this ever fully implemented into Unity? I can't find it in the 2021 version(s).

lukaschod changed the base branch from universal/staging to master December 1, 2021 15:29

sebastienlagarde added the universal label Dec 2, 2021

lukaschod added 2 commits December 3, 2021 12:09

Adding rendering layers and decal layers

a987d96

Adding test 250 for rendering layers

4190446

lukaschod force-pushed the universal/decal-layers branch from 72083d9 to 4190446 Compare December 3, 2021 10:11

lukaschod added 5 commits December 3, 2021 12:53

Updating test scene 250 with rt handles and naming

e4bf40d

Updating new blit overload to use rt handles

e000618

Cleaning up dbufer

cef454a

Cleanup

d1bf08c

Changing test 250 background to black

51d7c31

lukaschod commented Dec 8, 2021

View reviewed changes

lukaschod added 16 commits January 4, 2022 15:56

Fixing light layers to work correctly then they are disabled with ren…

1a88b7b

…dering layers

Adding decal layers UI into urp global settings

e4caba5

Refactoring naming from decal layers to write rendering layers for co…

3584d7b

…nsistency

Renaming _CameraDecalLayersTexture to _CameraRenderingLayersTexture

7dba034

Moving rendering layer texture setting to universal renderer instead …

cd713d3

…of passes

Adding decode mesh rendering layer

6aac67d

Adding ResetTarget to ScriptableRenderPass it is needed for decal lay…

dc5f8ac

…ers changes

Cleanup

8c52bc8

Removing Rendering Layers request from render pass input and adding R…

5a9c01f

…endering Layers Utils for that

Moving DrawRenderingLayersFeature into urp test library as it uses in…

2264c74

…ternal API

Updating Scene

0bf1c22

Adding reference images for test 250

27c6eb3

Removing light layers and decal layers from shader side and keeping l…

18fedc9

…ogic only in C# side

Updating for deferred light layer mask

13f668e

Spliting draw object pass logic into old draw object pass and additio…

6d18365

…nal with render layers

Cleanup

e832df4

lukaschod commented Feb 8, 2022

View reviewed changes

lukaschod changed the title ~~Universal/decal layers~~ Decal Layers (Rendering Layers) Feb 8, 2022

lukaschod requested review from phi-lira and kaychang-unity February 8, 2022 16:25

lukaschod commented Feb 8, 2022

View reviewed changes

sebastienlagarde reviewed Feb 8, 2022

View reviewed changes

lukaschod added 5 commits February 9, 2022 09:18

Adding scene 250 into editor build settings

f4f8d6e

Manual fix after merge

aa8930b

Fixing forward emissive to work with decal layers

212a5af

Removing accidental commit

41bf05b

lukaschod added 3 commits February 22, 2022 10:19

Removing decal layers from gl and fixing emissive

8b27fcb

Adding reference images for vulkan

18a4e2f

Adding rending layer size controlling

bc6bb27

ernestasKupciunas self-requested a review February 23, 2022 07:16

lukaschod added 3 commits February 23, 2022 09:54

Cleanup

b8258c2

Adding comment

9478028

Update reference images and renderers of test 250

2c3d2fa

Adding rendering layers to simple lit, unlit sg, lit sg

78332e2

lukaschod marked this pull request as ready for review February 23, 2022 10:28

lukaschod requested a review from a team as a code owner February 23, 2022 10:28

kaychang-unity approved these changes Feb 23, 2022

View reviewed changes

com.unity.render-pipelines.universal/Shaders/Lit.shader Show resolved Hide resolved

lukaschod added 5 commits March 10, 2022 12:16

Fixing webgl and simple lit for decal layers

10db83b

Removing accidental debug pragma

7e12ae0

Fixing decal layer pack and upack to work correctly for mobile variants

d1bbebb

Leftover

8eb97e9

memphis88 force-pushed the master branch from 7a67a14 to 74326b1 Compare August 13, 2024 18:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Decal Layers (Rendering Layers) #6442

Decal Layers (Rendering Layers) #6442

lukaschod commented Dec 1, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2021 •

edited

Loading

Uh oh!

lukaschod Dec 8, 2021

Uh oh!

lukaschod Feb 8, 2022

Uh oh!

lukaschod Feb 8, 2022

Uh oh!

sebastienlagarde Feb 8, 2022

Uh oh!

kaychang-unity commented Feb 10, 2022

Uh oh!

lukaschod commented Feb 23, 2022

Uh oh!

Uh oh!

rbechoe commented May 18, 2022

Uh oh!

Uh oh!

Decal Layers (Rendering Layers) #6442

Are you sure you want to change the base?

Decal Layers (Rendering Layers) #6442

Conversation

lukaschod commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Changing light layers backend into more general rendering layers

Removing light layers concept from shader backend

Adding internal API for renderer features to request _CameraRenderingLayersTexture

Decal Layers

Testing status

Tiny Presentation

Technical Design Document

Comments to reviewers

Uh oh!

github-actions bot commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukaschod Dec 8, 2021

Choose a reason for hiding this comment

Uh oh!

lukaschod Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

lukaschod Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

sebastienlagarde Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

kaychang-unity commented Feb 10, 2022

Uh oh!

lukaschod commented Feb 23, 2022

Uh oh!

Uh oh!

rbechoe commented May 18, 2022

Uh oh!

Uh oh!

lukaschod commented Dec 1, 2021 •

edited

Loading

github-actions bot commented Dec 1, 2021 •

edited

Loading