Skip to content

[2021.2][VFX][Fix 1355602] Extra nodes in Ribbon template #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ludovic-theobald
Copy link
Contributor

@ludovic-theobald ludovic-theobald commented Nov 8, 2021

[2021.2][VFX][Fix 1355602] Extra nodes in Ribbon template

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

This is the backport of this PR : #6238

# Conflicts:
#	com.unity.visualeffectgraph/CHANGELOG.md
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the vfx label Nov 8, 2021
@ludovic-theobald ludovic-theobald marked this pull request as ready for review November 10, 2021 15:00
@ludovic-theobald ludovic-theobald merged commit 0da0094 into 2021.2/staging Nov 10, 2021
@ludovic-theobald ludovic-theobald deleted the 2021.2/vfx/fix/1355602-useless-ribbon-nodes branch November 10, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants