Skip to content

Various ray tracing fixes #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Various ray tracing fixes #6199

merged 3 commits into from
Nov 5, 2021

Conversation

anisunity
Copy link
Contributor

The solution used for fixing the shader graph compilation errors was to used a different implementation for ray tracing that doesn't rely on derivatives.

Testing Status
Added a tests for the problematic shader graph nodes.

…ckerboard, RoundedPolygon, RoundedRectangle in a ray tracing shader graph (case 1377610).

- Fixed outdated documentation about supported GPUs for ray tracing (case 1375895).
- Fixed outdated documentation about recursie ray tracing effects support (case 1374904).
@anisunity anisunity self-assigned this Nov 4, 2021
@anisunity anisunity marked this pull request as ready for review November 4, 2021 10:31
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened the new tests to made sure everything was correct. Also tried pathtracer to make sure it's also working fine. ✔️
Thanks a lot for adding it.

The rest of the changes are trivial but still much appreciated !

Copy link

@cdxntchou cdxntchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants