-
Notifications
You must be signed in to change notification settings - Fork 840
Various ray tracing fixes #6199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ckerboard, RoundedPolygon, RoundedRectangle in a ray tracing shader graph (case 1377610). - Fixed outdated documentation about supported GPUs for ray tracing (case 1375895). - Fixed outdated documentation about recursie ray tracing effects support (case 1374904).
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Shader Graph Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened the new tests to made sure everything was correct. Also tried pathtracer to make sure it's also working fine. ✔️
Thanks a lot for adding it.
The rest of the changes are trivial but still much appreciated !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
https://fogbugz.unity3d.com/f/cases/1377610/
https://fogbugz.unity3d.com/f/cases/1375895/
https://fogbugz.unity3d.com/f/cases/1374904/
The solution used for fixing the shader graph compilation errors was to used a different implementation for ray tracing that doesn't rely on derivatives.
Testing Status
Added a tests for the problematic shader graph nodes.