Skip to content

[HDRP] Fix linux vulkan tests #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

alelievr
Copy link
Member

@alelievr alelievr commented Oct 20, 2021

Purpose of this PR

Fix linux vulkan tests.
This PR was the cause of the issue: #5918. It triggered an error on yamato because we moved the compatibility check in HDRP, causing the shaders to load even on VMs that don't have GPU

@github-actions github-actions bot added the sdet label Oct 20, 2021
@alelievr alelievr marked this pull request as ready for review October 20, 2021 17:16
@alelievr alelievr requested a review from a team as a code owner October 20, 2021 17:16
@sebastienlagarde
Copy link
Contributor

Merging to get green Yamato

@sebastienlagarde sebastienlagarde merged commit 0994ab8 into master Oct 20, 2021
@sebastienlagarde sebastienlagarde deleted the hd/fix/linux-vulkan-shader-errors branch October 20, 2021 19:38
sebastienlagarde pushed a commit that referenced this pull request Oct 21, 2021
* Try to fix linux vulkan tests

* Try fix linux config
sebastienlagarde added a commit that referenced this pull request Oct 21, 2021
* [HDRP] Fix linux vulkan tests (#6086)

* Try to fix linux vulkan tests

* Try fix linux config

* Generate yamls

Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Théo Penavaire <theo.penavaire@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants