[HDRP] Fix the injection point field not visible in custom pass volumes #6084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
JMargevics
approved these changes
Oct 20, 2021
sebastienlagarde
approved these changes
Oct 20, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Oct 21, 2021
…es (#6084) * Fix custom pass injection point not visible when using the Camera mode. * updated changelog
sebastienlagarde
added a commit
that referenced
this pull request
Oct 21, 2021
* APV: update some tooltips and add a clamp on dilation validity threshold (#6005) * Tooltip and dilation thresh clamp * More tooltip grammar * Small qol (#6036) * Fix subdiv view (#6033) * ** Improving FTPL perf on ps4 by .3 ms on average ** (#5866) * Adding FPTL caching of light volume, adding new conditional for early out of loop and forcing loop to be dynamic * Early out on the wave itself if we find at least 1 valid light, saves additional 0.05ms * Fixing some compiler warnings * Update to HDRP Asset analytics (#6060) * Updated HDRP analytics - New version of hdrp usage to better analyse data - Default values event to populate default values for the dashboard * Fixed menu item * Enable iris normal for Eye shader (#5880) * Enable Iris normal for Eye shader * categories * update eye sample Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix errors when switching build targets in editor #5918 * [HDRP] Change RenderGraph Begin/Execute function pattern to avoid leaks (#5929) * Fix render graph not being executed when an exception is thrown from the graph recording * Cleanup + doc * Fix iridescence tooltip (#5950) * Fix tooltip * Update Material-Type.md * Update iridescence-thickness.md * Update LitSurfaceInputsUIBlock.cs * Layer drawer used in ray/path tracing now matches 100% with camera's. (#5956) Please enter the commit message for your changes. Lines starting * [HDRP][Docs] Update docs with RendererList related option (#6031) * Update docs with RendererList related option * Minor edit * [HDRP][Path Tracing] Added proper support for interleaved tiling (#5953) * Added ortho cam support, plus raygen refactor. * Added support for interleaved tiling. * Added spread angle adjustment. * Offset tile sub-pixels, instead of relying on proj matrix modifications. * Undoed last commit. * Use tiled pixel coords for all things sampling-related (incl. lens). * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renable missing test (Lens Flare) (#5456) * Renable missing test (Lens Flare) * Update references images for 4092 Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [HDRP][Path Tracing] Camera ray misses now return a null value with Minimum Depth > 1 #6067 * [HDRP][Path Tracing] Improved robustness of the stacklit material (#6066) * Improved robustness of the stacklit material. * Updated changelog. * Changed coat normal sample texture from default to normal * add 5007 stacklit test scene for PT * added scene to build settings Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed grammar errors (#6077) * Fix division by 0 when AO is 0 (#6078) * [HDRP] Fix the injection point field not visible in custom pass volumes (#6084) * Fix custom pass injection point not visible when using the Camera mode. * updated changelog Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix the injection point field not being visible when using the camera mode in custom pass volumes.
Testing status
Before:
After:
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/hd%252Ffix%252Fcustom-pass-injection-point/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk/9472525/job