Skip to content

[HDRP] Backport various PRs #6081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 21, 2021
Merged

[HDRP] Backport various PRs #6081

merged 18 commits into from
Oct 21, 2021

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Oct 20, 2021 •
edited
Loading

Purpose of this PR

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

FrancescoC-unity and others added 17 commits October 20, 2021 14:43
@FrancescoC-unity @sebastienlagarde
APV: update some tooltips and add a clamp on dilation validity thresh…
37f7366 
…old (#6005)

* Tooltip and dilation thresh clamp

* More tooltip grammar
@FrancescoC-unity @sebastienlagarde
Small qol (#6036)
feeb79d
@FrancescoC-unity @sebastienlagarde
Fix subdiv view (#6033)
9722ed9
@kecho @sebastienlagarde
** Improving FTPL perf on ps4 by .3 ms on average ** (#5866)
f358127 
* Adding FPTL caching of light volume, adding new conditional for early out of loop and forcing loop to be dynamic

* Early out on the wave itself if we find at least 1 valid light, saves additional 0.05ms

* Fixing some compiler warnings
@JulienIgnace-Unity @sebastienlagarde
Update to HDRP Asset analytics (#6060)
86cd23a 
* Updated HDRP analytics

- New version of hdrp usage to better analyse data
- Default values event to populate default values for the dashboard

* Fixed menu item
@adrien-de-tocqueville @sebastienlagarde
Enable iris normal for Eye shader (#5880)
fe0eacd 
* Enable Iris normal for Eye shader

* categories

* update eye sample

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@alelievr @sebastienlagarde
[HDRP] Fix errors when switching build targets in editor #5918
520f465
@alelievr @sebastienlagarde
[HDRP] Change RenderGraph Begin/Execute function pattern to avoid lea…
77da431 
…ks (#5929)

* Fix render graph not being executed when an exception is thrown from the graph recording

* Cleanup + doc
@sebastienlagarde
Fix iridescence tooltip (#5950)
231f6f6 
* Fix tooltip

* Update Material-Type.md

* Update iridescence-thickness.md

* Update LitSurfaceInputsUIBlock.cs
@eturquin @sebastienlagarde
Layer drawer used in ray/path tracing now matches 100% with camera's. (…
6b07ebb 
…#5956)

Please enter the commit message for your changes. Lines starting
@pmavridis @sebastienlagarde
[HDRP][Docs] Update docs with RendererList related option (#6031)
9880950 
* Update docs with RendererList related option

* Minor edit
@eturquin @sebastienlagarde
[HDRP][Path Tracing] Added proper support for interleaved tiling (#5953)
3199087 
* Added ortho cam support, plus raygen refactor.

* Added support for interleaved tiling.

* Added spread angle adjustment.

* Offset tile sub-pixels, instead of relying on proj matrix modifications.

* Undoed last commit.

* Use tiled pixel coords for all things sampling-related (incl. lens).

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@skhiat @sebastienlagarde
Renable missing test (Lens Flare) (#5456)
1c753f9 
* Renable missing test (Lens Flare)

* Update references images for 4092

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
@eturquin @sebastienlagarde
[HDRP][Path Tracing] Camera ray misses now return a null value with M…
98bce4f 
…inimum Depth > 1 #6067
@eturquin @remi-chapelain @sebastienlagarde
[HDRP][Path Tracing] Improved robustness of the stacklit material (#6066
a9cb023 
)

* Improved robustness of the stacklit material.

* Updated changelog.

* Changed coat normal sample texture from default to normal

* add 5007 stacklit test scene for PT

* added scene to build settings

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@emilybrown1 @sebastienlagarde
Fixed grammar errors (#6077)
fcc5dc2
@adrien-de-tocqueville @sebastienlagarde
Fix division by 0 when AO is 0 (#6078)
b19b5fd
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde changed the title [HDRP] Backport various PRsjulien [HDRP] Backport various PRs Oct 20, 2021
@alelievr @sebastienlagarde
[HDRP] Fix the injection point field not visible in custom pass volum…
76eec04 
…es (#6084)

* Fix custom pass injection point not visible when using the Camera mode.

* updated changelog
@sebastienlagarde sebastienlagarde merged commit df69e39 into 2021.2/staging Oct 21, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/backport-misc-21-2-bias branch October 21, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienIgnace-Unity JulienIgnace-Unity Awaiting requested review from JulienIgnace-Unity

Assignees
No one assigned
Labels
HDRP SRP testing vfx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sebastienlagarde @FrancescoC-unity @kecho @JulienIgnace-Unity @adrien-de-tocqueville @alelievr @eturquin @pmavridis @skhiat @emilybrown1