[VFX] Staging to Master #6048

PaulDemeulenaere · 2021-10-18T10:06:36Z

Purpose of this PR

Most of these changes are already in 21.2, vfx/staging is a bit ahead master (see #5709)

Changed

Added missing nodes for Attribute>Curve and added a new category level #282 @julienamsellem New ⭐

Fixed

SDF Baker on PS4/5 failing due to explicit binding #278 @ludovic-theobald
Fix particles showing pink when cascade shadows debug mode is enabled #272 @ludovic-theobald
Remove bool from the built-in list of blittable types #276 @gabrieldelacruz
Extract position from a transform is wrong on GPU #274 @PaulDemeulenaere
Fix potentially invalid value for pixel dimensions in HDRPCameraBinder #277 @gabrieldelacruz
Fix sanitize of exposed Camera parameters #275 @gabrieldelacruz
Fix NRE with attachment workflow #279 @julienamsellem
Fix GPUEVent & Spawn FlowLink #283 @PaulDemeulenaere New ⭐

Testing status

Yamato 🟢
Yamato internal 🟠 (It will require an update PR for 31_CameraBuffer)

Comments to reviewers

I manually graft the change fe2edd6 to fix test in edit mode

* Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code * Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this * Update CHANGELOG.md

* Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui * Prevent list from being badly deserialized.

* Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment

* Vfx/feature/strips improvements (#265) * Add spanwIndexInStrip attribute * Fix particleCountInStrip in Init * Add OrientStrip block * Remove some useless code * Add From Target Position mode in Orient Strip * Update changelog * Fix SpawnOverDistance * Fix reference images * Fix changelog * Merge Orient and OrientStrip blocks * Remove FaceCameraPlane from strips * Sanitize quad strip orientation * Update VFX * Update changelog * Add error feedback * Use IsPerspectiveProjection * Fix GetStripTangent for lines * Add subpixel AA to head and trails template system * Add strip variant for intialize in menu * Fix for errors not appearing after convert output * Update graph version * Fix ribbon VFX * Fix spawnIndexInStrip (tooltip + init) * Fix issue with inspector not triggering OnSettingChanged * Check that a converted output could keep the same flow links. Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Updated Changelog * Updated Blocks with Fixes and Missing Workflows * update VFX additions Co-authored-by: Thomas Iché <peeweek@gmail.com>

…put Particle Mesh / Connected Attributes (#139) * Reindex the TEXCOORD[n] * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com>

Fix issue #1131 (comment) Fix issue #1131 (comment) Fix issue #1131 (comment)

* Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Fix regression with subgraph * Add Subgraph_Event_Link_To_Spawn editor test

Add entry in the right place from 0009e53

…t to 10.x.x)

* Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md

…158)

* do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation

…n the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro

# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

* Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/TestCaseFilters.asset # com.unity.visualeffectgraph/CHANGELOG.md # com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs

This reverts commit 8430521.

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/TestCaseFilters.asset # com.unity.visualeffectgraph/CHANGELOG.md # com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs

#282) * Added missing nodes for Attribute>Curve and added a new category level * Reorganize block nodes in the search filter window Put first the attribute and then the composition to make it easier to find expected block. * Improved VFXLibrary perfs to absorb the cost of new variants Simplified a bit how names are displayed (removed "path") Optimized a few loops and property accessor Prevent some useless UI stuff to be triggered while build the VFXLibrary * Made the new Variant class a bit more generic * Fixed missing call to invalidate when instancing blocks * Fixed missing some inline operators * Moved all "set position" to "value/set" * Include the sample mode in the name of map nodes * Added more composition for custom attribute Also changed the name of the operator so it's more consistend with other attributes * Set attribute with Uniform sample mode was duplicated * Applied code review comments * Renamed "Value" category to "Composition" * Added a change log entry

* Fix incorrect condition for GPUEvent Mistake introduced at #4457 * *Add some editorTest * Add some test to covers corners case See https://unity.slack.com/archives/G1BTWN88Z/p1632919330247400 * *WIP* Improve incorrect connection handling * Fix multiple type in output of initialize part * Fix Update to Update which is actually allowed * *Update changelog.md * Fix missing case for VFX.Update tyep * Rename confusing "primaryType"

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

Mainly due to this PR #5646

We renabled this test on vfx/staging but the background color is slighlty different

PaulDemeulenaere · 2021-10-22T07:03:23Z

com.unity.render-pipelines.universal/Runtime/VFXGraph/Shaders/VFXDefines.hlsl

+#define CameraBuffer Texture2D
+#define VFXSamplerCameraBuffer VFXSampler2D
+#endif
+


FYI, this is a fix compilation from fogbugz: https://fogbugz.unity3d.com/f/cases/1357025/
https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/273 (cc @gabrieldelacruz)

Verasl

LGTM

iTris666 and others added 30 commits October 28, 2020 11:38

Small fix for collapse test

b8212d0

Some extra security around error feedback (#153)

182437a

* Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui * Prevent list from being badly deserialized.

Fix Event connected directly to Output Event (#152)

adaeba7

* Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment

Revert adaeba7

024dcbf

update vfx

3801a89

Update URP assets

20a4672

Update URP ref

61b8375

Merge remote-tracking branch 'graphics/master' into vfx/staging

f6ee116

Merge remote-tracking branch 'graphics/master' into vfx/staging

818adb6

Vfx/fix/additional subgraphs 2 (#155)

ef6eeaf

* Updated Changelog * Updated Blocks with Fixes and Missing Workflows * update VFX additions Co-authored-by: Thomas Iché <peeweek@gmail.com>

Fix 1255182 Compile errors using Baked GI (default UV settings) / Out…

15df881

…put Particle Mesh / Connected Attributes (#139) * Reindex the TEXCOORD[n] * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com>

Fix serveral minor issues (#103)

fe924b0

Fix issue #1131 (comment) Fix issue #1131 (comment) Fix issue #1131 (comment)

Update rebuild all script to take subgraph into account

5e1b25c

Update VFX assets

dedb913

Fix URP vfx assets

1e7ae1b

Merge remote-tracking branch 'graphics/master' into vfx/staging

249de48

Merge remote-tracking branch 'graphics/master' into vfx/staging

4a0458e

Fix Event connected directly to Output Event (revival) (#154)

0009e53

* Add missing filter in CanLink function * Add editor test * *Update changelog.md * *Update comment * *Update Comment * Fix regression with subgraph * Add Subgraph_Event_Link_To_Spawn editor test

Fix changelog

ee55b98

Add entry in the right place from 0009e53

Restore disabled 26_NonUnifomScale due to a wrong merge (need backpor…

f181b2d

…t to 10.x.x)

[HDRP] Fix debug view material (albedo/normal/...) (#163)

0c4cf10

* Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md

Force ui update when shader might be reimported in StaticMeshOutput (#…

981e074

…158)

Don't create VFXGraph during import callbacks (#148)

1443b7d

* do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation

Add the necessary openasset callback for the system to know if we ope…

47ce7f8

…n the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro

Merge branch 'master' into vfx/staging

960eea5

# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

Merge remote-tracking branch 'graphics/master' into vfx/staging

0a7f877

“Refactor”

1f63413

julienamsellem and others added 9 commits September 23, 2021 13:44

Merge branch 'master' into vfx/staging

8430521

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/TestCaseFilters.asset # com.unity.visualeffectgraph/CHANGELOG.md # com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs

Revert "Merge branch 'master' into vfx/staging"

1b84027

This reverts commit 8430521.

Merge branch 'master' into vfx/staging

ab60f85

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/TestCaseFilters.asset # com.unity.visualeffectgraph/CHANGELOG.md # com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs

Fix changelog.md ordering (and move everything to 13.x.x)

a0b5bdc

Fix failing test

fe2edd6

Merge branch 'master' into vfx/staging

2ded9f3

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

Fix changelog ordering

1cb5d74

github-actions bot added HDRP testing universal vfx labels Oct 18, 2021

Unity-Technologies deleted a comment from github-actions bot Oct 18, 2021

Fix formatting

5151080

Unity-Technologies deleted a comment from github-actions bot Oct 18, 2021

PaulDemeulenaere added 2 commits October 18, 2021 14:01

*Update all vfx

96a3a41

Mainly due to this PR #5646

*Update image reference for 31_CameraBuffer

a6e9711

We renabled this test on vfx/staging but the background color is slighlty different

Unity-Technologies deleted a comment from github-actions bot Oct 18, 2021

PaulDemeulenaere requested a review from julienf-unity October 18, 2021 15:38

PaulDemeulenaere marked this pull request as ready for review October 19, 2021 07:21

PaulDemeulenaere requested review from a team as code owners October 19, 2021 07:21

julienf-unity approved these changes Oct 20, 2021

View reviewed changes

PaulDemeulenaere commented Oct 22, 2021

View reviewed changes

Verasl approved these changes Oct 22, 2021

View reviewed changes

phi-lira approved these changes Oct 22, 2021

View reviewed changes

PaulDemeulenaere merged commit 84569f3 into master Oct 22, 2021

PaulDemeulenaere deleted the vfx/staging branch October 22, 2021 10:04

Wilfrid-Unity restored the vfx/staging branch December 6, 2021 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[VFX] Staging to Master #6048

[VFX] Staging to Master #6048

Uh oh!

PaulDemeulenaere commented Oct 18, 2021 •

edited

Loading

Uh oh!

PaulDemeulenaere Oct 22, 2021

Uh oh!

Verasl left a comment

Uh oh!

Uh oh!

[VFX] Staging to Master #6048

[VFX] Staging to Master #6048

Uh oh!

Conversation

PaulDemeulenaere commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

PaulDemeulenaere Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

Verasl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PaulDemeulenaere commented Oct 18, 2021 •

edited

Loading