Add -cacheServerWaitForUploadCompletion argument #6024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
kivistikliis
approved these changes
Oct 15, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Hopefully reduce the number of instabilities, especially on osx and linux, by adding a new argument for the cache server.
Also moved "cacheServerNamespacePrefix" to the start of the list so that it's easier to edit in the yamato box.
Testing status
Will be hard to test given it's supposed to reduce instabilities.
Let's just check it doesn't break anything by running the safety net, and we will assess the usefulness of this PR over the next weeks, depending on if we see still this issue or not.