Skip to content

Remove ScreenSpaceShadowResolvePass #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

Remove ScreenSpaceShadowResolvePass #6002

merged 1 commit into from
Oct 20, 2021

Conversation

Seongdae
Copy link
Contributor

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Remove unnsed ScreenSpaceShadowResolvePass,

I suggest you to remove it, because that wasn't used anymore.

Testing status

Comments to reviewers

@Seongdae Seongdae requested review from ellioman and phi-lira October 13, 2021 08:41
@Seongdae Seongdae self-assigned this Oct 13, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Seongdae
Copy link
Contributor Author

https://github.com/Unity-Technologies/Graphics/blob/urp/removeScreenSpaceShadowResolvePass/com.unity.render-pipelines.universal/Runtime/UniversalRenderPipelineCore.cs#L226

@phi-lira @ellioman It was obsolete now, can I remove it?

@phi-lira phi-lira marked this pull request as ready for review October 15, 2021 09:25
@phi-lira phi-lira requested review from a team as code owners October 15, 2021 09:25
@Seongdae
Copy link
Contributor Author

@phi-lira I wonder if this value should be remove in this PR? 'public bool requiresScreenSpaceShadowResolve;'

@Seongdae Seongdae added the ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV label Oct 20, 2021
@Seongdae Seongdae merged commit c6c96d6 into master Oct 20, 2021
@Seongdae Seongdae deleted the urp/removeScreenSpaceShadowResolvePass branch October 20, 2021 00:35
odbb added a commit that referenced this pull request Oct 20, 2021
@odbb
Merge branch 'master' into adaptive-performance/add-decals-scaler
095a1de 
* master:
  Add missing shader stages in shader keyword copying  (#6008)
  [Yamato] Add all DX11 job for URP (#6075)
  [HDRP] Add more performance test coverage (#5814)
  Fix templates ISO date (#6073)
  Fix division by 0 when AO is 0 (#6078)
  Fixed grammar errors (#6077)
  [HDRP][Path Tracing] Improved robustness of the stacklit material (#6066)
  [APV] Cell streaming system (#5731)
  Update revision for URP update test project (#6061)
  [HDRP][Path Tracing] Camera ray misses now return a null value with Minimum Depth > 1 (#6067)
  Renable missing test (Lens Flare) (#5456)
  [HDRP][Path Tracing] Added proper support for interleaved tiling (#5953)
  Fix to render depth or depth/normal of waving grass (#4097)
  Remove ScreenSpaceShadowResolvePass (#6002)
  [HDRP][Docs] Update docs with RendererList related option (#6031)
  Layer drawer used in ray/path tracing now matches 100% with camera's. (#5956)
  Fix iridescence tooltip (#5950)
  [HDRP] Change RenderGraph Begin/Execute function pattern to avoid leaks (#5929)
  [HDRP] Fix errors when switching build targets in editor (#5918)
  Generate a material as a subasset for ShaderGraphs (#5795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

@phi-lira phi-lira phi-lira approved these changes

Assignees

@Seongdae Seongdae

Labels
ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seongdae @ellioman @phi-lira