Skip to content

Fix URP blending modes and separate preserve specular lighting feature. #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Oct 26, 2021
Merged

Fix URP blending modes and separate preserve specular lighting feature. #5762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
d7406d7
Blend Test, Unlit, Simple Lit blending.
eh-unity Sep 17, 2021
a5c9aee
Move alpha modulate to match "premultiplied" manual authoring.
eh-unity Sep 17, 2021
ed1c2f4
Reduce keywords.
eh-unity Sep 20, 2021
077b1b6
Lit blending fixes + clean up.
eh-unity Sep 20, 2021
d70b155
Shadergraph blending & preserve spec fixes.
eh-unity Sep 21, 2021
ba28483
Update test scene.
eh-unity Sep 21, 2021
d058838
Graph allow override test and fix.
eh-unity Sep 21, 2021
90932aa
Fix tests, update change log.
eh-unity Sep 22, 2021
b5c2636
Add blend test platform ref images.
eh-unity Sep 22, 2021
76b6993
Change multiply blend mode alpha to keep dst instead of multiply.
eh-unity Sep 23, 2021
676c2fc
Update change log.
eh-unity Sep 23, 2021
0ea68c1
Update Images.
eh-unity Sep 23, 2021
540a06a
Fix Lit graph Preserve Spec GUI.
eh-unity Sep 23, 2021
ab75fff
Update d3d ref images.
eh-unity Sep 23, 2021
49c9cf7
Hide "Preserve Spec" button when not available.
eh-unity Sep 24, 2021
acceb27
Use HDR for test output image.
eh-unity Sep 24, 2021
be28dfa
Reset ref images to match expectations for new test result settings.
eh-unity Sep 24, 2021
f220123
Move AlphaModulate into it's own function.
eh-unity Sep 24, 2021
afef527
Update ref pics.
eh-unity Sep 24, 2021
c52b07b
Refactor AlphaModulate for PBRForwardPass.
eh-unity Sep 27, 2021
9c08496
Add material upgrader for blend modes.
eh-unity Sep 28, 2021
6883152
Allow material upgrades for (overridable) shadergraph materials.
eh-unity Sep 30, 2021
07596eb
Fix blend specular graph UI.
eh-unity Oct 1, 2021
3054df0
Add upgrade path for UniversalLit graph target settings.
eh-unity Oct 1, 2021
d1fe0b0
Add updated materials.
eh-unity Oct 4, 2021
7cb6f85
Fix Preserve Spec for ParticleLit.
eh-unity Oct 4, 2021
08ab61f
Fix more manually updated materials.
eh-unity Oct 5, 2021
9bca6da
Review improvements.
eh-unity Oct 5, 2021
f58b30d
Improve upgrader comment.
eh-unity Oct 6, 2021
26a5dd4
Merge branch 'master' into universal/fix-premultiplied-alpha-resurrect
eh-unity Oct 6, 2021
a199a64
Merge branch 'master' into universal/fix-premultiplied-alpha-resurrect
eh-unity Oct 7, 2021
2421ed8
Switch the blending test to use the backbuffer.
eh-unity Oct 7, 2021
b41b273
Update ref images to match backbuffer rendering.
eh-unity Oct 8, 2021
ea05278
Disable XR compatibility due to minor test artifact causing either XR…
eh-unity Oct 8, 2021
74b0c67
ref pic.
eh-unity Oct 8, 2021
4be90f5
Bump wait frames so that indirect light gets baked on all platforms.
eh-unity Oct 8, 2021
40751cc
Revert "Disable XR compatibility due to minor test artifact causing e…
eh-unity Oct 8, 2021
f31820c
Clamp source textures, solid color background.
eh-unity Oct 8, 2021
dd2f93f
Unlit and BakedLit does not have specular. Remove _ALPHAPREMULTIPLY.
eh-unity Oct 8, 2021
9ec1dc9
Add unlit shader path for material postprocessor.
eh-unity Oct 8, 2021
1585d1c
Upgrade Unlit shadergraph blendmode.
eh-unity Oct 11, 2021
ef71e61
Upgrade only active subtarget to avoid inactive subtarget override.
eh-unity Oct 11, 2021
c1c542d
Update Unlit premultiplied .shadergraph.
eh-unity Oct 11, 2021
1cc4fb4
Adjust blending test threshold and images.
eh-unity Oct 11, 2021
4aa3740
Disable XR, adjust ref image to 1920x1080.
eh-unity Oct 12, 2021
ad8bb24
Merge branch 'master' into universal/fix-premultiplied-alpha-resurrect
eh-unity Oct 12, 2021
944c65d
Update 050_Shader_Graphs lighting settings and materials.
eh-unity Oct 12, 2021
cac862d
Update 050_Shader_Graphs images.
eh-unity Oct 12, 2021
8c6d7fa
Remove ref images from wrong folder.
eh-unity Oct 12, 2021
cbd3117
Update 066_Blending ref images.
eh-unity Oct 12, 2021
566f128
Merge branch 'master' into universal/fix-premultiplied-alpha-resurrect
eh-unity Oct 18, 2021
969172c
Update linux vulkan.
eh-unity Oct 19, 2021
48edd56
Add changelog for material upgrade.
eh-unity Oct 20, 2021
d40abe0
Disable 050_ShaderGraphs for Android and iOS.
eh-unity Oct 20, 2021
5861cec
Merge branch 'universal/staging' into universal/fix-premultiplied-alp…
phi-lira Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...tion/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/050_Shader_Graphs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ts/ReferenceImages/Linear/Android/OpenGLES3/None/050_Shader_Graphs_Override.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions ...oundation/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/066_Blending.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
98 changes: 98 additions & 0 deletions ...est_Foundation/Assets/ReferenceImages/Linear/Android/OpenGLES3/None/066_Blending.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...ndation/Assets/ReferenceImages/Linear/Android/Vulkan/None/050_Shader_Graphs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ssets/ReferenceImages/Linear/Android/Vulkan/None/050_Shader_Graphs_Override.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions ...t_Foundation/Assets/ReferenceImages/Linear/Android/Vulkan/None/066_Blending.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
98 changes: 98 additions & 0 deletions ...csTest_Foundation/Assets/ReferenceImages/Linear/Android/Vulkan/None/066_Blending.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...ion/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/050_Shader_Graphs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...s/ReferenceImages/Linear/LinuxEditor/Vulkan/None/050_Shader_Graphs_Override.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions ...undation/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/066_Blending.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
98 changes: 98 additions & 0 deletions ...st_Foundation/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/066_Blending.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...ion/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/050_Shader_Graphs.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...s/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/050_Shader_Graphs_Override.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions ...undation/Assets/ReferenceImages/Linear/LinuxPlayer/Vulkan/None/066_Blending.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading