Skip to content

[21.2] Define ENABLE_HYBRID_RENDERER_V2 by default for Hybrid Renderer 0.14.0 and newer #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2021
Merged

[21.2] Define ENABLE_HYBRID_RENDERER_V2 by default for Hybrid Renderer 0.14.0 and newer #5692

merged 2 commits into from
Sep 16, 2021

Conversation

vincent-breysse
Copy link
Contributor

@vincent-breysse vincent-breysse commented Sep 16, 2021 •
edited
Loading

Enable HRV2 by default for DOTS 0.5 since HRV1 will be removed.

Port of #5635

Testing status

Validated normal GameObjects code by testing a few scenes in TestProjects/HDRP_Tests.

Could not test directly since there is no editor compatible with DOTS + SRP 12. I could only manually test the changes with 2020.3/partner/staging + DOTS master + Graphics 10.x.x/release since it's the latest combo that suppport DOTS.

Changelog

com.unity.rendering.hybrid

  • Added: Define ENABLE_HYBRID_RENDERER_V2 by default for Hybrid Renderer 0.14.0 and newer

@vincent-breysse
Add ENABLE_HYBRID_RENDERER_V2 define to more asmdef files
e25e969 
# Conflicts:
#	com.unity.render-pipelines.core/Runtime/Unity.RenderPipelines.Core.Runtime.asmdef
#	com.unity.render-pipelines.high-definition/Editor/Unity.RenderPipelines.HighDefinition.Editor.asmdef
@vincent-breysse vincent-breysse requested a review from a team as a code owner September 16, 2021 14:09
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde merged commit 5868bf4 into 2021.2/staging Sep 16, 2021
@sebastienlagarde sebastienlagarde deleted the 21.2/hrv-default branch September 16, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@JussiKnuuttila JussiKnuuttila JussiKnuuttila approved these changes

Assignees
No one assigned
Labels
HDRP Shader Graph SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent-breysse @sebastienlagarde @JussiKnuuttila