[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

pmavridis · 2021-09-15T09:00:22Z

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1323945/

Transmittance was not tinting the sky correctly. The reason was that the travel distance for missed rays was left to zero (the initialization value) and not the "max length", so it's a rather trivial fix.

Testing status

Using the repro scene from the ticket.

Before:

After:

Comments to reviewers

Alternatively we could have the miss shader write the max_length. I opted to initialize the variable with the correct value, since this does not add any extra instructions in the ray tracing inner loop.

* Fix AxF debug output in certain configurations. * Update comment

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4599)" This reverts commit 2325e3f.

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…positor (#4599)"" This reverts commit 30fffd5.

… the Graphi

…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

github-actions · 2021-09-15T09:00:37Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

pmavridis · 2021-09-15T13:17:09Z

Note: The bug ticket also mentions that enabling the "Transparent write motion vectors" flag adds extra tint to the image.
This happens because in this case the rasterized version of the effect is computed on top of the ray traced one, effectively tinting two times the pixels. This is unrelated to the bug that is fixed in this PR (and we should fix in another PR).

anisunity

Looks simple enough as a fix, hope it doesn't have any side effects.

iM0ve

I have verified the fix too to better understand. In terms of regression testing, I opened HDRPRayTracingScenes project to compare with master. No issues found, I think should be safe if graphic tests are passing

pmavridis and others added 30 commits May 26, 2021 19:23

[HDRP] Fix AxF debug output in certain configurations (#4641)

5945333

* Fix AxF debug output in certain configurations. * Update comment

Fix SSR accumulation white flash (#4648)

64a6c13

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Display Info Box when MSAA + ray tracing is onr (#4627)

f49b710

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix distortion when resizing the window in player builds with the Gra…

05cc16a

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Add support for the camera bridge in the graphics compositor (#4599)

2325e3f

Merge branch 'master' into hd/bugfix

c09379f

Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)

b5962c9

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a memory leak related to not disposing of the RTAS at the end H…

77b6b7f

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix custom pass utils Blur + Copy overdraw. (#4623)

bf941a9

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix draw procedural invalid pass idx 1 on first template load (#4632)

806dfbe

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed light reset to preserve type (#4624)

88779ea

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Add support for the camera bridge in the graphics compositor (#…

30fffd5

…4599)" This reverts commit 2325e3f.

AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …

aabbb4b

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Revert "Add support for the camera bridge in the graphics com…

dfdb311

…positor (#4599)"" This reverts commit 30fffd5.

revert: Fix distortion when resizing the window in player builds with…

891fda0

… the Graphi

Merge branch 'master' into hd/bugfix

7b17e06

Merge branch 'master' into hd/bugfix

32df1bf

Fix for discrepancies in saturation and intensity between screen spac…

0032b9c

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (

41716f0

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix VfX lit particle AOV output color space (#4646)

333c800

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Fixed transparent unlit (#4605)

809316c

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

7b1ad29

Fix distortion with MSAA (#4711)

08a578d

Fix contact shadow debug views (#4720)

3c418c0

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update Decal-Projector.md (#4695)

352f65d

[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…

acc5073

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd54a00

Fix decal layer enum (#4753)

1672dc6

Fix typo

c40c5c5

sebastienlagarde and others added 5 commits September 12, 2021 20:48

Update path tracer screenshots

7e170a1

Update 2314_Shadow_CustonAngle.png

ca75d7a

Merge branch 'master' into hd/bugfix

09f80a2

Merge branch 'master' into hd/bugfix

b1adf78

Fix distance of transmitted missed rays in recursive rendering

5c8174e

pmavridis added HDRP dxr labels Sep 15, 2021

pmavridis requested review from sebastienlagarde, anisunity and a team September 15, 2021 09:00

Changelog

e242ee2

pmavridis added needs-backport-10.x needs-backport-2021.1 needs-backport-2021.2 labels Sep 15, 2021

anisunity approved these changes Sep 16, 2021

View reviewed changes

sebastienlagarde approved these changes Sep 16, 2021

View reviewed changes

iM0ve approved these changes Sep 17, 2021

View reviewed changes

sebastienlagarde changed the base branch from hd/bugfix to master September 17, 2021 12:37

sebastienlagarde marked this pull request as ready for review September 17, 2021 12:37

Merge branch 'master' into HDRP/dxr_recursive_miss

9c63468

sebastienlagarde merged commit eeb3167 into master Sep 17, 2021

sebastienlagarde deleted the HDRP/dxr_recursive_miss branch September 17, 2021 12:38

sebastienlagarde added backported-10.x and removed needs-backport-10.x labels Sep 17, 2021

sebastienlagarde pushed a commit that referenced this pull request Sep 17, 2021

[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

f8d4be0

sebastienlagarde added backported-2021.2 and removed needs-backport-2021.2 labels Sep 20, 2021

sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021

[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

0eea587

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

Uh oh!

pmavridis commented Sep 15, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Sep 15, 2021

Uh oh!

pmavridis commented Sep 15, 2021 •

edited

Loading

Uh oh!

anisunity left a comment

Uh oh!

iM0ve left a comment

Uh oh!

Uh oh!

[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

[HDRP][DXR] Fix recursive rendering transmittance over the sky #5663

Uh oh!

Conversation

pmavridis commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

github-actions bot commented Sep 15, 2021

Uh oh!

pmavridis commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anisunity left a comment

Choose a reason for hiding this comment

Uh oh!

iM0ve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pmavridis commented Sep 15, 2021 •

edited

Loading

pmavridis commented Sep 15, 2021 •

edited

Loading