Skip to content

Universal/doc 3399 rename to closed plat #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

jpriyas
Copy link
Contributor

@jpriyas jpriyas commented Sep 14, 2021

This PR removes the old text that listed the NDA platforms and their package names explicitly.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.


## Platform package installation

To install a platform package, download it from the relevant platform developer forum (you cannot get these packages from the package registry or Package Manager). To do this:
To install a platform package, download it from the relevant platform developer forum. Note that you cannot get these packages from the package registry or Package Manager. To do this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion:

Closed platform packages are not available in the package registry and the Package Manager.

To install a closed platform package:

  1. Download the package from the relevant platform developer forum.

  2. Use the Package Manager to install the package locally. For information on how to install packages locally, see Installing a local package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point -- I'll implement your suggestions.

Incorporated Alex's feedback.
Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed doc changes, looks good.

Copy link
Contributor

@oleks-k oleks-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jpriyas jpriyas merged commit 2346c7e into master Sep 15, 2021
@jpriyas jpriyas deleted the universal/DOC-3399-rename-to-closed-plat branch September 15, 2021 08:35
jpriyas added a commit that referenced this pull request Sep 15, 2021
jpriyas added a commit that referenced this pull request Sep 15, 2021
@jpriyas jpriyas mentioned this pull request Sep 15, 2021
ellioman pushed a commit that referenced this pull request Sep 17, 2021
ellioman pushed a commit that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants