Skip to content

[ShaderGraph][2021.2][Backport] Fix for 1365186 - correct direction transform from view to world space #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

jessebarker
Copy link
Contributor

Purpose of this PR

This PR fixes https://fogbugz.unity3d.com/f/cases/1365186/

Transform direction from view to world was effectively doing a position transform rather than direction. This change fixes that.

Testing status

Without these changes, transforming (direction) from world->view->world and subtracting the result from the original vector yields non-0 value in Z:
image

With these changes:
Screen Shot 2021-09-10 at 2 32 02 PM


Comments to reviewers

Notes for the reviewers you have assigned.

@jessebarker jessebarker requested a review from a team as a code owner September 13, 2021 21:33
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@jessebarker
Copy link
Contributor Author

The draft reminder check/action is failing, but it looks like it is set up wrong (trying to do something on 'master'). Everything else is passing.

@jessebarker jessebarker merged commit 19d907d into 2021.2/staging Sep 14, 2021
@jessebarker jessebarker deleted the 2021.2/sg-fix-1365186 branch September 14, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants