-
Notifications
You must be signed in to change notification settings - Fork 849
Changed Ambient Mode to Dynamic by default #5350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial enough, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has already been discussed a few time within HDRP QA and besides the few downside that comes with it, still an improvement, especially for new users. ✔️
Purpose of this PR
Change the defaults of the Visual Environment component's Ambient mode to "Dynamic".
The idea is that by default it will provide users a more "out of the box" experience where ambient lighting works without any manual action from them.
This should not break any existing project apart from one very specific case: If the user's project does not have a default volume profile already containg a visual environment component, a new one will be created by HDRP automatically in memory and will then use Dynamic Ambient contrary to default static.
I feel that this is not too much of a problem because very few projects will have that issue since we always create one by default.
Issue raised in this case https://fogbugz.unity3d.com/f/cases/1357625/
Testing status