Skip to content

Changed Ambient Mode to Dynamic by default #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

JulienIgnace-Unity
Copy link
Contributor

@JulienIgnace-Unity JulienIgnace-Unity commented Aug 16, 2021

Purpose of this PR

Change the defaults of the Visual Environment component's Ambient mode to "Dynamic".
The idea is that by default it will provide users a more "out of the box" experience where ambient lighting works without any manual action from them.

This should not break any existing project apart from one very specific case: If the user's project does not have a default volume profile already containg a visual environment component, a new one will be created by HDRP automatically in memory and will then use Dynamic Ambient contrary to default static.
I feel that this is not too much of a problem because very few projects will have that issue since we always create one by default.

Issue raised in this case https://fogbugz.unity3d.com/f/cases/1357625/


Testing status

  • Created a new Visual Env component and checked that Ambient was indeed Dynamic
  • Tested that existing components were not changed.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Aug 16, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@JulienIgnace-Unity JulienIgnace-Unity changed the title Hd/sky default dynamic Changed Ambient Mode to Dynamic by default Aug 16, 2021
Copy link
Contributor

@anisunity anisunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial enough, lgtm

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has already been discussed a few time within HDRP QA and besides the few downside that comes with it, still an improvement, especially for new users. ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants