Skip to content

Updated minDistance epsilon URP decal #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

Jonasmortensen
Copy link
Contributor

Purpose of this PR

This is a URP port of this HDRP PR: #5199
It fixes an issue caused by a large epsilon value.
Images are from URP:
Before
DecalEpsilonBefore
After
DecalEpsilonAfter

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@lukaschod
Copy link
Contributor

Could you check just in case it is not updating always now, just to be sure as it would be performance regression.

@lukaschod lukaschod self-requested a review August 12, 2021 09:16
@Jonasmortensen
Copy link
Contributor Author

Could you check just in case it is not updating always now, just to be sure as it would be performance regression.

Confirmed that the decals are only updated when moving the transform.
Tested by logging a message after the early return in Execute() of the UpdateTransformsJob

@Jonasmortensen Jonasmortensen marked this pull request as ready for review August 16, 2021 15:07
@Jonasmortensen Jonasmortensen requested review from a team as code owners August 16, 2021 15:07
Copy link

@aleksandrasdzikia aleksandrasdzikia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As talked to Jonas, no tests need, approving on behalf of gfx-urp team.

@Jonasmortensen Jonasmortensen merged commit 8f52724 into master Sep 8, 2021
@Jonasmortensen Jonasmortensen deleted the universal/FixingEpsilonOnDecalProjectors branch September 8, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants