Fix diffusion profile info box in VFX graph (and potentially other tools) #4977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix AxF debug output in certain configurations. * Update comment
* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix custom pass volume not executed in scene view because of the volume culling mask * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
… into hd/bugfix # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Updated the Physically Based Sky documentation for baked lights * Rewrite Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed remapping of depth pyramid debug * Removed debug pragma * Update changelog * Updated tooltip
…ion is enabled. (#4895) * Fix AO perceived wobble * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Check for asymmetric projections and choose the generic path if so. * Fix asymmetric projections for the pathtracer ray generation. * Changelog * Simplify the matrix multiplication for computing the generic matrix. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
RSlysz
reviewed
Jun 30, 2021
There was a problem hiding this comment.
Seams good.
@TheoWong-pixel it seams that we have 3 different design for this fix button in helpbox:
- The one that we used in Material (if still the same)
- The one that we use here and in DiffusionProfileMaterial
- The one that is done here #4922 (review)
Tell us which one we should use :/
(This can be be fixed in a later quality pass if needed)
RSlysz
approved these changes
Jun 30, 2021
peeweek
approved these changes
Jun 30, 2021
iM0ve
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
No issues found
Whats tested:
- Upgraded a simple scene with assets + particles using Diffusion profiles
- Checked that the new info boxes appear and the existing ones are sitll present
- Tried the FIX button to see it actually works
- Upgraded HDRP template to check on the bamboo trees to see if any unexpected behaviour is present
Before PR (no fix on vfx)
After PR (fix for materials and vfx is available)
After FIX is pressed
sebastienlagarde
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Address a small UI bug where the diffusion profile infobox was not displayed in VFX Graph:
Before:
After:
Issue Reference: https://unity.slack.com/archives/C6Y79CZM0/p1623934772104100
Bonus: for scripts that have access to the HDRP internals: they now have the same infobox by default:
Testing status
Tested for regression everywhere there is a diffusion profile visible:
HDRP material + Shadergraphs:
Volume profile override:
HDRP Global Settings: