Unity-Technologies · sebastienlagarde · May 15, 2020 · Apr 3, 2020 · Apr 7, 2020 · Apr 3, 2020
diff --git a/TestProjects/HDRP_PerformanceTests/Assets/PerformanceTests/Editor/HDReflectionSystemTests.cs b/TestProjects/HDRP_PerformanceTests/Assets/PerformanceTests/Editor/HDReflectionSystemTests.cs
@@ -0,0 +1,52 @@
+using System.Collections;
+using System.Collections.Generic;
+using UnityEngine;
+using UnityEditor.Rendering;
+using UnityEngine.TestTools;
+using NUnit.Framework;
+using System.Text.RegularExpressions;
+using System.Globalization;
+using System.Threading;
+using Unity.PerformanceTesting;
+using UnityEditor.Rendering.HighDefinition;
+using UnityEngine.Rendering;
+using UnityEngine.Rendering.HighDefinition;
+using static PerformanceTestUtils;
+using static PerformanceMetricNames;
+
+public class HDReflectionSystemTests : EditorPerformanceTests
+{
+    [Version("1"), Test, Performance]
+    public void HDProbeSystemRegister()
+    {
+        using (ListPool<HDProbe>.Get(out var probes))
+        {
+            // Create a lot of probe
+            for (var i = 0; i < 10000; ++i)
+            {
+                var gameObject = new GameObject(i.ToString("0000"));
+                // Deactivate the GameObject to avoid OnEnable calls (which register the probe)
+                gameObject.SetActive(false);
+                gameObject.AddComponent<ReflectionProbe>();
+                var probe = gameObject.AddComponent<HDAdditionalReflectionData>();
+                probe.enabled = false;
+                probes.Add(probe);
+            }
+
+            // Measure registration
+            Measure.Method(() =>
+            {
+                foreach (var probe in probes)
+                    HDProbeSystem.RegisterProbe(probe);
+            }).Run();
+
+            // Unregister
+            foreach (var probe in probes)
+                HDProbeSystem.UnregisterProbe(probe);
+
+            // Delete the probes
+            foreach (var probe in probes)
+                Object.DestroyImmediate(probe.gameObject);
+        }
+    }
+}
diff --git a/...ects/HDRP_PerformanceTests/Assets/PerformanceTests/Editor/HDReflectionSystemTests.cs.meta b/...ects/HDRP_PerformanceTests/Assets/PerformanceTests/Editor/HDReflectionSystemTests.cs.meta
diff --git a/...nition/Documentation~/Images/LookDev1.png → ...s.core/Documentation~/Images/LookDev1.png b/...nition/Documentation~/Images/LookDev1.png → ...s.core/Documentation~/Images/LookDev1.png
diff --git a/...nition/Documentation~/Images/LookDev2.png → ...s.core/Documentation~/Images/LookDev2.png b/...nition/Documentation~/Images/LookDev2.png → ...s.core/Documentation~/Images/LookDev2.png
diff --git a/...nition/Documentation~/Images/LookDev3.png → ...s.core/Documentation~/Images/LookDev3.png b/...nition/Documentation~/Images/LookDev3.png → ...s.core/Documentation~/Images/LookDev3.png
diff --git a/...nition/Documentation~/Images/LookDev4.png → ...s.core/Documentation~/Images/LookDev4.png b/...nition/Documentation~/Images/LookDev4.png → ...s.core/Documentation~/Images/LookDev4.png
diff --git a/...nition/Documentation~/Images/LookDev5.png → ...s.core/Documentation~/Images/LookDev5.png b/...nition/Documentation~/Images/LookDev5.png → ...s.core/Documentation~/Images/LookDev5.png
diff --git a/...nition/Documentation~/Images/LookDev6.png → ...s.core/Documentation~/Images/LookDev6.png b/...nition/Documentation~/Images/LookDev6.png → ...s.core/Documentation~/Images/LookDev6.png
diff --git a/...nition/Documentation~/Images/LookDev7.png → ...s.core/Documentation~/Images/LookDev7.png b/...nition/Documentation~/Images/LookDev7.png → ...s.core/Documentation~/Images/LookDev7.png
diff --git a/...nition/Documentation~/Images/LookDev8.png → ...s.core/Documentation~/Images/LookDev8.png b/...nition/Documentation~/Images/LookDev8.png → ...s.core/Documentation~/Images/LookDev8.png
diff --git a/...nition/Documentation~/Images/LookDev9.png → ...s.core/Documentation~/Images/LookDev9.png b/...nition/Documentation~/Images/LookDev9.png → ...s.core/Documentation~/Images/LookDev9.png
diff --git a/...on~/Images/LookDevEnvironmentLibrary1.png → ...on~/Images/LookDevEnvironmentLibrary1.png b/...on~/Images/LookDevEnvironmentLibrary1.png → ...on~/Images/LookDevEnvironmentLibrary1.png
diff --git a/...on~/Images/LookDevEnvironmentLibrary2.png → ...on~/Images/LookDevEnvironmentLibrary2.png b/...on~/Images/LookDevEnvironmentLibrary2.png → ...on~/Images/LookDevEnvironmentLibrary2.png
diff --git a/...on~/Images/LookDevEnvironmentLibrary3.png → ...on~/Images/LookDevEnvironmentLibrary3.png b/...on~/Images/LookDevEnvironmentLibrary3.png → ...on~/Images/LookDevEnvironmentLibrary3.png
diff --git a/...on~/Images/LookDevEnvironmentLibrary4.png → ...on~/Images/LookDevEnvironmentLibrary4.png b/...on~/Images/LookDevEnvironmentLibrary4.png → ...on~/Images/LookDevEnvironmentLibrary4.png
diff --git a/...on~/Images/LookDevEnvironmentLibrary5.png → ...on~/Images/LookDevEnvironmentLibrary5.png b/...on~/Images/LookDevEnvironmentLibrary5.png → ...on~/Images/LookDevEnvironmentLibrary5.png
diff --git a/...entation~/Look-Dev-Environment-Library.md → ...entation~/Look-Dev-Environment-Library.md b/...entation~/Look-Dev-Environment-Library.md → ...entation~/Look-Dev-Environment-Library.md
@@ -47,6 +47,6 @@ To add, remove, or duplicate environments, use the toolbar at the bottom of the
 
 ## Importing an HDRI Texture
 
-To import an HDRI Texture into the Unity Editor, load an **.hdr** or **.exr** file into your Unity Project like you would any other image. In the Texture Importer Inspector window, set **Texture Type** to **Default**, set **Texture Shape** to **Cube**, and set **Convolution Type** to **Specular (Glossy Reflection)**.
+To import an HDRI Texture into the Unity Editor, load an **.hdr** or **.exr** file into your Unity Project like you would any other image. In the Texture Importer Inspector window, set **Texture Type** to **Default**, set **Texture Shape** to **Cube**, and set **Convolution Type** to **None**.
 
 When you want to test an HDRI Texture Asset or a skybox cube map Material, drag and drop it into the Look Dev view.
diff --git a/com.unity.render-pipelines.core/Documentation~/Look-Dev.md b/com.unity.render-pipelines.core/Documentation~/Look-Dev.md
@@ -0,0 +1,142 @@
+# Look Dev
+
+Look Dev is an image-based lighting tool that contains a viewer for you to check and compare Assets to ensure they work well in various lighting conditions. Look Dev uses the Scriptable Render Pipeline, so it can display the Asset in the same way as it looks in your Scene. You can load Assets into Look Dev either as Prefabs or from the Hierarchy window.
+
+Look Dev is only available in Edit mode. The Look Dev window closes when you enter Play mode.
+
+### Asset validation
+
+Asset validation confirms whether Assets are authored correctly and behave as expected in different lighting environments.
+
+You must use an HDRI (high dynamic range image) to validate your Assets in Look Dev. An HDRI contains real-world lighting with incredibly high detail. As such, it offers perfect lighting that is difficult to create by hand. By using such an accurate lighting environment to test an Asset, you can determine whether the Asset itself or your Project's lighting is reducing the visual quality of your Scene.
+
+You can load two different Assets into Look Dev at the same time and compare them in two viewports. For example, an Art Director can check that a new Asset matches the art direction guidelines of a reference Asset.
+
+## Using Look Dev
+
+To open Look Dev in the Unity Editor, select **Window > Render Pipeline > Look Dev**. The first time you use Look Dev, you must either create a new [Environment Library](Look-Dev-Environment-Library.html) or load one. For information on how to create an Environment Library, see the [Environment Library documentation](Look-Dev-Environment-Library.html).
+
+### Viewports
+
+By default, there is only one viewport in Look Dev, but you can choose from a selection of split-screen views (see the [Multi-view section](#MultiView)).
+
+### Controls
+
+Navigation with the Look Dev Camera works in a similar way to the [Scene view Camera](https://docs.unity3d.com/Manual/SceneViewNavigation.html):
+
+- **Rotate around pivot:** Left click and drag (this is similar to the Scene view except that you need to press the Alt key for the Scene view Camera).
+- **Pan camera:** Middle click and drag.
+- **Zoom:** Alt + right click and drag.
+- **Forward/backward:** Mouse wheel.
+- **First Person mode:** Right click + W, A,S, and D.
+
+### Loading Assets into Look Dev 
+
+Look Dev lets you view:
+
+**Prefabs** - To load a Prefab into Look Dev, drag it from the Project window into the Look Dev viewport.
+
+**GameObjects** - To load a copy of a Hierarchy GameObject, drag the GameObject from the Hierarchy into the Look Dev viewport.
+
+
+
+## Viewport modes
+
+Use the toolbar in the top-left of the window to change which viewing mode Look Dev uses.
+
+### Single viewport
+
+![](Images/LookDev1.png)
+
+By default, Look Dev displays a single viewport which contains the Prefab or GameObject you are working with. If you are in another viewing mode, you can click either the number **1** or number **2** button to go back to single view. Each button corresponds to a viewport in Look Dev. Select button **1** to use viewport 1, and button 2 to use viewport **2**.
+
+<a name="MultiView"></a>
+
+### Multi-viewport
+
+![](Images/LookDev2.png)
+
+Use multiple viewports to compare different environments and settings for the same Asset. You can arrange viewports:
+
+- Vertically side-by-side. Use this mode to compare two different lighting conditions on the same Asset to check that the Asset behaves correctly.
+- Horizontally side-by-side. Use this mode to compare two different lighting conditions for horizontal objects, like an environment Asset, to check that the Asset behaves correctly. 
+- Split-screen. Use this mode investigate texture problems using a debug Shader mode (for example, use one screen to view Normal or Albedo shading, and the other for environment-lit mode).
+- Side-by-side and split-screen: Use this mode to compare two different versions of the same Asset using the same lighting conditions to see which changes improve the Asset’s quality.
+
+All three of these modes are useful to compare two different versions of the same Asset using the same lighting conditions to see which changes improve the Asset’s quality.
+
+To load a different Prefab or Hierarchy GameObject into each split-screen view, drag and drop the Asset into the viewport that you want to view it in.
+
+When using multiple viewports, it only makes sense to compare different Prefabs or GameObjects when you want to look at two versions of the same Asset. Comparing completely different Assets doesn’t give you a good idea of the difference in lighting or visual effect.
+
+##### Vertical or horizontal side-by-side
+
+Vertical and horizontal side-by-side viewports show an identical view of your Asset.
+
+![](Images/LookDev3.png)
+
+##### Split-screen
+
+In a split-screen view, there is a red/blue manipulation Gizmo that separates the two viewports. For information on how to use this Gizmo, see [Using the manipulation Gizmo](#ManipulationGizmo).
+
+![](Images/LookDev4.png)
+
+#### Multi-viewport Camera
+
+By default, Look Dev synchronizes the camera movement for both views. To decouple the Cameras from one another, and manipulate them independently, click the **Synchronized Cameras** button in-between the two numbered Camera buttons.
+
+![](Images/LookDev5.png)
+
+To align the cameras with each other, or reset them, click on the drop-down arrow next to the viewport **2** icon:
+
+![](Images/LookDev6.png)
+
+<a name="ManipulationGizmo"></a>
+
+### Using the manipulation Gizmo
+
+The manipulation Gizmo represents the separation plane between the two viewports. It has different behavior in split-screen mode, but you use it in the same way for both side-by-side or split-screen modes.
+
+#### Moving the separator
+
+To move the separator, click and drag the straight line of the Gizmo to the location you want.
+
+![](Images/LookDev7.png)
+
+#### Changing the orientation and length
+
+To change the orientation and length of the manipulator Gizmo, click and drag the circle at either end of the manipulator. Changing the length of the Gizmo lets you  set the orientation and [blending](#Blending) values more precisely.
+
+![](Images/LookDev8.png))
+
+#### Changing the split in increments
+
+To change the split in increments, click and hold the circle on the end of the manipulation Gizmo, then hold Shift as you move the mouse. This snaps the manipulation Gizmo to set angles in increments of 22.5°, which is useful for a perfectly horizontal, vertical or diagonal angle.
+
+<a name="Blending"></a>
+
+#### Blending
+
+The central white circle on the separator allows you to blend between the two views. Left click on it and drag along the red line to blend the left-hand view with the right-hand view. Drag along the blue line to blend the right-hand view with the left-hand view (as shown in the image below).
+
+The white circle automatically snaps back into the center when you drag it back. This helps you get back to the default blending value quickly.
+
+![](Images/LookDev9.png)
+
+### HDRI environments in Look Dev
+
+Lighting in Look Dev uses an HDRI. The Look Dev view allows you to manipulate and easily switch between HDRIs to simulate different environments for the Asset you are working on.
+
+Look Dev uses the [Environment Library](Look-Dev-Environment-Library.html) Asset to store a list of environments, which are HDRIs with extra properties that you can use to further refine the environment. For information on how to create, edit, and assign Environment Libraries, see the [Environment Library documentation](Look-Dev-Environment-Library.html#Creation).
+
+## Implementing Look Dev for your custom Scriptable Render Pipeline
+
+In order to use Look Dev in your custom Scriptable Render Pipeline, you must implement the **UnityEngine.Rendering.LookDev.IDataProvider** interface.
+
+| **Function**                                                 | **Description**                                              |
+| ------------------------------------------------------------ | ------------------------------------------------------------ |
+| **void FirstInitScene(StageRuntimeInterface stage)**         | Look Dev calls this function after it initializes the Scene with a Light and Camera. It uses this function to add and configure extra components according to the needs of your Scriptable Render Pipeline. |
+| **void UpdateSky(Camera camera, Sky sky, StageRuntimeInterface stage)** | Look Dev uses this function to update the environment when you change something in Look Dev. You can handle the sky in various ways, so add code that corresponds to your Scriptable Render Pipeline. |
+| **IEnumerable****<string>** **supportedDebugModes { get; }** | Use this function to specify the list of supported debug modes. You do not need to add **None** because Look Dev handles that automatically. |
+| **void UpdateDebugMode(int debugIndex)**                     | Use this function to update the debug mode based on what the user selects. The **debugIndex** matches the list in **supportedDebugModes**. If the user selects **None**, then the **debugIndex** is **-1**; |
+| **void GetShadowMask(ref RenderTexture output, StageRuntimeInterface stage)** | This function computes a shadow map. The given **StageRuntimeInterface** contains access to the Camera and a Light simulating the sun. |
diff --git a/com.unity.render-pipelines.core/Documentation~/TableOfContents.md b/com.unity.render-pipelines.core/Documentation~/TableOfContents.md
@@ -1,4 +1,6 @@
 * [SRP Core](index)
 * Camera components
   * [Free Camera](Free-Camera)
-  * [Camera Switcher](Camera-Switcher)
+  * [Camera Switcher](Camera-Switcher)
+* [Look Dev](Look-Dev)
+  * [Environment Library](Look-Dev-Environment-Library)
diff --git a/com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.cs b/com.unity.render-pipelines.core/Editor/Debugging/DebugUIDrawer.cs
@@ -36,10 +36,12 @@ protected T Cast<T>(object o)
             where T : class
         {
             var casted = o as T;
-            string typeName = o == null ? "null" : o.GetType().ToString();
 
             if (casted == null)
+            {
+                string typeName = o == null ? "null" : o.GetType().ToString();
                 throw new InvalidOperationException("Can't cast " + typeName + " to " + typeof(T));
+            }
 
             return casted;
         }

diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added Light decomposition lighting debugging modes and support in AOV
 - Added exposure compensation to Fixed exposure mode
 - Added an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA.
+- Added Layer parameter on Area Light to modify Layer of generated Emissive Mesh
 
 ### Fixed
 - Fixed an issue where a dynamic sky changing any frame may not update the ambient probe.
@@ -60,6 +61,28 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155)
 - Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. Note that the diffusion profile or the material references need to be edited once before this can work properly.
 - Fixed SceneView Draw Modes not being properly updated after opening new scene view panels or changing the editor layout.
+- Fixed shadowmask UI now correctly showing shadowmask disable
+- Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled).
+- Fixed depth prepass and postpass being disabled after changing the shader in the material UI.
+- Fixed a performance issue with stochastic ray traced area shadows.
+- Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.
+- Fixed a null ref exception in static sky when the default volume profile is invalid.
+- Fixed an error about procedural sky being logged by mistake.
+- Fixed flickering of the game/scene view when lookdev is running.
+- Fixed some GCAlloc in the debug window.
+- Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system.
+- Fixed over consumption of GPU memory by the Physically Based Sky.
+- Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type.
+- Fixed an issue where asset preview could be rendered white because of static lighting sky.
+- Fixed an issue where static lighting was not updated when removing the static lighting sky profile.
+- Fixed issue with reflection probes in realtime time mode with OnEnable baking having wrong lighting with sky set to dynamic (case 1238047).
+- Fixed an invalid rotation in Planar Reflection Probe editor display, that was causing an error message (case 1182022)
+- Fixed cookie texture not updated when changing an import settings (srgb for example).
+- Fix error when removing DecalProjector from component contextual menu (case 1243960)
+- Fixed issue with post process when running in RGBA16 and an object with additive blending is in the scene.
+- Fixed issue that caused not all baked reflection to be deleted upon clicking "Clear Baked Data" in the lighting menu (case 1136080)
+- Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color
+- Fixed transparent motion vectors not working when in MSAA.
 
 ### Changed
 - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.
@@ -70,6 +93,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.
 - Renamed "Environment" to "Reflection Probes" in tile/cluster debug menu.
 - Debug exposure in debug menu have been replace to debug exposure compensation in EV100 space and is always visible.
+- Improved performance of reflection probe management when using a lot of probes.
 
 ## [7.3.0] - 2020-03-11
 

diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Creating-a-Custom-Sky.md b/com.unity.render-pipelines.high-definition/Documentation~/Creating-a-Custom-Sky.md
@@ -59,6 +59,12 @@ public class NewSky : SkySettings
         }
         return hash;
     }
+
+    public override int GetHashCode(Camera camera)
+    {
+        // Implement if your sky depends on the camera settings (like position for instance)
+        return GetHashCode();
+    }
 }
 
 ```
@@ -159,6 +165,10 @@ class NewSkyRenderer : SkyRenderer
 }
 
 ```
+### Important note:
+If your sky renderer has to manage heavy data (like precomputed textures or similar things) then particular care has to be taken. Indeed, one instance of the renderer will exist per camera so by default if this data is a member of the renderer, it willl also be duplicated in memory.
+Since each sky renderer can have very different needs, the responsbility to share this kind of data is the renderer's and need to be implemented by the user.
+
 <a name="RenderingShader"></a>
 
 ## Sky rendering Shader

diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Custom-Post-Process.md b/com.unity.render-pipelines.high-definition/Documentation~/Custom-Post-Process.md
@@ -113,7 +113,7 @@ Now there are the **Setup**, **Render**, and **Cleanup** functions. These are he
 
 ### GrayScale Shader
 
-HDRP gives you total control over the vertex and fragment Shader so you can edit both of them to suit your needs. Note that there are a number of utility functions in [Common.hlsl](https://github.com/Unity-Technologies/ScriptableRenderPipeline/blob/master/com.unity.render-pipelines.core/ShaderLibrary/Common.hlsl) and [Color.hlsl](https://github.com/Unity-Technologies/ScriptableRenderPipeline/blob/master/com.unity.render-pipelines.core/ShaderLibrary/Color.hlsl) that the Shader includes by default. This means that you have access to these utility functions in your effect. For example, the GrayScale Shader uses the Luminance() function to convert a linear RGB value to its luminance equivalent.
+HDRP gives you total control over the vertex and fragment Shader so you can edit both of them to suit your needs. Note that there are a number of utility functions in [Common.hlsl](https://github.com/Unity-Technologies/Graphics/blob/master/com.unity.render-pipelines.core/ShaderLibrary/Common.hlsl) and [Color.hlsl](https://github.com/Unity-Technologies/Graphics/blob/master/com.unity.render-pipelines.core/ShaderLibrary/Color.hlsl) that the Shader includes by default. This means that you have access to these utility functions in your effect. For example, the GrayScale Shader uses the Luminance() function to convert a linear RGB value to its luminance equivalent.
 ```
 Shader "Hidden/Shader/GrayScale"